bryce/jquery.uls
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix to avoid displaying duplicate results caused by redirects

Browse Source
This commit is contained in:
Niklas Laxström
2018-02-07 15:24:15 +02:00
parent 9fba3ab728
commit 0352b3df0d
1 changed files with 20 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

29
src/jquery.uls.languagefilter.js
View File

@@ -207,20 +207,31 @@
var autofillLabel, var autofillLabel,
results = []; results = [];
$.each( result.languagesearch, function ( code, name ) { $.each( result.languagesearch, function ( apiCode, name ) {
var target; var code,
redirect = $.uls.data.isRedirect( apiCode );
if ( this.options.languages[ code ] ) { if ( this.options.languages[ apiCode ] ) {
autofillLabel = autofillLabel || name; code = apiCode;
results.push( code ); } else if ( redirect && this.options.languages[ redirect ] ) {
// Language tags are messy. Try to make sure we handle
// them gracefully with regards to redirects.
code = redirect;
} else {
return; return;
} }
// Try to hide issues caused by inconsistent language codes // Because of the redirect checking above, we might get duplicates.
target = $.uls.data.isRedirect( code ); // For example if API returns both `sr` and `sr-cyrl`, the former
if ( target && this.options.languages[ target ] ) { // could get mapped to `sr-cyrl` and then we would have it twice.
// The exact cases when this happens of course depends on what is in
// options.languages, which might contain redirects such as `sr`. In
// this case we only show `sr` if no other variants are there.
// This also protects against broken search APIs returning duplicate
// results, although that is not happening in practice.
if ( results.indexOf( code ) === -1 ) {
autofillLabel = autofillLabel || name; autofillLabel = autofillLabel || name;
results.push( target ); results.push( code );
} }
}.bind( this ) ); }.bind( this ) );