Update package.json and fix eslint issues (#322)

This commit is contained in:
Kartik Mistry
2018-09-06 15:41:27 +05:30
committed by Santhosh Thottingal
parent 9ab4deeb4e
commit 27c21219b4
5 changed files with 31 additions and 24 deletions

View File

@@ -11,8 +11,8 @@
"l10n" "l10n"
], ],
"author": { "author": {
"name": "Santhosh Thottingal", "name": "Santhosh Thottingal",
"email": "santhosh.thottingal@gmail.com" "email": "santhosh.thottingal@gmail.com"
}, },
"contributors": [ "contributors": [
"Alolita Sharma", "Alolita Sharma",
@@ -25,26 +25,27 @@
"Siebrand Mazeland" "Siebrand Mazeland"
], ],
"devDependencies": { "devDependencies": {
"eslint-config-wikimedia": "0.5.0", "eslint-config-wikimedia": "^0.7.2",
"grunt": "^1.0.1", "eslint-plugin-qunit": "^3.3.0",
"grunt-eslint": "20.1.0", "grunt": "^1.0.3",
"grunt-stylelint": "0.9.0", "grunt-contrib-qunit": "^3.0.1",
"stylelint": "8.2.0", "grunt-eslint": "21.0.0",
"grunt-contrib-qunit": "^1.2.0", "grunt-stylelint": "0.10.0",
"stylelint-config-wikimedia": "0.4.2" "stylelint": "9.2.0",
"stylelint-config-wikimedia": "0.4.3"
}, },
"repository": { "repository": {
"type": "git", "type": "git",
"url": "git://github.com/wikimedia/jquery.uls.git" "url": "git://github.com/wikimedia/jquery.uls.git"
}, },
"bugs": { "bugs": {
"url" : "https://github.com/wikimedia/jquery.uls/issues" "url": "https://github.com/wikimedia/jquery.uls/issues"
}, },
"engine": { "engine": {
"node": ">=6.11.1" "node": ">=6.11.1"
}, },
"license": "(MIT OR GPL-2.0+)", "license": "(MIT OR GPL-2.0+)",
"scripts": { "scripts": {
"test": "grunt test --verbose" "test": "grunt test --verbose"
} }
} }

View File

@@ -302,7 +302,8 @@
* @param {Event} e * @param {Event} e
*/ */
cancel: function ( e ) { cancel: function ( e ) {
if ( e && ( this.$element.is( e.target ) || $.contains( this.$element[ 0 ], e.target ) ) ) { if ( e && ( this.$element.is( e.target ) ||
$.contains( this.$element[ 0 ], e.target ) ) ) {
return; return;
} }
@@ -427,7 +428,7 @@
* since the last time it was invoked. * since the last time it was invoked.
* *
* @param {Function} fn Function to be debounced. * @param {Function} fn Function to be debounced.
* @param {Number} wait Wait interval in milliseconds. * @param {number} wait Wait interval in milliseconds.
* @param {boolean} [immediate] Trigger the function on the leading edge of the wait interval, * @param {boolean} [immediate] Trigger the function on the leading edge of the wait interval,
* instead of the trailing edge. * instead of the trailing edge.
* @return {Function} Debounced function. * @return {Function} Debounced function.

View File

@@ -27,7 +27,8 @@
*/ */
$.uls.data.isRedirect = function ( language ) { $.uls.data.isRedirect = function ( language ) {
return ( $.uls.data.languages[ language ] !== undefined && return ( $.uls.data.languages[ language ] !== undefined &&
$.uls.data.languages[ language ].length === 1 ) ? $.uls.data.languages[ language ][ 0 ] : false; $.uls.data.languages[ language ].length === 1 ) ?
$.uls.data.languages[ language ][ 0 ] : false;
}; };
/** /**
@@ -77,7 +78,8 @@
return $.uls.data.getAutonym( target ); return $.uls.data.getAutonym( target );
} }
return ( $.uls.data.languages[ language ] && $.uls.data.languages[ language ][ 2 ] ) || language; return ( $.uls.data.languages[ language ] &&
$.uls.data.languages[ language ][ 2 ] ) || language;
}; };
/** /**
@@ -137,7 +139,7 @@
* Returns an associative array of languages in a region, * Returns an associative array of languages in a region,
* grouped by script group. * grouped by script group.
* @param {string} region Region code * @param {string} region Region code
* @return {object} * @return {Object}
*/ */
$.uls.data.getLanguagesByScriptGroupInRegion = function ( region ) { $.uls.data.getLanguagesByScriptGroupInRegion = function ( region ) {
return $.uls.data.getLanguagesByScriptGroupInRegions( [ region ] ); return $.uls.data.getLanguagesByScriptGroupInRegions( [ region ] );

View File

@@ -268,7 +268,8 @@
} }
userInput = this.$element.val(); userInput = this.$element.val();
suggestion = userInput + languageName.substring( userInput.length, languageName.length ); suggestion = userInput +
languageName.substring( userInput.length, languageName.length );
if ( suggestion.toLowerCase() !== languageName.toLowerCase() ) { if ( suggestion.toLowerCase() !== languageName.toLowerCase() ) {
// see if it was autonym match // see if it was autonym match

View File

@@ -41,7 +41,8 @@
* @cfg {number} [columns] Number of columns for languages. Default is 4. * @cfg {number} [columns] Number of columns for languages. Default is 4.
* @cfg {Function} [languageDecorator] Callback function to be called when a language * @cfg {Function} [languageDecorator] Callback function to be called when a language
* link is prepared - for custom decoration. * link is prepared - for custom decoration.
* @cfg {Function|string[]} [quickList] The languages to display as suggestions for quick selection. * @cfg {Function|string[]} [quickList] The languages to display as suggestions for quick
* selection.
* @cfg {Function} [clickhandler] Callback when language is selected. * @cfg {Function} [clickhandler] Callback when language is selected.
* @cfg {jQuery|Function} [noResultsTemplate] * @cfg {jQuery|Function} [noResultsTemplate]
*/ */
@@ -127,7 +128,8 @@
* Override the default region grouping setting. * Override the default region grouping setting.
* This is to allow LanguageFilter to disable grouping when displaying search results. * This is to allow LanguageFilter to disable grouping when displaying search results.
* *
* @param {boolean|null} val True to force grouping, false to disable, null to undo override. * @param {boolean|null} val True to force grouping, false to disable, null
* to undo override.
*/ */
setGroupByRegionOverride: function ( val ) { setGroupByRegionOverride: function ( val ) {
this.groupByRegionOverride = val; this.groupByRegionOverride = val;
@@ -218,7 +220,7 @@
/** /**
* Adds given languages sorted into rows and columns into given element. * Adds given languages sorted into rows and columns into given element.
* @param {jQuery} $region Element to add language list. * @param {jQuery} $region Element to add language list.
* @param {array} languages List of language codes. * @param {Array} languages List of language codes.
* @param {number} itemsPerColumn How many languages fit in a column. * @param {number} itemsPerColumn How many languages fit in a column.
* @param {number} columnsPerRow How many columns fit in a row. * @param {number} columnsPerRow How many columns fit in a row.
*/ */
@@ -257,8 +259,8 @@
nextScript = $.uls.data.getScriptGroupOfLanguage( languages[ i + 1 ] ); nextScript = $.uls.data.getScriptGroupOfLanguage( languages[ i + 1 ] );
lastItem = languagesCount - i === 1; lastItem = languagesCount - i === 1;
// Force column break if script changes and column has more than one row already, // Force column break if script changes and column has more than one
// but only if grouping by region // row already, but only if grouping by region
if ( i === 0 || !this.isGroupingByRegionEnabled() ) { if ( i === 0 || !this.isGroupingByRegionEnabled() ) {
currentScript = $.uls.data.getScriptGroupOfLanguage( languages[ i ] ); currentScript = $.uls.data.getScriptGroupOfLanguage( languages[ i ] );
} else if ( currentScript !== nextScript && items.length > 1 ) { } else if ( currentScript !== nextScript && items.length > 1 ) {