Use eslint and stylelint, fix all errors (#282)

* Use eslint and stylelint, fix all errors

* Remove jshint, jsbeautify
* Use Object.keys directly since that is available in all major browsers
* Fixes for eslint, stylelint errors
* stylelint is not included in grunt test yet because jquery.uls.mobile.css
  has so many !important and need to figure out whether they are really needed
This commit is contained in:
Santhosh Thottingal
2018-01-04 19:28:35 +05:30
committed by Niklas Laxström
parent ddadf086c5
commit 2a77df6c41
19 changed files with 235 additions and 277 deletions

View File

@@ -1,7 +1,7 @@
.uls-trigger {
background: url('../images/icon-language.png') no-repeat left center;
background: url( ../images/icon-language.png ) no-repeat left center;
/* @embed */
background-image: linear-gradient(transparent, transparent), url('../images/icon-language.svg');
background-image: linear-gradient( transparent, transparent ), url( ../images/icon-language.svg );
padding-left: 30px;
}
@@ -12,10 +12,10 @@
margin-top: 1px;
background-color: #fff;
border: 1px solid #ccc;
border-color: rgba(0, 0, 0, 0.2);
-webkit-box-shadow: 0 5px 10px rgba(0, 0, 0, 0.2);
-moz-box-shadow: 0 5px 10px rgba(0, 0, 0, 0.2);
box-shadow: 0 5px 10px rgba(0, 0, 0, 0.2);
border-color: rgba( 0, 0, 0, 0.2 );
-webkit-box-shadow: 0 5px 10px rgba( 0, 0, 0, 0.2 );
-moz-box-shadow: 0 5px 10px rgba( 0, 0, 0, 0.2 );
box-shadow: 0 5px 10px rgba( 0, 0, 0, 0.2 );
-webkit-background-clip: padding-box;
-moz-background-clip: padding;
background-clip: padding-box;
@@ -65,9 +65,9 @@
}
.uls-search-label {
background: url('../images/search.png') no-repeat center center;
background: url( ../images/search.png ) no-repeat center center;
/* @embed */
background-image: linear-gradient(transparent, transparent), url('../images/search.svg');
background-image: linear-gradient( transparent, transparent ), url( ../images/search.svg );
background-size: 20px;
height: 32px;
width: 44px;
@@ -88,7 +88,7 @@
width: 100%;
/* For the custom clear (X) icon */
padding: 6px 25px 6px 0;
outline: none;
outline: 0;
border: 0;
display: block;
position: absolute;
@@ -110,9 +110,9 @@
}
.uls-languagefilter-clear {
background: url('../images/clear.png') no-repeat left center;
background: url( ../images/clear.png ) no-repeat left center;
/* @embed */
background-image: linear-gradient(transparent, transparent), url('../images/clear.svg');
background-image: linear-gradient( transparent, transparent ), url( ../images/clear.svg );
background-size: 15px;
cursor: pointer;
height: 15px;

View File

@@ -32,15 +32,18 @@
}
.grid .highlight {
background: #ffff99;
background: #ff9;
}
/* The Grid ---------------------- */
.grid .row {
width: 100%;
max-width: none;
min-width: 600px;
margin: 0 auto;
/* Nicolas Gallagher's micro clearfix */
*zoom: 1;
}
.grid .row .row {
@@ -50,30 +53,25 @@
margin: 0 -5px;
}
.grid .column,
.grid .columns {
float: left;
min-height: 1px;
padding: 0 5px;
position: relative;
}
.grid .row.collapse .column,
.grid .row.collapse .columns {
padding: 0;
}
.grid .row .row {
width: auto;
max-width: none;
min-width: 0;
margin: 0 -5px;
}
.grid .row .row.collapse {
margin: 0;
}
.grid .column, .grid .columns {
float: left;
min-height: 1px;
padding: 0 5px;
position: relative;
}
.grid .column.centered, .grid .columns.centered {
.grid .column.centered,
.grid .columns.centered {
float: none;
margin: 0 auto;
}
@@ -238,13 +236,9 @@
right: 83.333%;
}
/* Nicolas Gallagher's micro clearfix */
.grid .row {
*zoom: 1;
}
.grid .row:before, .grid .row:after {
content: "";
.grid .row:before,
.grid .row:after {
content: '';
display: table;
}

View File

@@ -36,6 +36,16 @@
margin: 0;
}
.uls-language-block > ul {
/*
* We don't want any visible bullets in this list. Not by default anyway.
* Using very unspecific selector here to allow other classes to override.
* Bug because overflow: hidden is incompatible with bullets, also render
* the bullets inside the list in case there should be any.
*/
list-style: none none;
}
/*
* Each block should have 16px padding on both sides. But because we already gave
* 16px for the whole menu, we need to remove it for first and last items the blocks.
@@ -53,17 +63,6 @@
padding-right: 0;
}
.uls-language-block > ul {
/*
* We don't want any visible bullets in this list. Not by default anyway.
* Using very unspecific selector here to allow other classes to override.
* Bug because overflow: hidden is incompatible with bullets, also render
* the bullets inside the list in case there should be any.
*/
list-style: none none;
}
.uls-language-block > ul > li {
cursor: pointer;
margin-left: 20px;

View File

@@ -1,4 +1,4 @@
@media only screen and (max-width: 767px) {
@media only screen and ( max-width: 767px ) {
.uls-mobile.uls-menu {
width: 95%;
@@ -40,7 +40,7 @@
float: none;
}
.uls-mobile [class*="column"] + [class*="column"]:last-child {
.uls-mobile [ class*='column' ] + [ class*='column' ]:last-child {
float: none;
}
@@ -48,7 +48,7 @@
.uls-mobile .uls-mobile .columns:before,
.uls-mobile .column:after,
.columns:after {
content: "";
content: '';
display: table;
}
@@ -197,11 +197,12 @@
}
/* Very large display targeting */
@media only screen and (min-width: 1441px) {
@media only screen and ( min-width: 1441px ) {
.uls-mobile .hide-for-small,
.uls-mobile .hide-for-medium,
.uls-mobile .hide-for-medium-down,
.hide-for-large, .show-for-large-up,
.hide-for-large,
.show-for-large-up,
.show-for-xlarge {
display: block !important;
}
@@ -217,7 +218,7 @@
}
/* Medium display targeting */
@media only screen and (max-width: 1279px) and (min-width: 768px) {
@media only screen and ( max-width: 1279px ) and ( min-width: 768px ) {
.uls-mobile .hide-for-small,
.uls-mobile .show-for-medium,
.uls-mobile .show-for-medium-down,
@@ -238,7 +239,7 @@
}
/* Small display targeting */
@media only screen and (max-width: 767px) {
@media only screen and ( max-width: 767px ) {
.uls-mobile .show-for-small,
.uls-mobile .hide-for-medium,
.uls-mobile .show-for-medium-down,
@@ -268,7 +269,7 @@
display: none !important;
}
@media screen and (orientation: landscape) {
@media screen and ( orientation: landscape ) {
.uls-mobile .show-for-landscape,
.uls-mobile .hide-for-portrait {
display: block !important;
@@ -279,7 +280,7 @@
}
}
@media screen and (orientation: portrait) {
@media screen and ( orientation: portrait ) {
.uls-mobile .show-for-portrait,
.uls-mobile .hide-for-landscape {
display: block !important;