bryce/jquery.uls
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Replace jQuery.proxy() with Function.prototype.bind()

Browse Source
This commit is contained in:
Pl217
2018-05-24 23:09:59 +02:00
committed by Niklas Laxström
parent 2c1b2dd1b8
commit 5dfca5fd8a
2 changed files with 10 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
src/jquery.uls.core.js
View File

@@ -220,7 +220,7 @@
columns: columnsOptions[ this.menuWidth ],
quickList: languagesCount > 12 ? this.options.quickList : [],
clickhandler: $.proxy( this.select, this ),
clickhandler: this.select.bind( this ),
showRegions: this.options.showRegions,
languageDecorator: this.options.languageDecorator,
noResultsTemplate: this.options.noResultsTemplate,
@@ -233,10 +233,10 @@
languages: this.languages,
ulsPurpose: this.options.ulsPurpose,
searchAPI: this.options.searchAPI,
onSelect: $.proxy( this.select, this )
onSelect: this.select.bind( this )
} );
this.$languageFilter.on( 'noresults.uls', $.proxy( lcd.noResults, lcd ) );
this.$languageFilter.on( 'noresults.uls', lcd.noResults.bind( lcd ) );
},
recreateLanguageFilter: function () {
@@ -253,7 +253,7 @@
*/
listen: function () {
// Register all event listeners to the ULS here.
this.$element.on( 'click', $.proxy( this.click, this ) );
this.$element.on( 'click', this.click.bind( this ) );
// Don't do anything if pressing on empty space in the ULS
this.$menu.on( 'click', function ( e ) {
@@ -261,13 +261,13 @@
} );
// Handle key press events on the menu
this.$menu.on( 'keydown', $.proxy( this.keypress, this ) );
this.$menu.on( 'keydown', this.keypress.bind( this ) );
this.createLanguageFilter();
this.$languageFilter.on( 'resultsfound.uls', $.proxy( this.success, this ) );
this.$languageFilter.on( 'resultsfound.uls', this.success.bind( this ) );
$( 'html' ).click( $.proxy( this.cancel, this ) );
$( 'html' ).click( this.cancel.bind( this ) );
$( window ).resize( $.fn.uls.debounce( this.resize.bind( this ), 250 ) );
},

6
src/jquery.uls.languagefilter.js
View File

@@ -58,14 +58,14 @@
},
listen: function () {
this.$element.on( 'keydown', $.proxy( this.keypress, this ) );
this.$element.on( 'keydown', this.keypress.bind( this ) );
this.$element.on(
'change textInput input',
$.fn.uls.debounce( $.proxy( this.onInputChange, this ), 300 )
$.fn.uls.debounce( this.onInputChange.bind( this ), 300 )
);
if ( this.$clear.length ) {
this.$clear.on( 'click', $.proxy( this.clear, this ) );
this.$clear.on( 'click', this.clear.bind( this ) );
}
this.toggleClear();