Fix ULS: Pointer style target should match click target

Reported at https://bugzilla.wikimedia.org/show_bug.cgi?id=41314
Also removed unwanted a tag

Change-Id: Id3eeabf76a12a8ec2c0d38b27b868216a2f785e0
This commit is contained in:
Santhosh Thottingal
2012-10-24 12:01:07 +05:30
parent 64435b1919
commit 761c845ad2
3 changed files with 7 additions and 9 deletions

View File

@@ -31,7 +31,7 @@
}, },
onSelect : function( language ) { onSelect : function( language ) {
var languageName = $.uls.data.getAutonym( language ); var languageName = $.uls.data.getAutonym( language );
$('a#pageLanguage').text( languageName ); $( '.uls-trigger' ).text( languageName );
i18n.locale = language; i18n.locale = language;
// For ULS // For ULS
i18n.load( '../i18n/' + language + '.json', language ); i18n.load( '../i18n/' + language + '.json', language );
@@ -49,7 +49,7 @@
<body> <body>
<div class="navbar navbar-fixed-top"> <div class="navbar navbar-fixed-top">
<span class="active uls-trigger"> <a id="pageLanguage" href="#">Select Language</a> </span> <span class="active uls-trigger">Select Language</span>
<h1 data-i18n="uls-example-title">Universal Language Selector</h1> <h1 data-i18n="uls-example-title">Universal Language Selector</h1>
<p> <p>
Demonstration of jquery plugin Demonstration of jquery plugin

View File

@@ -33,7 +33,7 @@
$( '.uls-trigger' ).uls( { $( '.uls-trigger' ).uls( {
onSelect : function( language ) { onSelect : function( language ) {
var languageName = $.uls.data.getAutonym( language ); var languageName = $.uls.data.getAutonym( language );
$('a#pageLanguage').text( languageName ); $( '.uls-trigger' ).text( languageName );
}, },
quickList: ['en', 'hi', 'he', 'ml', 'ta','fr'] //FIXME quickList: ['en', 'hi', 'he', 'ml', 'ta','fr'] //FIXME
} ); } );
@@ -43,7 +43,7 @@
<body> <body>
<div class="navbar navbar-fixed-top"> <div class="navbar navbar-fixed-top">
<span class="active uls-trigger"> <a id="pageLanguage" href="#">Select Language</a> </span> <span class="active uls-trigger">Select Language</span>
<h1>Universal Language Selector</h1> <h1>Universal Language Selector</h1>
<p> <p>
Demonstration of jquery plugin Demonstration of jquery plugin

View File

@@ -3,18 +3,16 @@ body {
padding-right: 10%; padding-right: 10%;
font-family: Arial, Helvetica, sans-serif; font-family: Arial, Helvetica, sans-serif;
} }
a {
text-decoration: none;
}
div.navbar { div.navbar {
background-color: #333; background-color: #333;
color: #FFFFFF; color: #FFFFFF;
padding: 20px; padding: 20px;
} }
span.uls-trigger { span.uls-trigger {
float: right; float: right;
} cursor: pointer;
span.uls-trigger a {
color: #FFFFFF; color: #FFFFFF;
font-weight: bold; font-weight: bold;
} }