bryce/jquery.uls
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Changed $( this ) into meaningful variables

Browse Source
This commit is contained in:
Amir E. Aharoni
2012-10-08 17:34:35 +02:00
parent f14073a21a
commit 77e62c99a5
1 changed files with 7 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
src/jquery.uls.lcd.js
View File

@@ -259,8 +259,9 @@
// The region section need to be in sync with the map filter. // The region section need to be in sync with the map filter.
lcd.$element.scroll( function () { lcd.$element.scroll( function () {
var scrollTop = $( this ).position().top, var $ulsLanguageList = $( this ),
scrollBottom = $( this ).height(); scrollTop = $ulsLanguageList.position().top,
scrollBottom = $ulsLanguageList.height();
if ( this.offsetHeight + this.scrollTop >= this.scrollHeight / 2 ) { if ( this.offsetHeight + this.scrollTop >= this.scrollHeight / 2 ) {
lcd.$element.trigger( 'scrollend' ); lcd.$element.trigger( 'scrollend' );
@@ -269,11 +270,12 @@
// The region section need to be in sync with the map filter. // The region section need to be in sync with the map filter.
var inviewRegion = 'WW'; var inviewRegion = 'WW';
lcd.$element.find( 'div.uls-lcd-region-section' ).each( function () { lcd.$element.find( 'div.uls-lcd-region-section' ).each( function () {
var top = $( this ).position().top, var $lcdRegionSection = $( this ),
height = $( this ).height(); top = $lcdRegionSection.position().top,
height = $lcdRegionSection.height();
if ( top < scrollTop && height > scrollBottom ) { if ( top < scrollTop && height > scrollBottom ) {
inviewRegion = $( this ).attr( 'id' ); inviewRegion = $lcdRegionSection.attr( 'id' );
return true; return true;
} }
} ); } );