From ce71c79c82e44333f04dbe514d0cdacdc12f23ce Mon Sep 17 00:00:00 2001 From: "Amir E. Aharoni" Date: Sun, 7 Oct 2012 17:11:46 +0200 Subject: [PATCH 01/15] (bug 39963) Add "get" to function names Kept the old names and gave them simple deprecation marking. --- src/jquery.uls.data.utils.js | 153 ++++++++++++++++++++++++++++++----- 1 file changed, 131 insertions(+), 22 deletions(-) diff --git a/src/jquery.uls.data.utils.js b/src/jquery.uls.data.utils.js index 4e31338..3cbdd76 100644 --- a/src/jquery.uls.data.utils.js +++ b/src/jquery.uls.data.utils.js @@ -20,38 +20,62 @@ ( function ( $ ) { "use strict"; + /** + * Log deprecated functions + */ + function deprecated( oldFunc, newFunc ) { + if ( window.console && window.console.log ) { + window.console.log( oldFunc + " is deprecated. Please use " + newFunc ); + } + } + /** * Returns the script of the language. * @param string language code * @return string */ - $.uls.data.script = function( language ) { + $.uls.data.getScript = function( language ) { return $.uls.data.languages[language][0]; }; + $.uls.data.script = function( language ) { // deprecated + deprecated( "script", "getScript" ); + return $.uls.data.getScript( language ); + }; + /** * Returns the regions in which a language is spoken. * @param string language code - * @return array of strings + * @return array|string 'UNKNOWN' */ - $.uls.data.regions = function( language ) { + $.uls.data.getRegions = function( language ) { return ( $.uls.data.languages[language] && $.uls.data.languages[language][1] ) || 'UNKNOWN'; }; + $.uls.data.regions = function( language ) { // deprecated + deprecated( "regions", "getRegions" ); + return $.uls.data.getRegions( language ); + }; + /** * Returns the autonym of the language. * @param string language code * @return string */ - $.uls.data.autonym = function( language ) { + $.uls.data.getAutonym = function( language ) { return ( $.uls.data.languages[language] && $.uls.data.languages[language][2] ) || language; }; + $.uls.data.autonym = function( language ) { // deprecated + deprecated( "autonym", "getAutonym" ); + return $.uls.data.getAutonym( language ); + }; + /** * Returns all language codes and corresponding autonyms * @return array */ - $.uls.data.autonyms = function() { + $.uls.data.getAutonyms = function() { var autonymsByCode = {}; for ( var language in $.uls.data.languages ) { @@ -61,11 +85,16 @@ return autonymsByCode; }; + $.uls.data.autonyms = function() { // deprecated + deprecated( "autonyms", "getAutonyms" ); + return $.uls.data.getAutonyms(); + }; + /** * Returns an array of all region codes. * @return array */ - $.uls.data.allRegions = function() { + $.uls.data.getAllRegions = function() { var allRegions = []; for( var region in $.uls.data.regiongroups ) { @@ -75,26 +104,36 @@ return allRegions; }; + $.uls.data.allRegions = function() { // deprecated + deprecated( "allRegions", "getAllRegions" ); + return $.uls.data.getAllRegions(); + }; + /** * Returns all languages written in script. * @param script string * @return array of strings (languages codes) */ - $.uls.data.languagesInScript = function( script ) { + $.uls.data.getLanguagesInScript = function( script ) { return $.uls.data.languagesInScripts( [ script ] ); }; + $.uls.data.languagesInScript = function( script ) { // deprecated + deprecated( "languagesInScript", "getLanguagesInScript" ); + return $.uls.data.getLanguagesInScript( script ); + }; + /** * Returns all languages written in the given scripts. * @param scripts array of strings * @return array of strings (languages codes) */ - $.uls.data.languagesInScripts = function( scripts ) { + $.uls.data.getLanguagesInScripts = function( scripts ) { var languagesInScripts = []; for ( var language in $.uls.data.languages ) { for ( var i = 0; i < scripts.length; i++ ) { - if ( scripts[i] === $.uls.data.script(language) ) { + if ( scripts[i] === $.uls.data.script( language ) ) { languagesInScripts.push( language ); break; } @@ -104,21 +143,31 @@ return languagesInScripts; }; + $.uls.data.languagesInScripts = function( scripts ) { // deprecated + deprecated( "languagesInScripts", "getLanguagesInScripts" ); + return $.uls.data.getLanguagesInScripts( scripts ); + }; + /** * Returns all languages in a given region. * @param region string * @return array of strings (languages codes) */ - $.uls.data.languagesInRegion = function( region ) { + $.uls.data.getLanguagesInRegion = function( region ) { return $.uls.data.languagesInRegions( [ region ] ); }; + $.uls.data.languagesInRegion = function( region ) { // deprecated + deprecated( "languagesInRegion", "getLanguagesInRegion" ); + return $.uls.data.getLanguagesInRegion( region ); + }; + /** * Returns all languages in given regions. * @param region array of strings. * @return array of strings (languages codes) */ - $.uls.data.languagesInRegions = function( regions ) { + $.uls.data.getLanguagesInRegions = function( regions ) { var languagesInRegions = []; for ( var language in $.uls.data.languages ) { @@ -133,22 +182,32 @@ return languagesInRegions; }; + $.uls.data.languagesInRegions = function( regions ) { // deprecated + deprecated( "languagesInRegions", "getLanguagesInRegions" ); + return $.uls.data.getLanguagesInRegions( regions ); + }; + /** * Returns all languages in a region group. * @param groupNum number. * @return array of strings (languages codes) */ - $.uls.data.languagesInRegionGroup = function( groupNum ) { + $.uls.data.getLanguagesInRegionGroup = function( groupNum ) { return $.uls.data.languagesInRegions( $.uls.data.regionsInGroup( groupNum ) ); }; + $.uls.data.languagesInRegionGroup = function( groupNum ) { // deprecated + deprecated( "languagesInRegionGroup", "getLanguagesInRegionGroup" ); + return $.uls.data.getLanguagesInRegionGroup( groupNum ); + }; + /** * Returns an associative array of languages in a region, * grouped by script. * @param string region code * @return associative array */ - $.uls.data.languagesByScriptInRegion = function( region ) { + $.uls.data.getLanguagesByScriptInRegion = function( region ) { var languagesByScriptInRegion = {}; for ( var language in $.uls.data.languages ) { @@ -164,31 +223,46 @@ return languagesByScriptInRegion; }; + $.uls.data.languagesByScriptInRegion = function( region ) { // deprecated + deprecated( "languagesByScriptInRegion", "getLanguagesByScriptInRegion" ); + return $.uls.data.getLanguagesByScriptInRegion( region ); + }; + /** * Returns an associative array of languages in a region, * grouped by script group. * @param string region code * @return associative array */ - $.uls.data.languagesByScriptGroupInRegion = function( region ) { + $.uls.data.getLanguagesByScriptGroupInRegion = function( region ) { return $.uls.data.languagesByScriptGroupInRegions( [ region ] ); }; + $.uls.data.languagesByScriptGroupInRegion = function( region ) { // deprecated + deprecated( "languagesByScriptGroupInRegion", "getLanguagesByScriptGroupInRegion" ); + return $.uls.data.getLanguagesByScriptGroupInRegion( region ); + }; + /** * Returns an associative array of all languages, * grouped by script group. * @return associative array */ - $.uls.data.allLanguagesByScriptGroup = function() { + $.uls.data.getAllLanguagesByScriptGroup = function() { return $.uls.data.languagesByScriptGroupInRegions( $.uls.data.allRegions() ); }; + $.uls.data.allLanguagesByScriptGroup = function() { // deprecated + deprecated( "allLanguagesByScriptGroup", "getAllLanguagesByScriptGroup" ); + return $.uls.data.getAllLanguagesByScriptGroup(); + }; + /** * Get the given list of languages grouped by script. * @param languages Array of language codes * @return {Object} Array of languages indexed by script codes */ - $.uls.data.languagesByScriptGroup = function( languages ) { + $.uls.data.getLanguagesByScriptGroup = function( languages ) { var languagesByScriptGroup = {}, scriptGroup, language, @@ -210,13 +284,18 @@ return languagesByScriptGroup; }; + $.uls.data.languagesByScriptGroup = function( languages ) { // deprecated + deprecated( "languagesByScriptGroup", "getLanguagesByScriptGroup" ); + return $.uls.data.getLanguagesByScriptGroup( languages ); + }; + /** * Returns an associative array of languages in several regions, * grouped by script group. * @param array of strings - region codes * @return associative array */ - $.uls.data.languagesByScriptGroupInRegions = function( regions ) { + $.uls.data.getLanguagesByScriptGroupInRegions = function( regions ) { var languagesByScriptGroupInRegions = {}; for ( var language in $.uls.data.languages ) { @@ -235,12 +314,17 @@ return languagesByScriptGroupInRegions; }; + $.uls.data.languagesByScriptGroupInRegions = function( regions ) { // deprecated + deprecated( "languagesByScriptGroupInRegions", "getLanguagesByScriptGroupInRegions" ); + return $.uls.data.getLanguagesByScriptGroupInRegions( regions ); + }; + /** * Returns an array of languages grouped by region group, * region, script group and script. * @return associative array */ - $.uls.data.allLanguagesByRegionAndScript = function() { + $.uls.data.getAllLanguagesByRegionAndScript = function() { var allLanguagesByRegionAndScript = {}, region, regionGroup; @@ -277,12 +361,17 @@ return allLanguagesByRegionAndScript; }; + $.uls.data.allLanguagesByRegionAndScript = function() { // deprecated + deprecated( "allLanguagesByRegionAndScript", "getAllLanguagesByRegionAndScript" ); + return $.uls.data.getAllLanguagesByRegionAndScript(); + }; + /** * Returns all regions in a region group. * @param number groupNum * @return array of strings */ - $.uls.data.regionsInGroup = function( groupNum ) { + $.uls.data.getRegionsInGroup = function( groupNum ) { var regionsInGroup = []; for ( var region in $.uls.data.regiongroups ) { @@ -294,13 +383,18 @@ return regionsInGroup; }; + $.uls.data.regionsInGroup = function( groupNum ) { // deprecated + deprecated( "regionsInGroup", "getRegionsInGroup" ); + return $.uls.data.getRegionsInGroup( groupNum ); + }; + /** * Returns the script group of a script or 'Other' if it doesn't * belong to any group. * @param string script code * @return string script group name */ - $.uls.data.groupOfScript = function( script ) { + $.uls.data.getGroupOfScript = function( script ) { for ( var group in $.uls.data.scriptgroups ) { if ( $.inArray( script, $.uls.data.scriptgroups[group] ) !== -1 ) { return group; @@ -310,15 +404,25 @@ return 'Other'; }; + $.uls.data.groupOfScript = function( script ) { // deprecated + deprecated( "groupOfScript", "getGroupOfScript" ); + return $.uls.data.getGroupOfScript( script ); + }; + /** * Returns the script group of a language. * @param string language code * @return string script group name */ - $.uls.data.scriptGroupOfLanguage = function( language ) { + $.uls.data.getScriptGroupOfLanguage = function( language ) { return $.uls.data.groupOfScript( $.uls.data.script( language ) ); }; + $.uls.data.scriptGroupOfLanguage = function( language ) { // deprecated + deprecated( "scriptGroupOfLanguage", "getScriptGroupOfLanguage" ); + return $.uls.data.getScriptGroupOfLanguage( language ); + }; + /** * A callback for sorting languages by autonym. * Can be used as an argument to a sort function. @@ -353,7 +457,12 @@ * @param string Territory code * @return list of language codes */ - $.uls.data.languagesInTerritory = function( territory ) { + $.uls.data.getLanguagesInTerritory = function( territory ) { return $.uls.data.territories[territory]; }; + + $.uls.data.languagesInTerritory = function( territory ) { // deprecated + deprecated( "languagesInTerritory", "getLanguagesInTerritory" ); + return $.uls.data.getLanguagesInTerritory( territory ); + }; } ( jQuery ) ); From 3847838da75ab7692a92415f46c0145921ab6b2d Mon Sep 17 00:00:00 2001 From: "Amir E. Aharoni" Date: Sun, 7 Oct 2012 20:11:53 +0200 Subject: [PATCH 02/15] Replace .script with .getScript --- src/jquery.uls.data.utils.js | 10 +++++----- src/jquery.uls.languagefilter.js | 2 +- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/src/jquery.uls.data.utils.js b/src/jquery.uls.data.utils.js index 3cbdd76..1915591 100644 --- a/src/jquery.uls.data.utils.js +++ b/src/jquery.uls.data.utils.js @@ -133,7 +133,7 @@ for ( var language in $.uls.data.languages ) { for ( var i = 0; i < scripts.length; i++ ) { - if ( scripts[i] === $.uls.data.script( language ) ) { + if ( scripts[i] === $.uls.data.getScript( language ) ) { languagesInScripts.push( language ); break; } @@ -212,7 +212,7 @@ for ( var language in $.uls.data.languages ) { if ( $.inArray( region, $.uls.data.regions( language ) ) !== -1 ) { - var script = $.uls.data.script( language ); + var script = $.uls.data.getScript( language ); if ( languagesByScriptInRegion[script] === undefined ) { languagesByScriptInRegion[script] = []; } @@ -338,7 +338,7 @@ } for ( var language in $.uls.data.languages ) { - var script = $.uls.data.script( language ); + var script = $.uls.data.getScript( language ); var scriptGroup = $.uls.data.groupOfScript( script ); var regions = $.uls.data.regions( language ); @@ -415,7 +415,7 @@ * @return string script group name */ $.uls.data.getScriptGroupOfLanguage = function( language ) { - return $.uls.data.groupOfScript( $.uls.data.script( language ) ); + return $.uls.data.groupOfScript( $.uls.data.getScript( language ) ); }; $.uls.data.scriptGroupOfLanguage = function( language ) { // deprecated @@ -440,7 +440,7 @@ * @return boolean */ $.uls.data.isRtl = function( language ) { - return $.inArray( $.uls.data.script( language ), $.uls.data.rtlscripts ) !== -1; + return $.inArray( $.uls.data.getScript( language ), $.uls.data.rtlscripts ) !== -1; }; /** diff --git a/src/jquery.uls.languagefilter.js b/src/jquery.uls.languagefilter.js index 23c05e2..3acfe15 100644 --- a/src/jquery.uls.languagefilter.js +++ b/src/jquery.uls.languagefilter.js @@ -249,7 +249,7 @@ return matcher.test( languageName ) || matcher.test( $.uls.data.autonym( langCode ) ) || matcher.test( langCode ) || - matcher.test( $.uls.data.script( langCode ) ); + matcher.test( $.uls.data.getScript( langCode ) ); } }; From 52c2cac2a979f169572d6e6f9e1124a8e972d4af Mon Sep 17 00:00:00 2001 From: "Amir E. Aharoni" Date: Sun, 7 Oct 2012 21:47:24 +0200 Subject: [PATCH 03/15] .regions -> .getRegions --- src/jquery.uls.data.utils.js | 8 ++++---- src/jquery.uls.lcd.js | 2 +- src/jquery.uls.regionfilter.js | 2 +- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/src/jquery.uls.data.utils.js b/src/jquery.uls.data.utils.js index 1915591..95766f5 100644 --- a/src/jquery.uls.data.utils.js +++ b/src/jquery.uls.data.utils.js @@ -172,7 +172,7 @@ for ( var language in $.uls.data.languages ) { for ( var i = 0; i < regions.length; i++ ) { - if ( $.inArray( regions[i], $.uls.data.regions( language ) ) !== -1 ) { + if ( $.inArray( regions[i], $.uls.data.getRegions( language ) ) !== -1 ) { languagesInRegions.push( language ); break; } @@ -211,7 +211,7 @@ var languagesByScriptInRegion = {}; for ( var language in $.uls.data.languages ) { - if ( $.inArray( region, $.uls.data.regions( language ) ) !== -1 ) { + if ( $.inArray( region, $.uls.data.getRegions( language ) ) !== -1 ) { var script = $.uls.data.getScript( language ); if ( languagesByScriptInRegion[script] === undefined ) { languagesByScriptInRegion[script] = []; @@ -300,7 +300,7 @@ for ( var language in $.uls.data.languages ) { for ( var i = 0; i < regions.length; i++ ) { - if ( $.inArray( regions[i], $.uls.data.regions( language ) ) !== -1 ) { + if ( $.inArray( regions[i], $.uls.data.getRegions( language ) ) !== -1 ) { var scriptGroup = $.uls.data.scriptGroupOfLanguage( language ); if ( languagesByScriptGroupInRegions[scriptGroup] === undefined ) { languagesByScriptGroupInRegions[scriptGroup] = []; @@ -340,7 +340,7 @@ for ( var language in $.uls.data.languages ) { var script = $.uls.data.getScript( language ); var scriptGroup = $.uls.data.groupOfScript( script ); - var regions = $.uls.data.regions( language ); + var regions = $.uls.data.getRegions( language ); for ( var regionNum = 0; regionNum < regions.length; regionNum++ ) { region = regions[regionNum]; diff --git a/src/jquery.uls.lcd.js b/src/jquery.uls.lcd.js index 4273898..1fbcd26 100644 --- a/src/jquery.uls.lcd.js +++ b/src/jquery.uls.lcd.js @@ -80,7 +80,7 @@ if ( region ) { regions.push( region ); } else { - regions = $.uls.data.regions( langCode ); + regions = $.uls.data.getRegions( langCode ); } // World wide languages need not be repeated in all regions. diff --git a/src/jquery.uls.regionfilter.js b/src/jquery.uls.regionfilter.js index e3e3c0c..cb28ab1 100644 --- a/src/jquery.uls.regionfilter.js +++ b/src/jquery.uls.regionfilter.js @@ -51,7 +51,7 @@ }, test: function( langCode ) { - var langRegions = $.uls.data.regions( langCode ), + var langRegions = $.uls.data.getRegions( langCode ), region; for ( var i = 0; i < this.regions.length; i++ ) { From b52df71d8c5747879b16c8f56df3600b1efd9bf1 Mon Sep 17 00:00:00 2001 From: "Amir E. Aharoni" Date: Sun, 7 Oct 2012 21:50:05 +0200 Subject: [PATCH 04/15] .autonym -> .getAutonym --- examples/index-i18n.html | 2 +- examples/index.html | 2 +- src/jquery.uls.data.utils.js | 6 +++--- src/jquery.uls.languagefilter.js | 4 ++-- src/jquery.uls.lcd.js | 4 ++-- 5 files changed, 9 insertions(+), 9 deletions(-) diff --git a/examples/index-i18n.html b/examples/index-i18n.html index ed02775..0bea514 100644 --- a/examples/index-i18n.html +++ b/examples/index-i18n.html @@ -24,7 +24,7 @@ var i18n = $.i18n( ); $( '.uls-trigger' ).uls( { onSelect : function( language ) { - var languageName = $.uls.data.autonym( language ); + var languageName = $.uls.data.getAutonym( language ); $('a#pageLanguage').text( languageName ); i18n.locale = language; // For ULS diff --git a/examples/index.html b/examples/index.html index e3417ae..213588e 100644 --- a/examples/index.html +++ b/examples/index.html @@ -32,7 +32,7 @@ $( document ).ready( function() { $( '.uls-trigger' ).uls( { onSelect : function( language ) { - var languageName = $.uls.data.autonym( language ); + var languageName = $.uls.data.getAutonym( language ); $('a#pageLanguage').text( languageName ); }, quickList: ['en', 'hi', 'he', 'ml', 'ta','fr'] //FIXME diff --git a/src/jquery.uls.data.utils.js b/src/jquery.uls.data.utils.js index 95766f5..3e9263f 100644 --- a/src/jquery.uls.data.utils.js +++ b/src/jquery.uls.data.utils.js @@ -79,7 +79,7 @@ var autonymsByCode = {}; for ( var language in $.uls.data.languages ) { - autonymsByCode[language] = $.uls.data.autonym( language ); + autonymsByCode[language] = $.uls.data.getAutonym( language ); } return autonymsByCode; @@ -429,8 +429,8 @@ * @param two language codes */ $.uls.data.sortByAutonym = function( a, b ) { - var autonymA = $.uls.data.autonym( a ) || a, - autonymB = $.uls.data.autonym( b ) || b; + var autonymA = $.uls.data.getAutonym( a ) || a, + autonymB = $.uls.data.getAutonym( b ) || b; return ( autonymA.toLowerCase() < autonymB.toLowerCase() ) ? -1 : 1; }; diff --git a/src/jquery.uls.languagefilter.js b/src/jquery.uls.languagefilter.js index 3acfe15..9c1d4d3 100644 --- a/src/jquery.uls.languagefilter.js +++ b/src/jquery.uls.languagefilter.js @@ -208,7 +208,7 @@ suggestion = userInput + languageName.substring( userInput.length, languageName.length ); if ( suggestion.toLowerCase() !== languageName.toLowerCase() ) { // see if it was autonym match - autonym = $.uls.data.autonym( langCode ) || ''; + autonym = $.uls.data.getAutonym( langCode ) || ''; suggestion = userInput + autonym.substring( userInput.length, autonym.length ); if ( suggestion !== autonym ) { // Give up. It may be iso/script code match. @@ -247,7 +247,7 @@ var matcher = new RegExp( "^" + this.escapeRegex( searchTerm ), 'i' ), languageName = this.options.languages[langCode]; return matcher.test( languageName ) || - matcher.test( $.uls.data.autonym( langCode ) ) || + matcher.test( $.uls.data.getAutonym( langCode ) ) || matcher.test( langCode ) || matcher.test( $.uls.data.getScript( langCode ) ); } diff --git a/src/jquery.uls.lcd.js b/src/jquery.uls.lcd.js index 1fbcd26..b22aa65 100644 --- a/src/jquery.uls.lcd.js +++ b/src/jquery.uls.lcd.js @@ -74,7 +74,7 @@ addToRegion: function( langCode, region ) { var that = this; var language = that.options.languages[langCode], - langName = $.uls.data.autonym( langCode ) || language || langCode, + langName = $.uls.data.getAutonym( langCode ) || language || langCode, regions = []; if ( region ) { @@ -206,7 +206,7 @@ var $column = this.getColumn( 'quick', i % 4 === 0 ); var langCode = quickList[i]; var language = this.options.languages[langCode]; - var langName = $.uls.data.autonym( langCode ) || language || langCode; + var langName = $.uls.data.getAutonym( langCode ) || language || langCode; var $li = $( '
  • ' ) .data( 'code', langCode ) .attr( { From 4b8820ddacfed037d56723e354bb328af39fe266 Mon Sep 17 00:00:00 2001 From: "Amir E. Aharoni" Date: Sun, 7 Oct 2012 21:50:56 +0200 Subject: [PATCH 05/15] .autonyms -> .getAutonyms --- src/jquery.uls.core.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/jquery.uls.core.js b/src/jquery.uls.core.js index c5c9ac6..f86d1fd 100644 --- a/src/jquery.uls.core.js +++ b/src/jquery.uls.core.js @@ -317,7 +317,7 @@ menu: template, onSelect: null, // Callback function to be called when a language is selected searchAPI: null, // Language search API - languages: $.uls.data.autonyms(), // Languages to be used for ULS, default is all languages + languages: $.uls.data.getAutonyms(), // Languages to be used for ULS, default is all languages quickList: null // Array of language codes of function that returns such }; From 2f5bafda3d6356689faec103875376d1d02f81f1 Mon Sep 17 00:00:00 2001 From: "Amir E. Aharoni" Date: Sun, 7 Oct 2012 22:00:58 +0200 Subject: [PATCH 06/15] .allRegions -> .getAllRegions --- src/jquery.uls.data.utils.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/jquery.uls.data.utils.js b/src/jquery.uls.data.utils.js index 3e9263f..0d126f0 100644 --- a/src/jquery.uls.data.utils.js +++ b/src/jquery.uls.data.utils.js @@ -249,7 +249,7 @@ * @return associative array */ $.uls.data.getAllLanguagesByScriptGroup = function() { - return $.uls.data.languagesByScriptGroupInRegions( $.uls.data.allRegions() ); + return $.uls.data.languagesByScriptGroupInRegions( $.uls.data.getAllRegions() ); }; $.uls.data.allLanguagesByScriptGroup = function() { // deprecated From 779067bd661ed4eade95492f4de600a4370d0e20 Mon Sep 17 00:00:00 2001 From: "Amir E. Aharoni" Date: Sun, 7 Oct 2012 22:09:52 +0200 Subject: [PATCH 07/15] .languagesByScript* -> .getLanguagesByScript* --- src/jquery.uls.data.utils.js | 8 ++++---- src/jquery.uls.languagefilter.js | 2 +- src/jquery.uls.regionfilter.js | 2 +- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/src/jquery.uls.data.utils.js b/src/jquery.uls.data.utils.js index 0d126f0..2aff251 100644 --- a/src/jquery.uls.data.utils.js +++ b/src/jquery.uls.data.utils.js @@ -154,7 +154,7 @@ * @return array of strings (languages codes) */ $.uls.data.getLanguagesInRegion = function( region ) { - return $.uls.data.languagesInRegions( [ region ] ); + return $.uls.data.getLanguagesInRegions( [ region ] ); }; $.uls.data.languagesInRegion = function( region ) { // deprecated @@ -193,7 +193,7 @@ * @return array of strings (languages codes) */ $.uls.data.getLanguagesInRegionGroup = function( groupNum ) { - return $.uls.data.languagesInRegions( $.uls.data.regionsInGroup( groupNum ) ); + return $.uls.data.getLanguagesInRegions( $.uls.data.regionsInGroup( groupNum ) ); }; $.uls.data.languagesInRegionGroup = function( groupNum ) { // deprecated @@ -235,7 +235,7 @@ * @return associative array */ $.uls.data.getLanguagesByScriptGroupInRegion = function( region ) { - return $.uls.data.languagesByScriptGroupInRegions( [ region ] ); + return $.uls.data.getLanguagesByScriptGroupInRegions( [ region ] ); }; $.uls.data.languagesByScriptGroupInRegion = function( region ) { // deprecated @@ -249,7 +249,7 @@ * @return associative array */ $.uls.data.getAllLanguagesByScriptGroup = function() { - return $.uls.data.languagesByScriptGroupInRegions( $.uls.data.getAllRegions() ); + return $.uls.data.getLanguagesByScriptGroupInRegions( $.uls.data.getAllRegions() ); }; $.uls.data.allLanguagesByScriptGroup = function() { // deprecated diff --git a/src/jquery.uls.languagefilter.js b/src/jquery.uls.languagefilter.js index 9c1d4d3..293cd1f 100644 --- a/src/jquery.uls.languagefilter.js +++ b/src/jquery.uls.languagefilter.js @@ -135,7 +135,7 @@ search: function() { var query = $.trim( this.$element.val() ), - languages = $.uls.data.languagesByScriptGroup( this.options.languages ), + languages = $.uls.data.getLanguagesByScriptGroup( this.options.languages ), scriptGroup, langNum, langCode; this.resultCount = 0; for ( scriptGroup in languages ) { diff --git a/src/jquery.uls.regionfilter.js b/src/jquery.uls.regionfilter.js index cb28ab1..6f65bff 100644 --- a/src/jquery.uls.regionfilter.js +++ b/src/jquery.uls.regionfilter.js @@ -74,7 +74,7 @@ } else { this.cache = {}; // Get the languages grouped by script group - var languagesByScriptGroup = $.uls.data.languagesByScriptGroup( this.options.languages ); + var languagesByScriptGroup = $.uls.data.getLanguagesByScriptGroup( this.options.languages ); for ( var scriptGroup in languagesByScriptGroup ) { // Get the languages for the script group var languages = languagesByScriptGroup[scriptGroup]; From c007ba34272ae1f9c77ce3980416e79ea2b48c9b Mon Sep 17 00:00:00 2001 From: "Amir E. Aharoni" Date: Sun, 7 Oct 2012 17:11:46 +0200 Subject: [PATCH 08/15] (bug 39963) Add "get" to function names Kept the old names and gave them simple deprecation marking. --- src/jquery.uls.data.utils.js | 153 ++++++++++++++++++++++++++++++----- 1 file changed, 131 insertions(+), 22 deletions(-) diff --git a/src/jquery.uls.data.utils.js b/src/jquery.uls.data.utils.js index 4e31338..3cbdd76 100644 --- a/src/jquery.uls.data.utils.js +++ b/src/jquery.uls.data.utils.js @@ -20,38 +20,62 @@ ( function ( $ ) { "use strict"; + /** + * Log deprecated functions + */ + function deprecated( oldFunc, newFunc ) { + if ( window.console && window.console.log ) { + window.console.log( oldFunc + " is deprecated. Please use " + newFunc ); + } + } + /** * Returns the script of the language. * @param string language code * @return string */ - $.uls.data.script = function( language ) { + $.uls.data.getScript = function( language ) { return $.uls.data.languages[language][0]; }; + $.uls.data.script = function( language ) { // deprecated + deprecated( "script", "getScript" ); + return $.uls.data.getScript( language ); + }; + /** * Returns the regions in which a language is spoken. * @param string language code - * @return array of strings + * @return array|string 'UNKNOWN' */ - $.uls.data.regions = function( language ) { + $.uls.data.getRegions = function( language ) { return ( $.uls.data.languages[language] && $.uls.data.languages[language][1] ) || 'UNKNOWN'; }; + $.uls.data.regions = function( language ) { // deprecated + deprecated( "regions", "getRegions" ); + return $.uls.data.getRegions( language ); + }; + /** * Returns the autonym of the language. * @param string language code * @return string */ - $.uls.data.autonym = function( language ) { + $.uls.data.getAutonym = function( language ) { return ( $.uls.data.languages[language] && $.uls.data.languages[language][2] ) || language; }; + $.uls.data.autonym = function( language ) { // deprecated + deprecated( "autonym", "getAutonym" ); + return $.uls.data.getAutonym( language ); + }; + /** * Returns all language codes and corresponding autonyms * @return array */ - $.uls.data.autonyms = function() { + $.uls.data.getAutonyms = function() { var autonymsByCode = {}; for ( var language in $.uls.data.languages ) { @@ -61,11 +85,16 @@ return autonymsByCode; }; + $.uls.data.autonyms = function() { // deprecated + deprecated( "autonyms", "getAutonyms" ); + return $.uls.data.getAutonyms(); + }; + /** * Returns an array of all region codes. * @return array */ - $.uls.data.allRegions = function() { + $.uls.data.getAllRegions = function() { var allRegions = []; for( var region in $.uls.data.regiongroups ) { @@ -75,26 +104,36 @@ return allRegions; }; + $.uls.data.allRegions = function() { // deprecated + deprecated( "allRegions", "getAllRegions" ); + return $.uls.data.getAllRegions(); + }; + /** * Returns all languages written in script. * @param script string * @return array of strings (languages codes) */ - $.uls.data.languagesInScript = function( script ) { + $.uls.data.getLanguagesInScript = function( script ) { return $.uls.data.languagesInScripts( [ script ] ); }; + $.uls.data.languagesInScript = function( script ) { // deprecated + deprecated( "languagesInScript", "getLanguagesInScript" ); + return $.uls.data.getLanguagesInScript( script ); + }; + /** * Returns all languages written in the given scripts. * @param scripts array of strings * @return array of strings (languages codes) */ - $.uls.data.languagesInScripts = function( scripts ) { + $.uls.data.getLanguagesInScripts = function( scripts ) { var languagesInScripts = []; for ( var language in $.uls.data.languages ) { for ( var i = 0; i < scripts.length; i++ ) { - if ( scripts[i] === $.uls.data.script(language) ) { + if ( scripts[i] === $.uls.data.script( language ) ) { languagesInScripts.push( language ); break; } @@ -104,21 +143,31 @@ return languagesInScripts; }; + $.uls.data.languagesInScripts = function( scripts ) { // deprecated + deprecated( "languagesInScripts", "getLanguagesInScripts" ); + return $.uls.data.getLanguagesInScripts( scripts ); + }; + /** * Returns all languages in a given region. * @param region string * @return array of strings (languages codes) */ - $.uls.data.languagesInRegion = function( region ) { + $.uls.data.getLanguagesInRegion = function( region ) { return $.uls.data.languagesInRegions( [ region ] ); }; + $.uls.data.languagesInRegion = function( region ) { // deprecated + deprecated( "languagesInRegion", "getLanguagesInRegion" ); + return $.uls.data.getLanguagesInRegion( region ); + }; + /** * Returns all languages in given regions. * @param region array of strings. * @return array of strings (languages codes) */ - $.uls.data.languagesInRegions = function( regions ) { + $.uls.data.getLanguagesInRegions = function( regions ) { var languagesInRegions = []; for ( var language in $.uls.data.languages ) { @@ -133,22 +182,32 @@ return languagesInRegions; }; + $.uls.data.languagesInRegions = function( regions ) { // deprecated + deprecated( "languagesInRegions", "getLanguagesInRegions" ); + return $.uls.data.getLanguagesInRegions( regions ); + }; + /** * Returns all languages in a region group. * @param groupNum number. * @return array of strings (languages codes) */ - $.uls.data.languagesInRegionGroup = function( groupNum ) { + $.uls.data.getLanguagesInRegionGroup = function( groupNum ) { return $.uls.data.languagesInRegions( $.uls.data.regionsInGroup( groupNum ) ); }; + $.uls.data.languagesInRegionGroup = function( groupNum ) { // deprecated + deprecated( "languagesInRegionGroup", "getLanguagesInRegionGroup" ); + return $.uls.data.getLanguagesInRegionGroup( groupNum ); + }; + /** * Returns an associative array of languages in a region, * grouped by script. * @param string region code * @return associative array */ - $.uls.data.languagesByScriptInRegion = function( region ) { + $.uls.data.getLanguagesByScriptInRegion = function( region ) { var languagesByScriptInRegion = {}; for ( var language in $.uls.data.languages ) { @@ -164,31 +223,46 @@ return languagesByScriptInRegion; }; + $.uls.data.languagesByScriptInRegion = function( region ) { // deprecated + deprecated( "languagesByScriptInRegion", "getLanguagesByScriptInRegion" ); + return $.uls.data.getLanguagesByScriptInRegion( region ); + }; + /** * Returns an associative array of languages in a region, * grouped by script group. * @param string region code * @return associative array */ - $.uls.data.languagesByScriptGroupInRegion = function( region ) { + $.uls.data.getLanguagesByScriptGroupInRegion = function( region ) { return $.uls.data.languagesByScriptGroupInRegions( [ region ] ); }; + $.uls.data.languagesByScriptGroupInRegion = function( region ) { // deprecated + deprecated( "languagesByScriptGroupInRegion", "getLanguagesByScriptGroupInRegion" ); + return $.uls.data.getLanguagesByScriptGroupInRegion( region ); + }; + /** * Returns an associative array of all languages, * grouped by script group. * @return associative array */ - $.uls.data.allLanguagesByScriptGroup = function() { + $.uls.data.getAllLanguagesByScriptGroup = function() { return $.uls.data.languagesByScriptGroupInRegions( $.uls.data.allRegions() ); }; + $.uls.data.allLanguagesByScriptGroup = function() { // deprecated + deprecated( "allLanguagesByScriptGroup", "getAllLanguagesByScriptGroup" ); + return $.uls.data.getAllLanguagesByScriptGroup(); + }; + /** * Get the given list of languages grouped by script. * @param languages Array of language codes * @return {Object} Array of languages indexed by script codes */ - $.uls.data.languagesByScriptGroup = function( languages ) { + $.uls.data.getLanguagesByScriptGroup = function( languages ) { var languagesByScriptGroup = {}, scriptGroup, language, @@ -210,13 +284,18 @@ return languagesByScriptGroup; }; + $.uls.data.languagesByScriptGroup = function( languages ) { // deprecated + deprecated( "languagesByScriptGroup", "getLanguagesByScriptGroup" ); + return $.uls.data.getLanguagesByScriptGroup( languages ); + }; + /** * Returns an associative array of languages in several regions, * grouped by script group. * @param array of strings - region codes * @return associative array */ - $.uls.data.languagesByScriptGroupInRegions = function( regions ) { + $.uls.data.getLanguagesByScriptGroupInRegions = function( regions ) { var languagesByScriptGroupInRegions = {}; for ( var language in $.uls.data.languages ) { @@ -235,12 +314,17 @@ return languagesByScriptGroupInRegions; }; + $.uls.data.languagesByScriptGroupInRegions = function( regions ) { // deprecated + deprecated( "languagesByScriptGroupInRegions", "getLanguagesByScriptGroupInRegions" ); + return $.uls.data.getLanguagesByScriptGroupInRegions( regions ); + }; + /** * Returns an array of languages grouped by region group, * region, script group and script. * @return associative array */ - $.uls.data.allLanguagesByRegionAndScript = function() { + $.uls.data.getAllLanguagesByRegionAndScript = function() { var allLanguagesByRegionAndScript = {}, region, regionGroup; @@ -277,12 +361,17 @@ return allLanguagesByRegionAndScript; }; + $.uls.data.allLanguagesByRegionAndScript = function() { // deprecated + deprecated( "allLanguagesByRegionAndScript", "getAllLanguagesByRegionAndScript" ); + return $.uls.data.getAllLanguagesByRegionAndScript(); + }; + /** * Returns all regions in a region group. * @param number groupNum * @return array of strings */ - $.uls.data.regionsInGroup = function( groupNum ) { + $.uls.data.getRegionsInGroup = function( groupNum ) { var regionsInGroup = []; for ( var region in $.uls.data.regiongroups ) { @@ -294,13 +383,18 @@ return regionsInGroup; }; + $.uls.data.regionsInGroup = function( groupNum ) { // deprecated + deprecated( "regionsInGroup", "getRegionsInGroup" ); + return $.uls.data.getRegionsInGroup( groupNum ); + }; + /** * Returns the script group of a script or 'Other' if it doesn't * belong to any group. * @param string script code * @return string script group name */ - $.uls.data.groupOfScript = function( script ) { + $.uls.data.getGroupOfScript = function( script ) { for ( var group in $.uls.data.scriptgroups ) { if ( $.inArray( script, $.uls.data.scriptgroups[group] ) !== -1 ) { return group; @@ -310,15 +404,25 @@ return 'Other'; }; + $.uls.data.groupOfScript = function( script ) { // deprecated + deprecated( "groupOfScript", "getGroupOfScript" ); + return $.uls.data.getGroupOfScript( script ); + }; + /** * Returns the script group of a language. * @param string language code * @return string script group name */ - $.uls.data.scriptGroupOfLanguage = function( language ) { + $.uls.data.getScriptGroupOfLanguage = function( language ) { return $.uls.data.groupOfScript( $.uls.data.script( language ) ); }; + $.uls.data.scriptGroupOfLanguage = function( language ) { // deprecated + deprecated( "scriptGroupOfLanguage", "getScriptGroupOfLanguage" ); + return $.uls.data.getScriptGroupOfLanguage( language ); + }; + /** * A callback for sorting languages by autonym. * Can be used as an argument to a sort function. @@ -353,7 +457,12 @@ * @param string Territory code * @return list of language codes */ - $.uls.data.languagesInTerritory = function( territory ) { + $.uls.data.getLanguagesInTerritory = function( territory ) { return $.uls.data.territories[territory]; }; + + $.uls.data.languagesInTerritory = function( territory ) { // deprecated + deprecated( "languagesInTerritory", "getLanguagesInTerritory" ); + return $.uls.data.getLanguagesInTerritory( territory ); + }; } ( jQuery ) ); From 17f525f510e3fbe2044969ad830ff8597b07cb79 Mon Sep 17 00:00:00 2001 From: "Amir E. Aharoni" Date: Sun, 7 Oct 2012 20:11:53 +0200 Subject: [PATCH 09/15] Replace .script with .getScript --- src/jquery.uls.data.utils.js | 10 +++++----- src/jquery.uls.languagefilter.js | 2 +- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/src/jquery.uls.data.utils.js b/src/jquery.uls.data.utils.js index 3cbdd76..1915591 100644 --- a/src/jquery.uls.data.utils.js +++ b/src/jquery.uls.data.utils.js @@ -133,7 +133,7 @@ for ( var language in $.uls.data.languages ) { for ( var i = 0; i < scripts.length; i++ ) { - if ( scripts[i] === $.uls.data.script( language ) ) { + if ( scripts[i] === $.uls.data.getScript( language ) ) { languagesInScripts.push( language ); break; } @@ -212,7 +212,7 @@ for ( var language in $.uls.data.languages ) { if ( $.inArray( region, $.uls.data.regions( language ) ) !== -1 ) { - var script = $.uls.data.script( language ); + var script = $.uls.data.getScript( language ); if ( languagesByScriptInRegion[script] === undefined ) { languagesByScriptInRegion[script] = []; } @@ -338,7 +338,7 @@ } for ( var language in $.uls.data.languages ) { - var script = $.uls.data.script( language ); + var script = $.uls.data.getScript( language ); var scriptGroup = $.uls.data.groupOfScript( script ); var regions = $.uls.data.regions( language ); @@ -415,7 +415,7 @@ * @return string script group name */ $.uls.data.getScriptGroupOfLanguage = function( language ) { - return $.uls.data.groupOfScript( $.uls.data.script( language ) ); + return $.uls.data.groupOfScript( $.uls.data.getScript( language ) ); }; $.uls.data.scriptGroupOfLanguage = function( language ) { // deprecated @@ -440,7 +440,7 @@ * @return boolean */ $.uls.data.isRtl = function( language ) { - return $.inArray( $.uls.data.script( language ), $.uls.data.rtlscripts ) !== -1; + return $.inArray( $.uls.data.getScript( language ), $.uls.data.rtlscripts ) !== -1; }; /** diff --git a/src/jquery.uls.languagefilter.js b/src/jquery.uls.languagefilter.js index 23c05e2..3acfe15 100644 --- a/src/jquery.uls.languagefilter.js +++ b/src/jquery.uls.languagefilter.js @@ -249,7 +249,7 @@ return matcher.test( languageName ) || matcher.test( $.uls.data.autonym( langCode ) ) || matcher.test( langCode ) || - matcher.test( $.uls.data.script( langCode ) ); + matcher.test( $.uls.data.getScript( langCode ) ); } }; From 7d48ec230b8c15724b6654c18968e243bc04ae5f Mon Sep 17 00:00:00 2001 From: "Amir E. Aharoni" Date: Sun, 7 Oct 2012 21:47:24 +0200 Subject: [PATCH 10/15] .regions -> .getRegions --- src/jquery.uls.data.utils.js | 8 ++++---- src/jquery.uls.lcd.js | 2 +- src/jquery.uls.regionfilter.js | 2 +- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/src/jquery.uls.data.utils.js b/src/jquery.uls.data.utils.js index 1915591..95766f5 100644 --- a/src/jquery.uls.data.utils.js +++ b/src/jquery.uls.data.utils.js @@ -172,7 +172,7 @@ for ( var language in $.uls.data.languages ) { for ( var i = 0; i < regions.length; i++ ) { - if ( $.inArray( regions[i], $.uls.data.regions( language ) ) !== -1 ) { + if ( $.inArray( regions[i], $.uls.data.getRegions( language ) ) !== -1 ) { languagesInRegions.push( language ); break; } @@ -211,7 +211,7 @@ var languagesByScriptInRegion = {}; for ( var language in $.uls.data.languages ) { - if ( $.inArray( region, $.uls.data.regions( language ) ) !== -1 ) { + if ( $.inArray( region, $.uls.data.getRegions( language ) ) !== -1 ) { var script = $.uls.data.getScript( language ); if ( languagesByScriptInRegion[script] === undefined ) { languagesByScriptInRegion[script] = []; @@ -300,7 +300,7 @@ for ( var language in $.uls.data.languages ) { for ( var i = 0; i < regions.length; i++ ) { - if ( $.inArray( regions[i], $.uls.data.regions( language ) ) !== -1 ) { + if ( $.inArray( regions[i], $.uls.data.getRegions( language ) ) !== -1 ) { var scriptGroup = $.uls.data.scriptGroupOfLanguage( language ); if ( languagesByScriptGroupInRegions[scriptGroup] === undefined ) { languagesByScriptGroupInRegions[scriptGroup] = []; @@ -340,7 +340,7 @@ for ( var language in $.uls.data.languages ) { var script = $.uls.data.getScript( language ); var scriptGroup = $.uls.data.groupOfScript( script ); - var regions = $.uls.data.regions( language ); + var regions = $.uls.data.getRegions( language ); for ( var regionNum = 0; regionNum < regions.length; regionNum++ ) { region = regions[regionNum]; diff --git a/src/jquery.uls.lcd.js b/src/jquery.uls.lcd.js index 4273898..1fbcd26 100644 --- a/src/jquery.uls.lcd.js +++ b/src/jquery.uls.lcd.js @@ -80,7 +80,7 @@ if ( region ) { regions.push( region ); } else { - regions = $.uls.data.regions( langCode ); + regions = $.uls.data.getRegions( langCode ); } // World wide languages need not be repeated in all regions. diff --git a/src/jquery.uls.regionfilter.js b/src/jquery.uls.regionfilter.js index e3e3c0c..cb28ab1 100644 --- a/src/jquery.uls.regionfilter.js +++ b/src/jquery.uls.regionfilter.js @@ -51,7 +51,7 @@ }, test: function( langCode ) { - var langRegions = $.uls.data.regions( langCode ), + var langRegions = $.uls.data.getRegions( langCode ), region; for ( var i = 0; i < this.regions.length; i++ ) { From 5e16abf26dbece7075a8c0d532850420c506ad56 Mon Sep 17 00:00:00 2001 From: "Amir E. Aharoni" Date: Sun, 7 Oct 2012 21:50:05 +0200 Subject: [PATCH 11/15] .autonym -> .getAutonym --- examples/index-i18n.html | 2 +- examples/index.html | 2 +- src/jquery.uls.data.utils.js | 6 +++--- src/jquery.uls.languagefilter.js | 4 ++-- src/jquery.uls.lcd.js | 4 ++-- 5 files changed, 9 insertions(+), 9 deletions(-) diff --git a/examples/index-i18n.html b/examples/index-i18n.html index ed02775..0bea514 100644 --- a/examples/index-i18n.html +++ b/examples/index-i18n.html @@ -24,7 +24,7 @@ var i18n = $.i18n( ); $( '.uls-trigger' ).uls( { onSelect : function( language ) { - var languageName = $.uls.data.autonym( language ); + var languageName = $.uls.data.getAutonym( language ); $('a#pageLanguage').text( languageName ); i18n.locale = language; // For ULS diff --git a/examples/index.html b/examples/index.html index e3417ae..213588e 100644 --- a/examples/index.html +++ b/examples/index.html @@ -32,7 +32,7 @@ $( document ).ready( function() { $( '.uls-trigger' ).uls( { onSelect : function( language ) { - var languageName = $.uls.data.autonym( language ); + var languageName = $.uls.data.getAutonym( language ); $('a#pageLanguage').text( languageName ); }, quickList: ['en', 'hi', 'he', 'ml', 'ta','fr'] //FIXME diff --git a/src/jquery.uls.data.utils.js b/src/jquery.uls.data.utils.js index 95766f5..3e9263f 100644 --- a/src/jquery.uls.data.utils.js +++ b/src/jquery.uls.data.utils.js @@ -79,7 +79,7 @@ var autonymsByCode = {}; for ( var language in $.uls.data.languages ) { - autonymsByCode[language] = $.uls.data.autonym( language ); + autonymsByCode[language] = $.uls.data.getAutonym( language ); } return autonymsByCode; @@ -429,8 +429,8 @@ * @param two language codes */ $.uls.data.sortByAutonym = function( a, b ) { - var autonymA = $.uls.data.autonym( a ) || a, - autonymB = $.uls.data.autonym( b ) || b; + var autonymA = $.uls.data.getAutonym( a ) || a, + autonymB = $.uls.data.getAutonym( b ) || b; return ( autonymA.toLowerCase() < autonymB.toLowerCase() ) ? -1 : 1; }; diff --git a/src/jquery.uls.languagefilter.js b/src/jquery.uls.languagefilter.js index 3acfe15..9c1d4d3 100644 --- a/src/jquery.uls.languagefilter.js +++ b/src/jquery.uls.languagefilter.js @@ -208,7 +208,7 @@ suggestion = userInput + languageName.substring( userInput.length, languageName.length ); if ( suggestion.toLowerCase() !== languageName.toLowerCase() ) { // see if it was autonym match - autonym = $.uls.data.autonym( langCode ) || ''; + autonym = $.uls.data.getAutonym( langCode ) || ''; suggestion = userInput + autonym.substring( userInput.length, autonym.length ); if ( suggestion !== autonym ) { // Give up. It may be iso/script code match. @@ -247,7 +247,7 @@ var matcher = new RegExp( "^" + this.escapeRegex( searchTerm ), 'i' ), languageName = this.options.languages[langCode]; return matcher.test( languageName ) || - matcher.test( $.uls.data.autonym( langCode ) ) || + matcher.test( $.uls.data.getAutonym( langCode ) ) || matcher.test( langCode ) || matcher.test( $.uls.data.getScript( langCode ) ); } diff --git a/src/jquery.uls.lcd.js b/src/jquery.uls.lcd.js index 1fbcd26..b22aa65 100644 --- a/src/jquery.uls.lcd.js +++ b/src/jquery.uls.lcd.js @@ -74,7 +74,7 @@ addToRegion: function( langCode, region ) { var that = this; var language = that.options.languages[langCode], - langName = $.uls.data.autonym( langCode ) || language || langCode, + langName = $.uls.data.getAutonym( langCode ) || language || langCode, regions = []; if ( region ) { @@ -206,7 +206,7 @@ var $column = this.getColumn( 'quick', i % 4 === 0 ); var langCode = quickList[i]; var language = this.options.languages[langCode]; - var langName = $.uls.data.autonym( langCode ) || language || langCode; + var langName = $.uls.data.getAutonym( langCode ) || language || langCode; var $li = $( '
  • ' ) .data( 'code', langCode ) .attr( { From d74d9b003b99e0f5c18bf6460b64f9c81816e8f2 Mon Sep 17 00:00:00 2001 From: "Amir E. Aharoni" Date: Sun, 7 Oct 2012 21:50:56 +0200 Subject: [PATCH 12/15] .autonyms -> .getAutonyms --- src/jquery.uls.core.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/jquery.uls.core.js b/src/jquery.uls.core.js index c5c9ac6..f86d1fd 100644 --- a/src/jquery.uls.core.js +++ b/src/jquery.uls.core.js @@ -317,7 +317,7 @@ menu: template, onSelect: null, // Callback function to be called when a language is selected searchAPI: null, // Language search API - languages: $.uls.data.autonyms(), // Languages to be used for ULS, default is all languages + languages: $.uls.data.getAutonyms(), // Languages to be used for ULS, default is all languages quickList: null // Array of language codes of function that returns such }; From bd355b249d3221584db3da22747b5f459d599778 Mon Sep 17 00:00:00 2001 From: "Amir E. Aharoni" Date: Sun, 7 Oct 2012 22:00:58 +0200 Subject: [PATCH 13/15] .allRegions -> .getAllRegions --- src/jquery.uls.data.utils.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/jquery.uls.data.utils.js b/src/jquery.uls.data.utils.js index 3e9263f..0d126f0 100644 --- a/src/jquery.uls.data.utils.js +++ b/src/jquery.uls.data.utils.js @@ -249,7 +249,7 @@ * @return associative array */ $.uls.data.getAllLanguagesByScriptGroup = function() { - return $.uls.data.languagesByScriptGroupInRegions( $.uls.data.allRegions() ); + return $.uls.data.languagesByScriptGroupInRegions( $.uls.data.getAllRegions() ); }; $.uls.data.allLanguagesByScriptGroup = function() { // deprecated From faeac72491786f24716ad2efdf16b897e37aa9d7 Mon Sep 17 00:00:00 2001 From: "Amir E. Aharoni" Date: Sun, 7 Oct 2012 22:09:52 +0200 Subject: [PATCH 14/15] .languagesByScript* -> .getLanguagesByScript* --- src/jquery.uls.data.utils.js | 8 ++++---- src/jquery.uls.languagefilter.js | 2 +- src/jquery.uls.regionfilter.js | 2 +- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/src/jquery.uls.data.utils.js b/src/jquery.uls.data.utils.js index 0d126f0..2aff251 100644 --- a/src/jquery.uls.data.utils.js +++ b/src/jquery.uls.data.utils.js @@ -154,7 +154,7 @@ * @return array of strings (languages codes) */ $.uls.data.getLanguagesInRegion = function( region ) { - return $.uls.data.languagesInRegions( [ region ] ); + return $.uls.data.getLanguagesInRegions( [ region ] ); }; $.uls.data.languagesInRegion = function( region ) { // deprecated @@ -193,7 +193,7 @@ * @return array of strings (languages codes) */ $.uls.data.getLanguagesInRegionGroup = function( groupNum ) { - return $.uls.data.languagesInRegions( $.uls.data.regionsInGroup( groupNum ) ); + return $.uls.data.getLanguagesInRegions( $.uls.data.regionsInGroup( groupNum ) ); }; $.uls.data.languagesInRegionGroup = function( groupNum ) { // deprecated @@ -235,7 +235,7 @@ * @return associative array */ $.uls.data.getLanguagesByScriptGroupInRegion = function( region ) { - return $.uls.data.languagesByScriptGroupInRegions( [ region ] ); + return $.uls.data.getLanguagesByScriptGroupInRegions( [ region ] ); }; $.uls.data.languagesByScriptGroupInRegion = function( region ) { // deprecated @@ -249,7 +249,7 @@ * @return associative array */ $.uls.data.getAllLanguagesByScriptGroup = function() { - return $.uls.data.languagesByScriptGroupInRegions( $.uls.data.getAllRegions() ); + return $.uls.data.getLanguagesByScriptGroupInRegions( $.uls.data.getAllRegions() ); }; $.uls.data.allLanguagesByScriptGroup = function() { // deprecated diff --git a/src/jquery.uls.languagefilter.js b/src/jquery.uls.languagefilter.js index 9c1d4d3..293cd1f 100644 --- a/src/jquery.uls.languagefilter.js +++ b/src/jquery.uls.languagefilter.js @@ -135,7 +135,7 @@ search: function() { var query = $.trim( this.$element.val() ), - languages = $.uls.data.languagesByScriptGroup( this.options.languages ), + languages = $.uls.data.getLanguagesByScriptGroup( this.options.languages ), scriptGroup, langNum, langCode; this.resultCount = 0; for ( scriptGroup in languages ) { diff --git a/src/jquery.uls.regionfilter.js b/src/jquery.uls.regionfilter.js index cb28ab1..6f65bff 100644 --- a/src/jquery.uls.regionfilter.js +++ b/src/jquery.uls.regionfilter.js @@ -74,7 +74,7 @@ } else { this.cache = {}; // Get the languages grouped by script group - var languagesByScriptGroup = $.uls.data.languagesByScriptGroup( this.options.languages ); + var languagesByScriptGroup = $.uls.data.getLanguagesByScriptGroup( this.options.languages ); for ( var scriptGroup in languagesByScriptGroup ) { // Get the languages for the script group var languages = languagesByScriptGroup[scriptGroup]; From c40caf4a2945889e2a08a9e0e6a5a6da87ec32c7 Mon Sep 17 00:00:00 2001 From: "Amir E. Aharoni" Date: Mon, 8 Oct 2012 08:27:50 +0200 Subject: [PATCH 15/15] Update the remaining calls to deprecated functions --- src/jquery.uls.data.utils.js | 10 ++++---- src/jquery.uls.lcd.js | 4 +-- src/jquery.uls.regionfilter.js | 4 +-- test/jquery.uls.test.js | 46 +++++++++++++++++----------------- 4 files changed, 32 insertions(+), 32 deletions(-) diff --git a/src/jquery.uls.data.utils.js b/src/jquery.uls.data.utils.js index 2aff251..6d2f32b 100644 --- a/src/jquery.uls.data.utils.js +++ b/src/jquery.uls.data.utils.js @@ -193,7 +193,7 @@ * @return array of strings (languages codes) */ $.uls.data.getLanguagesInRegionGroup = function( groupNum ) { - return $.uls.data.getLanguagesInRegions( $.uls.data.regionsInGroup( groupNum ) ); + return $.uls.data.getLanguagesInRegions( $.uls.data.getRegionsInGroup( groupNum ) ); }; $.uls.data.languagesInRegionGroup = function( groupNum ) { // deprecated @@ -270,7 +270,7 @@ for ( scriptGroup in $.uls.data.scriptgroups ) { for ( language in languages ) { - langScriptGroup = $.uls.data.scriptGroupOfLanguage( language ); + langScriptGroup = $.uls.data.getScriptGroupOfLanguage( language ); if( langScriptGroup !== scriptGroup ) { continue; } @@ -301,7 +301,7 @@ for ( var language in $.uls.data.languages ) { for ( var i = 0; i < regions.length; i++ ) { if ( $.inArray( regions[i], $.uls.data.getRegions( language ) ) !== -1 ) { - var scriptGroup = $.uls.data.scriptGroupOfLanguage( language ); + var scriptGroup = $.uls.data.getScriptGroupOfLanguage( language ); if ( languagesByScriptGroupInRegions[scriptGroup] === undefined ) { languagesByScriptGroupInRegions[scriptGroup] = []; } @@ -339,7 +339,7 @@ for ( var language in $.uls.data.languages ) { var script = $.uls.data.getScript( language ); - var scriptGroup = $.uls.data.groupOfScript( script ); + var scriptGroup = $.uls.data.getGroupOfScript( script ); var regions = $.uls.data.getRegions( language ); for ( var regionNum = 0; regionNum < regions.length; regionNum++ ) { @@ -415,7 +415,7 @@ * @return string script group name */ $.uls.data.getScriptGroupOfLanguage = function( language ) { - return $.uls.data.groupOfScript( $.uls.data.getScript( language ) ); + return $.uls.data.getGroupOfScript( $.uls.data.getScript( language ) ); }; $.uls.data.scriptGroupOfLanguage = function( language ) { // deprecated diff --git a/src/jquery.uls.lcd.js b/src/jquery.uls.lcd.js index b22aa65..a401960 100644 --- a/src/jquery.uls.lcd.js +++ b/src/jquery.uls.lcd.js @@ -106,8 +106,8 @@ var lastLanguage = $column.find( 'li:last' ).data( 'code' ); if ( lastLanguage ) { - var lastScriptGroup = $.uls.data.scriptGroupOfLanguage( lastLanguage ), - currentScriptGroup = $.uls.data.scriptGroupOfLanguage( langCode ); + var lastScriptGroup = $.uls.data.getScriptGroupOfLanguage( lastLanguage ), + currentScriptGroup = $.uls.data.getScriptGroupOfLanguage( langCode ); if ( lastScriptGroup !== currentScriptGroup ) { if ( $column.find( 'li' ).length > 2 ) { diff --git a/src/jquery.uls.regionfilter.js b/src/jquery.uls.regionfilter.js index 6f65bff..45fee30 100644 --- a/src/jquery.uls.regionfilter.js +++ b/src/jquery.uls.regionfilter.js @@ -17,7 +17,7 @@ * @licence MIT License */ -(function ( $ ) { +( function ( $ ) { "use strict"; /* RegionSelector plugin definition */ @@ -44,7 +44,7 @@ init: function() { var region = this.$element.data( 'region' ); - this.regions = $.uls.data.regionsInGroup( this.regionGroup ); + this.regions = $.uls.data.getRegionsInGroup( this.regionGroup ); if ( region ) { this.regions.push( region ); } diff --git a/test/jquery.uls.test.js b/test/jquery.uls.test.js index a2e41fd..55eb9c4 100644 --- a/test/jquery.uls.test.js +++ b/test/jquery.uls.test.js @@ -25,8 +25,8 @@ var result = []; for ( var language in $.uls.data.languages ) { - var script = $.uls.data.script( language ); - if ( $.uls.data.groupOfScript( script ) === 'Other' ) { + var script = $.uls.data.getScript( language ); + if ( $.uls.data.getGroupOfScript( script ) === 'Other' ) { result.push( script ); } } @@ -42,7 +42,7 @@ var result = []; for ( var language in $.uls.data.languages ) { - if ( typeof $.uls.data.autonym( language ) !== 'string' ) { + if ( typeof $.uls.data.getAutonym( language ) !== 'string' ) { result.push( language ); } } @@ -56,7 +56,7 @@ test( "-- $.uls.data testing", 27, function ( assert ) { - assert.strictEqual( $.uls.data.autonyms()['he'], 'עברית', 'Correct autonym is returned for Hebrew using autonyms().' ); + assert.strictEqual( $.uls.data.getAutonyms()['he'], 'עברית', 'Correct autonym is returned for Hebrew using getAutonyms().' ); // This test assumes that we don't want any scripts to be in the 'Other' // group. Actually, this may become wrong some day. @@ -64,35 +64,35 @@ assert.deepEqual( languagesWithoutAutonym(), [], 'All languages have autonyms.' ); assert.strictEqual( - $.uls.data.groupOfScript( 'Beng' ), + $.uls.data.getGroupOfScript( 'Beng' ), 'SouthAsian', 'Bengali script belongs to the SouthAsian group.' ); assert.strictEqual( - $.uls.data.scriptGroupOfLanguage( 'iu' ), + $.uls.data.getScriptGroupOfLanguage( 'iu' ), 'NativeAmerican', 'The script of the Inupiaq language belongs to the NativeAmerican group.' ); - assert.strictEqual( $.uls.data.script( 'ii' ), 'Yiii', 'Correct script of the Yi language was selected' ); - assert.deepEqual( $.uls.data.regions( 'lzz' ), [ + assert.strictEqual( $.uls.data.getScript( 'ii' ), 'Yiii', 'Correct script of the Yi language was selected' ); + assert.deepEqual( $.uls.data.getRegions( 'lzz' ), [ 'EU', 'ME' ], 'Correct regions of the Laz language were selected' ); - assert.strictEqual( $.uls.data.regions( 'no-such-language' ), 'UNKNOWN', "The region of an invalid language is 'UNKNOWN'" ); + assert.strictEqual( $.uls.data.getRegions( 'no-such-language' ), 'UNKNOWN', "The region of an invalid language is 'UNKNOWN'" ); - var allLanguagesByRegionAndScript = $.uls.data.allLanguagesByRegionAndScript(); + var allLanguagesByRegionAndScript = $.uls.data.getAllLanguagesByRegionAndScript(); assert.deepEqual( allLanguagesByRegionAndScript['4']['AS']['SouthEastAsian']['Bugi'], [ 'bug' ], 'All languages in the Buginese script in Asia were selected' ); - assert.deepEqual( $.uls.data.languagesInRegion( "PA" ), + assert.deepEqual( $.uls.data.getLanguagesInRegion( "PA" ), [ "ace", "bi", "ch", "en-gb", "en", "fj", "haw", "hif-latn", "hif", "ho", "jv", "mh", "mi", "na", "niu", "pih", "pis", "pt", "rtm", "sm", "tet", "to", "tpi", "ty", "wls" ], "languages of region PA are selected correctly" ); - assert.deepEqual( $.uls.data.languagesInRegions( ["AM", "WW"] ), + assert.deepEqual( $.uls.data.getLanguagesInRegions( ["AM", "WW"] ), [ "akz", "arn", "aro", "ase", "avk", "ay", "cho", "chr", "chy", "cr-cans", "cr-latn", "cr", "en-ca", "en", "eo", "es-419", "es-formal", "es", "esu", "fr", "gcf", "gn", @@ -104,42 +104,42 @@ "languages of regions AM and WW are selected correctly" ); - assert.deepEqual( $.uls.data.languagesInScript( 'Knda' ), [ + assert.deepEqual( $.uls.data.getLanguagesInScript( 'Knda' ), [ "kn", "tcy" ], "languages in script Knda are selected correctly" ); - assert.deepEqual( $.uls.data.languagesInScripts( ['Geor', 'Armn'] ), + assert.deepEqual( $.uls.data.getLanguagesInScripts( ['Geor', 'Armn'] ), ["hy", "ka", "xmf"], "languages in scripts Geor and Armn are selected correctly" ); - assert.deepEqual( $.uls.data.regionsInGroup( 3 ), [ + assert.deepEqual( $.uls.data.getRegionsInGroup( 3 ), [ "EU", "ME", "AF" ], "regions in group 3 are selected correctly" ); - assert.deepEqual( $.uls.data.regionsInGroup( 2 ), [ + assert.deepEqual( $.uls.data.getRegionsInGroup( 2 ), [ "AM" ], "regions in group 2 are selected correctly" ); - assert.deepEqual( $.uls.data.regionsInGroup( 1 ), [ + assert.deepEqual( $.uls.data.getRegionsInGroup( 1 ), [ "WW" ], "regions in group 1 are selected correctly" ); - var languagesByScriptInAM = $.uls.data.languagesByScriptInRegion( "AM" ); + var languagesByScriptInAM = $.uls.data.getLanguagesByScriptInRegion( "AM" ); assert.deepEqual( languagesByScriptInAM['Cans'], [ "cr-cans", "cr", "ike-cans", "iu" ], "correct languages in Cans in AM selected" ); - assert.strictEqual( $.uls.data.autonym( 'pa' ), 'ਪੰਜਾਬੀ', 'Correct autonym of the Punjabi language was selected' ); + assert.strictEqual( $.uls.data.getAutonym( 'pa' ), 'ਪੰਜਾਬੀ', 'Correct autonym of the Punjabi language was selected' ); - var languagesByScriptGroupInEMEA = $.uls.data.languagesByScriptGroupInRegions( $.uls.data.regionsInGroup( 3 ) ); + var languagesByScriptGroupInEMEA = $.uls.data.getLanguagesByScriptGroupInRegions( $.uls.data.getRegionsInGroup( 3 ) ); assert.deepEqual( languagesByScriptGroupInEMEA['WestCaucasian'], [ 'hy', 'ka', 'xmf' ], 'Correct languages in WestCaucasian script group in EMEA selected' ); - var allLanguagesByScriptGroup = $.uls.data.allLanguagesByScriptGroup(); + var allLanguagesByScriptGroup = $.uls.data.getAllLanguagesByScriptGroup(); assert.deepEqual( allLanguagesByScriptGroup['Greek'], [ 'el', 'grc', 'pnt', 'ruq-grek', 'tsd' ], 'All languages in the Greek script found' ); - assert.deepEqual( $.uls.data.allRegions(), [ + assert.deepEqual( $.uls.data.getAllRegions(), [ "WW", "AM", "EU", "ME", "AF", "AS", "PA" ], "All regions found" ); @@ -153,7 +153,7 @@ assert.strictEqual( $.uls.data.getDir( "mzn" ), "rtl", "Mazandarani language is RTL" ); assert.strictEqual( $.uls.data.getDir( "uk" ), "ltr", "Ukrainian language is LTR" ); - assert.ok( $.inArray( "sah", $.uls.data.languagesInTerritory( "RU" ) ) + assert.ok( $.inArray( "sah", $.uls.data.getLanguagesInTerritory( "RU" ) ) > -1, "Sakha language is spoken in Russia" ); } );