bryce/jquery.uls
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Do nothing if the clicked region is already selected

Browse Source 
Supposed to fix bug
https://bugzilla.wikimedia.org/show_bug.cgi?id=39932
This commit is contained in:
Amir E. Aharoni
2012-10-05 08:38:43 +02:00
parent c5a22fc636
commit 97194de047
1 changed files with 12 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/jquery.uls.regionfilter.js
View File

@@ -125,12 +125,11 @@
}, },
click: function( e ) { click: function( e ) {
// Don't do anything if a region is selected already
if( this.$element.hasClass( 'active' ) ) { if( this.$element.hasClass( 'active' ) ) {
this.$element.removeClass( 'active' ); return;
if ( this.options.noresults ) {
this.options.noresults.call();
} }
} else {
// Re-populate the list of languages // Re-populate the list of languages
this.options.$target.empty(); this.options.$target.empty();
this.show(); this.show();
@@ -141,7 +140,6 @@
this.$element.addClass( 'active' ); this.$element.addClass( 'active' );
} }
} }
}
}; };
/* RegionSelector plugin definition */ /* RegionSelector plugin definition */