bryce/jquery.uls
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Avoid jumping to WW while scrolling up.

Browse Source 
Correct the precision of scroll top by taking padding into account.
Fixes https://bugzilla.wikimedia.org/show_bug.cgi?id=39224

Change-Id: I988e9a09018bf2d5c27f11d21947e036c79f56b9
This commit is contained in:
Santhosh Thottingal
2012-10-24 18:18:18 +05:30
parent bebda013d4
commit c883c3a774
1 changed files with 3 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
src/jquery.uls.lcd.js
View File

@@ -272,9 +272,10 @@
lcd.$element.find( 'div.uls-lcd-region-section' ).each( function () { lcd.$element.find( 'div.uls-lcd-region-section' ).each( function () {
var $lcdRegionSection = $( this ), var $lcdRegionSection = $( this ),
top = $lcdRegionSection.position().top, top = $lcdRegionSection.position().top,
height = $lcdRegionSection.height(); height = $lcdRegionSection.height(),
padding = 10;
if ( top < scrollTop && height > scrollBottom ) { if ( top - padding <= scrollTop && height > scrollBottom ) {
inviewRegion = $lcdRegionSection.attr( 'id' ); inviewRegion = $lcdRegionSection.attr( 'id' );
return true; return true;
} }