From 6ebd1b413c82b1b22e8090690f65bd1a65c60c7e Mon Sep 17 00:00:00 2001 From: Marius Hoch Date: Wed, 7 Sep 2016 00:51:53 +0200 Subject: [PATCH] Use an empty array for quickList everywhere, not false/null Also fix one type quicklist -> quickList, per @edg2s. Follows cb85cda10e7b68af1009bc6e573cf7cc048ce943. https://phabricator.wikimedia.org/T144871 --- src/jquery.uls.core.js | 4 ++-- src/jquery.uls.lcd.js | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/jquery.uls.core.js b/src/jquery.uls.core.js index d92008a..9e73fee 100644 --- a/src/jquery.uls.core.js +++ b/src/jquery.uls.core.js @@ -260,7 +260,7 @@ languages: this.languages, columns: columnsOptions[ this.getMenuWidth() ], - quickList: languagesCount > 12 ? this.options.quickList : false, + quickList: languagesCount > 12 ? this.options.quickList : [], clickhandler: $.proxy( this.select, this ), source: this.$languageFilter, showRegions: this.options.showRegions, @@ -397,7 +397,7 @@ onSelect: null, // Callback function to be called when a language is selected searchAPI: null, // Language search API languages: $.uls.data.getAutonyms(), // Languages to be used for ULS, default is all languages - quickList: null, // Array of language codes or function that returns such + quickList: [], // Array of language codes or function that returns such // The options are wide (4 columns), medium (2 columns), and narrow (1 column). // If not specified, it will be set automatically. menuWidth: null, diff --git a/src/jquery.uls.lcd.js b/src/jquery.uls.lcd.js index f0bfb88..e83a1b7 100644 --- a/src/jquery.uls.lcd.js +++ b/src/jquery.uls.lcd.js @@ -412,7 +412,7 @@ // Other values will have rendering issues. columns: 4, languageDecorator: null, - quicklist: [] + quickList: [] }; $.fn.lcd.Constructor = LanguageCategoryDisplay;