Change code structure a bit per code review comments
This commit is contained in:
@@ -208,17 +208,16 @@
|
|||||||
results = [];
|
results = [];
|
||||||
|
|
||||||
$.each( result.languagesearch, function ( apiCode, name ) {
|
$.each( result.languagesearch, function ( apiCode, name ) {
|
||||||
var code,
|
var code, redirect;
|
||||||
redirect = $.uls.data.isRedirect( apiCode );
|
|
||||||
|
|
||||||
if ( this.options.languages[ apiCode ] ) {
|
if ( this.options.languages[ apiCode ] ) {
|
||||||
code = apiCode;
|
code = apiCode;
|
||||||
} else if ( redirect && this.options.languages[ redirect ] ) {
|
|
||||||
// Language tags are messy. Try to make sure we handle
|
|
||||||
// them gracefully with regards to redirects.
|
|
||||||
code = redirect;
|
|
||||||
} else {
|
} else {
|
||||||
return;
|
redirect = $.uls.data.isRedirect( apiCode );
|
||||||
|
if ( !redirect || !this.options.languages[ redirect ] ) {
|
||||||
|
return;
|
||||||
|
}
|
||||||
|
code = redirect;
|
||||||
}
|
}
|
||||||
|
|
||||||
// Because of the redirect checking above, we might get duplicates.
|
// Because of the redirect checking above, we might get duplicates.
|
||||||
|
|||||||
Reference in New Issue
Block a user