From f1c2216c4c7c1c0519def14b58c602c1f91e9860 Mon Sep 17 00:00:00 2001 From: pginer Date: Mon, 19 Nov 2012 12:49:50 +0100 Subject: [PATCH] Fixes CSSLint issues for jquery.uls.lcd.css CSS adjustments and JS modifications (adding classes to HTML elements) to solve issues reported by CSS Lint when validating jquery.uls.lcd.css --- css/jquery.uls.css | 3 ++- css/jquery.uls.lcd.css | 25 +++++++++++-------------- src/jquery.uls.lcd.js | 8 ++++---- 3 files changed, 17 insertions(+), 19 deletions(-) diff --git a/css/jquery.uls.css b/css/jquery.uls.css index 773ff0f..2b7d01d 100644 --- a/css/jquery.uls.css +++ b/css/jquery.uls.css @@ -54,7 +54,8 @@ color: #555; } -.uls-menu h3 { +.uls-menu .uls-lcd-region-title { + color: #777; font-size: 14pt; line-height: 1.5em; padding-left: 0; diff --git a/css/jquery.uls.lcd.css b/css/jquery.uls.lcd.css index ba029c8..6135af6 100644 --- a/css/jquery.uls.lcd.css +++ b/css/jquery.uls.lcd.css @@ -1,21 +1,20 @@ -.uls-lcd-region-section h3 { - color: #777; -} - .uls-lcd-region-section ul li:hover { background-color: #eaeff7; } +.uls-lcd-region-section{ + margin-top:10px; +} + /* Language list */ .uls-language-list { height: 22em; overflow: auto; - padding: 10px; width: auto; } .uls-language-block ul { - margin: 0 0 1.6em; + margin: 0 0 1.5em; } .uls-language-list ul li { @@ -62,10 +61,9 @@ line-height: 1.6em; } -.uls-language-block .three.columns { +.uls-language-block .columns { width: 22%; } - .uls-language-block { width: 100%; } @@ -75,11 +73,11 @@ height: 100%; } -.uls-no-results-view h2{ +.uls-no-results-found-title{ font-weight: bold; } -#uls-no-found-more { +.uls-no-found-more { font-size: 0.9em; background: #F8F8F8; width: 100%; @@ -88,8 +86,7 @@ position:absolute; bottom:0; left:0; -} - -.uls-lcd-region-section ul li.uls-column-break:hover { - background: none; + -webkit-border-radius: 0 0 5px 5px; + -moz-border-radius: 0 0 5px 5px; + border-radius: 0 0 5px 5px; } \ No newline at end of file diff --git a/src/jquery.uls.lcd.js b/src/jquery.uls.lcd.js index bd86dcc..332882c 100644 --- a/src/jquery.uls.lcd.js +++ b/src/jquery.uls.lcd.js @@ -24,10 +24,10 @@ var noResultsTemplate = '\
\ -

\ +

\ No results found\

\ -
\ +
\
\

\ You can search by language name, \ @@ -167,7 +167,7 @@ $.each( $.uls.data.regiongroups, function( regionCode, regionIndex ) { $section = $( '

' ).addClass( 'twelve columns uls-lcd-region-section' ).prop( 'id', regionCode ); $sectionTitle = $( '

' ) - .addClass( 'eleven columns uls-lcd-region-section offset-by-one' ) + .addClass( 'eleven columns uls-lcd-region-section uls-lcd-region-title offset-by-one' ) .text( regions[regionCode] ); $section.append( $sectionTitle ); that.$element.append( $section ); @@ -197,7 +197,7 @@ quickList.sort( $.uls.data.sortByAutonym ); var $quickListSection = $( '
' ).addClass( 'twelve columns uls-lcd-region-section' ).prop( 'id', 'uls-lcd-quicklist' ); var $quickListSectionTitle = $( '

' ) - .addClass( 'eleven columns uls-lcd-region-section offset-by-one' ) + .addClass( 'eleven columns uls-lcd-region-section uls-lcd-region-title offset-by-one' ) .text( 'Common languages' ); // This is placeholder text if jquery.i18n not present $quickListSection.append( $quickListSectionTitle ); this.$element.prepend( $quickListSection );