bryce/jquery.uls
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix lint errors

Browse Source
This commit is contained in:
NikG
2022-11-07 13:10:17 +02:00
committed by Niklas Laxström
parent cd1452eb76
commit f3f14a2098
1 changed files with 21 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

36
src/jquery.uls.lcd.js
View File

@@ -60,9 +60,10 @@
this.groupByRegionOverride = null; this.groupByRegionOverride = null;
// The index of the language option that is currently visited using arrow key navigation // The index of the language option that is currently visited using arrow key navigation
// Can take values in the [0, languageOptionListItemsLength - 1] range for top to bottom navigation, // Can take values in the [0, languageOptionListItemsLength - 1] range for top to bottom
// or in the [-1, -languageOptionListItemsLength + 1] range for bottom to top navigation. // navigation, or in the [-1, -languageOptionListItemsLength + 1] range for bottom to top
this.navigationIndex = null // navigation.
this.navigationIndex = null;
this.render(); this.render();
this.listen(); this.listen();
@@ -74,9 +75,10 @@
/** /**
* Returns a jQuery object containing a collection of all the * Returns a jQuery object containing a collection of all the
* language option <li> elements * language option <li> elements
*
* @return {jQuery} * @return {jQuery}
*/ */
getLanguageOptionListItems() { getLanguageOptionListItems: function () {
return this.$element.find( 'li[data-code]' ); return this.$element.find( 'li[data-code]' );
}, },
@@ -87,16 +89,18 @@
* LanguageFilter. * LanguageFilter.
*/ */
navigateDown: function () { navigateDown: function () {
var maxIndex = this.getLanguageOptionListItems().length - 1;
// We support navigation starting both from the top and the bottom of the language list. // We support navigation starting both from the top and the bottom of the language list.
// The navigation should stop when the last language option is already highlighted (for top to bottom navigation). // The navigation should stop when the last language option is already highlighted (for
// For top to bottom navigation, that happens when navigation index is equal to languageOptionListItemsLength - 1. // top to bottom navigation). For top to bottom navigation, that happens when navigation
// For bottom to top navigation, that happens when navigation index is equal to -1. // index is equal to languageOptionListItemsLength - 1. For bottom to top navigation,
if ( this.navigationIndex === this.getLanguageOptionListItems().length - 1 || this.navigationIndex === -1 ) { // that happens when navigation index is equal to -1.
if ( this.navigationIndex === maxIndex || this.navigationIndex === -1 ) {
return; return;
} }
if ( this.navigationIndex === null ) { if ( this.navigationIndex === null ) {
this.navigationIndex = 0 this.navigationIndex = 0;
} else { } else {
this.navigationIndex++; this.navigationIndex++;
} }
@@ -110,15 +114,17 @@
* LanguageFilter. * LanguageFilter.
*/ */
navigateUp: function () { navigateUp: function () {
var maxIndex = this.getLanguageOptionListItems().length - 1;
// We support navigation starting both from the top and the bottom of the language list. // We support navigation starting both from the top and the bottom of the language list.
// The navigation should stop when the first language option is already highlighted (for bottom to top navigation). // The navigation should stop when the first language option is already highlighted (for
// For top to bottom navigation, that happens when navigation index is equal to 0. // bottom to top navigation). For top to bottom navigation, that happens when navigation
// For bottom to top navigation, that happens when navigation index is equal to -languageOptionListItemsLength + 1. // index is equal to 0. For bottom to top navigation, that happens when navigation index
if ( this.navigationIndex === 0 || this.navigationIndex === -this.getLanguageOptionListItems().length + 1 ) { // is equal to -languageOptionListItemsLength + 1.
if ( this.navigationIndex === 0 || this.navigationIndex === -maxIndex ) {
return; return;
} }
this.navigationIndex-- this.navigationIndex--;
this.highlightLanguageOption(); this.highlightLanguageOption();
}, },
@@ -126,7 +132,7 @@
* Adds a specific class ("language-option--highlighted") only to the n-th * Adds a specific class ("language-option--highlighted") only to the n-th
* language option <li> element (where n = navigation index) * language option <li> element (where n = navigation index)
*/ */
highlightLanguageOption() { highlightLanguageOption: function () {
this.getLanguageOptionListItems().removeClass( 'language-option--highlighted' ); this.getLanguageOptionListItems().removeClass( 'language-option--highlighted' );
this.getLanguageOptionListItems().eq( this.navigationIndex ).addClass( 'language-option--highlighted' ); this.getLanguageOptionListItems().eq( this.navigationIndex ).addClass( 'language-option--highlighted' );
}, },