bryce/jquery.uls
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix the cancel event function to prevent erroneous close

Browse Source 
Changed the conditions for the cancel event function so that the ULS popup does not close when a descendant element of the trigger is clicked.

Was erroneously merged to gerrit as https://gerrit.wikimedia.org/r/#/c/261810/, I forgot that this was an upstream library.

https://phabricator.wikimedia.org/T122722
This commit is contained in:
This, that and the other
2016-01-02 02:25:23 +11:00
parent e6f7672b75
commit f53de5469b
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/jquery.uls.core.js
View File

@@ -319,7 +319,7 @@
* On cancel handler for the uls menu * On cancel handler for the uls menu
*/ */
cancel: function ( e ) { cancel: function ( e ) {
if ( e && this.$element.is( e.target ) ) { if ( e && ( this.$element.is( e.target ) || $.contains( this.$element[0], e.target ) ) ) {
return; return;
} }