bryce/jquery.uls
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
1,117 Commits 2 Branches 0 Tags
7a6e559fe5818ad2f0522281a06c4b7a03fe7c2e
Commit Graph

133 Commits

Author SHA1 Message Date
Santhosh Thottingal
d352b73c37 Merge pull request #145 from edg2s/patch-3 
Consistently use this when scope allows it
 2014-04-29 09:16:10 +05:30
Santhosh Thottingal
c7c938cf4c Merge pull request #143 from edg2s/patch-1 
Always close with 'cancel' method
 2014-04-26 16:59:26 +05:30
Santhosh Thottingal
04d11ea53f Remove the unused option menu 
Fixes issue #140

Change-Id: Idc04a45b97837c5f9bd1f975b6668b6539df0752
 2014-04-26 16:57:23 +05:30
Ed S
f0be8b5425 Consistently use this when scope allows it 
We have uls = this for scoping, but then we randomly switch between the two, even when 'this' is allowed. We only need to used the local variable in un-proxied anonymous functions.
 2014-04-22 14:59:46 -07:00
Ed S
2c0f4e1114 Only use default pos if top/left are undefined 
Allows 0 (which is falsey) to be passed as an offsets. Fixes #141
 2014-04-22 00:23:38 -07:00
Ed S
ad1be8c0af Always close with 'cancel' method 
So that the onCancel callback is useful. Fixes #142
 2014-04-22 00:14:39 -07:00
Santhosh Thottingal
cfba32afb5 Remove developer console logs when unknown language found 
They are happening whenever ULS triggers, or maybe whenever it loads. It's
pretty annoying.

See https://bugzilla.wikimedia.org/show_bug.cgi?id=45047

Change-Id: Ia58083f02d61e3b621112352e88d9e7cbfb2f0c0
 2013-11-25 20:08:40 +05:30
Santhosh Thottingal
33ec9285e3 Use events instead of callbacks for success or no results 
Allows extension users to bind for this event, also reduces callbacks

Change-Id: I14cc6d51ad23432956e3ea3275c72db26d71a8c8
 2013-08-15 12:16:12 +05:30
Amir E. Aharoni
601a5256b8 Add missing semicolon 2013-07-08 00:23:54 +03:00
MatmaRex
8a1e3eb18e Remove lazyload functionality entirely 
It was merely a stopgap solution to the problem of the dialog taking
forever to load. With that problem solved all of this awful code is no
longer needed.
 2013-06-27 16:31:50 +05:30
MatmaRex
8341bb8e21 Disable lazyload for language list 
The loading should be fast enough now after Id9397631 is merged,
taking no more than a second or two to render entirely. We could
consider showing a spinner while it's loading, but it doesn't seem
necessary.

This makes bug 39923 invalid.
 2013-06-27 16:30:17 +05:30
Santhosh Thottingal
fa667f0c14 Improve the scroll to view port logic 
Do minimal scroll when top of the window is out of view

Change-Id: I8a2eb01451961655b651d53763356bd7e0aa5abf
 2013-06-12 09:02:09 +05:30
Santhosh Thottingal
5541608278 Smooth scrolling for ULS window to viewport 
provide a jquery plugin function $.fn.scrollIntoView

Change-Id: Id0e5d3b385a13ab38089f8ae82e886c29a35e27a
 2013-06-05 17:54:41 +05:30
Santhosh Thottingal
db87f74096 Scroll the window to view 
Change-Id: I13afd396007f951c105156373ea0c961ec4e712d
 2013-05-31 14:38:08 +05:30
Santhosh Thottingal
9a98249d2e Merge branch 'master' of github.com:wikimedia/jquery.uls 2013-05-24 17:16:40 +05:30
Santhosh Thottingal
dceb664b04 Clear the search once a search and selection is done 
See https://bugzilla.wikimedia.org/show_bug.cgi?id=48151

Change-Id: I7b354835c7ff438bb665ca6f9b62da6ff5059e1c
 2013-05-24 17:12:54 +05:30
Amir E. Aharoni
64cc7969a7 Use the supplied position values instead of hardcoded 2013-04-26 16:11:12 +03:00
Amir E. Aharoni
6309d1889b Comments format 2013-04-25 14:48:37 +03:00
Amir E. Aharoni
a568b3244e Rename the hook to "visible" and add documentation 2013-04-25 13:29:25 +03:00
Amir E. Aharoni
b28bed9bb5 Add an afterShowing hook 
A hook that can optionally run after the ULS menu is shown.
There are things that cannot be done in ready(), because
the style may not have been initialized yet.
 2013-04-23 22:43:14 +03:00
Amir E. Aharoni
62cab27eb2 Leave only one var statement per scope 2013-04-22 14:40:12 +03:00
Santhosh Thottingal
0340e609a0 Expose compact mode as an option 
* some minor space cleanup
* Also close the ULS window when clicked outside

Change-Id: I06b465926196f79e47990e80e3b23f5a16474ba3
 2013-03-15 14:57:19 +05:30
Siebrand Mazeland
66d84936f9 Merge pull request #74 from amire80/coding_conventions 
Coding conventions, cleanup
 2013-02-07 21:01:24 -08:00
Pau Giner
7e800eb836 Settings at the bottom of the ULS 
Moves the settings block at the bottom of the ULS dialog in order
to distinguish more clearly the selection and configuration regions.
 2013-02-06 10:35:48 +01:00
Amir E. Aharoni
e40ca2e885 Whitespace, JSHint, removed unused function 2013-01-13 23:32:40 +02:00
Santhosh Thottingal
0e61876af5 Merge branch 'extra_languages' of git://github.com/amire80/jquery.uls into amire80-extra_languages 
Conflicts:
	src/jquery.uls.data.js
	src/jquery.uls.data.utils.js

Change-Id: I9c321891707b0d68328f4e4c8be1bd451794072d
 2013-01-07 15:45:48 +05:30
Amir E. Aharoni
d4ef33d4f8 Merge pull request #58 from amire80/whitespace 
Whitespace
 2013-01-02 23:09:40 -08:00
Amir E. Aharoni
49436026d8 Whitespace 2013-01-02 18:48:02 +02:00
Amir E. Aharoni
829c827483 Adding a special region 
This is supposed to allow adding special languages.

This region's section is hidden by default and can be enabled by
passing different options to the lcd object.
 2013-01-02 12:58:29 +02:00
Amir E. Aharoni
e78a2507d7 Whitespace 2012-12-30 20:34:32 +02:00
Siebrand Mazeland
d2d287fbc4 Update docs 2012-12-27 21:58:54 +01:00
Santhosh Thottingal
b34cbbe9d2 Limit the grid to 'grid' class 
Change-Id: I60dd826ddee0861c05bc6b0cadc8bdc1eb3a6488
 2012-11-28 14:59:56 +05:30
Santhosh Thottingal
d0ef38c1e2 Donot close when clicked outside 
Change-Id: Ib94423e8c26f69cdba460e21e9bcaee1a436e187
 2012-11-21 17:33:16 +05:30
Santhosh Thottingal
b3a3f48c3b On show hide any other ULS menus visible 2012-11-21 17:09:12 +05:30
Amir E. Aharoni
025e452560 Remove superfluous element names where ID is specified 2012-11-19 18:56:35 +02:00
pginer
27039e1141 Fixes CSSLint issues for jquery.uls.css 
CSS adjustments and JS modifications (adding classes to HTML elemnts)
to solve issues reported by CSS Lint when validating jquery.uls.css
 2012-11-19 17:26:34 +01:00
Amir E. Aharoni
c9a072934c Make clicking the trigger show and hide the ULS 
Bugzilla:
https://bugzilla.wikimedia.org/show_bug.cgi?id=41768
 2012-11-16 19:17:54 +02:00
Amir E. Aharoni
f80683b1d8 Make clicking outside the ULS close the ULS 
Reported in Bugzilla:
https://bugzilla.wikimedia.org/show_bug.cgi?id=41768
 2012-11-16 18:52:30 +02:00
Amir E. Aharoni
ba6a1e5eec Spelling of event name 2012-11-16 14:09:45 +02:00
Amir E. Aharoni
15d98ee586 Whitespace 2012-11-16 14:08:03 +02:00
Amir E. Aharoni
05e4de4020 Renamed 'that' to 'uls' 2012-11-16 14:00:25 +02:00
Amir E. Aharoni
da2244279e Whitespace and quotes 2012-11-16 13:52:32 +02:00
Santhosh Thottingal
8c3b61b1a1 Fix issue #32 - Clicking a region on map sets focus in search bar; onscreen keyboard covers list 
Change-Id: I15703614b5fdb2201f7dcbfd47a5095e033032f3
 2012-11-13 14:22:10 +05:30
Santhosh Thottingal
cff31e7abb Fix issue #31 - Add onCancel callback 
Change-Id: I207b60846a899912dcc5f79f92e9b1ad75e525a3
 2012-11-10 17:52:44 +05:30
Santhosh Thottingal
642dd3c8cc Remove deprecated $.browser 
Fixes issue #33

Change-Id: Idda5d77293baedf8d93b70a146a545ff6986aaa5
 2012-11-10 17:09:57 +05:30
Santhosh Thottingal
0be1e38d14 Fix issue #24 - Search results replaced with full list when scrolling 
Change-Id: Iba3a798c9b4980943aded1ed145081fecc0367e3
 2012-11-08 15:43:36 +05:30
Santhosh Thottingal
06384a02e4 Remove unused variable 
Change-Id: I41154e6c79b215945ccefe729d2a50b38d67f5c2
 2012-11-08 15:04:06 +05:30
Brion Vibber
5ec59b9874 typo fix in comment 2012-11-06 18:02:29 +05:30
Santhosh Thottingal
642668d0ae Introduce lazyload option with default value true. 
This can be set false when language list is very small.

Change-Id: I024f01a2a62f0d0def553e2d6f7a3fdcce1a7968
 2012-10-26 10:53:13 +05:30
Santhosh Thottingal
27b8babfa9 Use lazy loading of regions only where language list is big 2012-10-26 10:29:21 +05:30