Commit Graph

116 Commits

Author SHA1 Message Date
Santhosh Thottingal
9599ed7d26 Fix the jQuery migration warnings
Remove the spaces in the beginning of html template strings.
$( html ) require html to start with  '<'

See https://bugzilla.wikimedia.org/show_bug.cgi?id=65400

Change-Id: I93eaf41390ab72fcae1b8d4015585bc4f82e6f8a
2014-05-18 10:20:07 +05:30
Niklas Laxström
78e9b83c6b Make ULS language selector appear faster after clicking trigger
* Removed unused class end.
* Class uls-lcd-region-section was used in two different elements,
  retained it on the outer one.
* Build a list of languages per region, once done render the regions at once.
* Use direct dom manipulation in hot spots.
* Use shorter selectors like children instead of find and dropping the tag name.
* Fixed mismatch when there were no results and when the message was shown.
* Less flickering by not hiding or showing regions unnecessary
* Cache the common languages "quicklist"
* Added itemsPerColumn as an option

Reduces time used to show language selector after clicking the trigger on my
machine from about 1.8s to about 380 ms (JS execution times, actual times are
about the same but little bigger. The actual rendering is now less than 100ms,
the rest is other setup overheard and $.fn.scrollIntoView which can take many
hundreds of milliseconds.
2013-12-20 10:31:04 +00:00
Niklas Laxström
9d77cfb76f Fix typo 2013-11-19 11:16:14 +00:00
Santhosh Thottingal
623cdb605a Validate whether the language from API is known while trying to display
See https://bugzilla.wikimedia.org/show_bug.cgi?id=54725

Change-Id: Ie77f7cd02d37338a6b65db653c2ba3b35906dac0
2013-11-15 15:15:00 +05:30
Santhosh Thottingal
49497d7078 Avoid overriding grid css for language list
Change-Id: I7606c5af716f2094bc1766a95123a68413634c91
2013-11-05 19:49:38 +05:30
Santhosh Thottingal
5444e17727 Avoid 'recalculate style' by conditionally change classes while scrolling
Change-Id: I71b42f9f974a1367700283ad55013e9e6a036827
2013-11-01 11:08:15 +05:30
Santhosh Thottingal
a985d33d4b Use attr and prop consistently
Change-Id: If650d07686cafb6fceba60186843b5599404846c
2013-11-01 10:47:16 +05:30
Santhosh Thottingal
9ae403b671 Remove unnecessary object instance
Change-Id: I078a3a107d154bbcba7e1d49cbd6470b026ff869
2013-11-01 10:45:46 +05:30
Santhosh Thottingal
522b14fb23 Use text() instead of html() to set language names
Change-Id: I1374ac3ed9273302ea268596918a72c6b7a48579
2013-11-01 10:33:36 +05:30
Santhosh Thottingal
c5b11eabc9 Merge pull request #106 from siebrand/3
Update code formatting
2013-10-23 06:38:37 -07:00
Santhosh Thottingal
e83494cab1 Formatting fixes
Change-Id: I75173f09527f84419d1b807e9e33ff673e0f5d1c
2013-10-17 14:50:09 +05:30
Santhosh Thottingal
e54d85a124 Use Autonym font for autonyms
Change-Id: I5224cd020a6c6ba4f52f2be3a318216111b39394
2013-09-15 14:48:36 -07:00
Siebrand Mazeland
078448a659 Update code formatting
Changes suggested by CodeSniffer.
2013-08-02 15:38:12 +02:00
MatmaRex
8a1e3eb18e Remove lazyload functionality entirely
It was merely a stopgap solution to the problem of the dialog taking
forever to load. With that problem solved all of this awful code is no
longer needed.
2013-06-27 16:31:50 +05:30
MatmaRex
8341bb8e21 Disable lazyload for language list
The loading should be fast enough now after Id9397631 is merged,
taking no more than a second or two to render entirely. We could
consider showing a spinner while it's loading, but it doesn't seem
necessary.

This makes bug 39923 invalid.
2013-06-27 16:30:17 +05:30
Santhosh Thottingal
7c47112ae6 Fix: IE 8 not displaying the section titles for language lists
Changed the way those elements were constructed using jQuery

Change-Id: Ib2b7f454dd0cc1ff38342cf7cc2c6c73a4796c6c
2013-06-12 10:55:32 +05:30
Santhosh Thottingal
05e34d5dfa Fix two js error possibilities
Change-Id: I92ed487e7b5c70ef7851575eec676276e1ea905b
2013-06-10 14:33:17 +05:30
Amir E. Aharoni
62cab27eb2 Leave only one var statement per scope 2013-04-22 14:40:12 +03:00
Amir E. Aharoni
31cd276019 JSHint cleanup 2013-01-13 23:20:05 +02:00
Santhosh Thottingal
ca18edd0dd Merge pull request #63 from amire80/bug_43568
Render every region only once
2013-01-07 06:44:04 -08:00
Santhosh Thottingal
0e61876af5 Merge branch 'extra_languages' of git://github.com/amire80/jquery.uls into amire80-extra_languages
Conflicts:
	src/jquery.uls.data.js
	src/jquery.uls.data.utils.js

Change-Id: I9c321891707b0d68328f4e4c8be1bd451794072d
2013-01-07 15:45:48 +05:30
Amir E. Aharoni
13473c9f7a Render every region only once
Fixes bug
https://bugzilla.wikimedia.org/show_bug.cgi?id=43568
2013-01-04 08:31:20 +02:00
Amir E. Aharoni
1f91a4c40c Whitespace 2013-01-02 18:28:14 +02:00
Amir E. Aharoni
829c827483 Adding a special region
This is supposed to allow adding special languages.

This region's section is hidden by default and can be enabled by
passing different options to the lcd object.
2013-01-02 12:58:29 +02:00
Siebrand Mazeland
d2d287fbc4 Update docs 2012-12-27 21:58:54 +01:00
Santhosh Thottingal
8c54381e58 Change double quotes to single quotes
Change-Id: I4684a4bc4ac26fffba7310891106d254e893dd63
2012-12-24 16:29:14 +05:30
Amir E. Aharoni
7a04c3c6e0 Rename "that = this" to meaningful names 2012-11-29 10:40:24 +02:00
pginer
6fa03963f1 Fixes CSSLint issues for jquery.uls.lcd.css
CSS adjustments and JS modifications (adding classes to HTML elements)
to solve issues reported by CSS Lint when validating jquery.uls.lcd.css

Change-Id: Ic604984b1a677f0e18796d6ce131736d6b9d6c3a
2012-11-19 20:13:12 +05:30
Santhosh Thottingal
641218f624 Remove href attributes
People like to middle click -
https://bugzilla.wikimedia.org/show_bug.cgi?id=41988
2012-11-14 20:11:24 +05:30
Santhosh Thottingal
0be1e38d14 Fix issue #24 - Search results replaced with full list when scrolling
Change-Id: Iba3a798c9b4980943aded1ed145081fecc0367e3
2012-11-08 15:43:36 +05:30
Santhosh Thottingal
5e66a8a163 Fixed issue #27 - Clicking on language links goes to "#"
Change-Id: I8f675a00dc697540df4e011cdb58e1b423b9f191
2012-11-08 12:14:57 +05:30
Santhosh Thottingal
642668d0ae Introduce lazyload option with default value true.
This can be set false when language list is very small.

Change-Id: I024f01a2a62f0d0def553e2d6f7a3fdcce1a7968
2012-10-26 10:53:13 +05:30
Santhosh Thottingal
c883c3a774 Avoid jumping to WW while scrolling up.
Correct the precision of scroll top by taking padding into account.
Fixes https://bugzilla.wikimedia.org/show_bug.cgi?id=39224

Change-Id: I988e9a09018bf2d5c27f11d21947e036c79f56b9
2012-10-24 18:18:18 +05:30
Amir E. Aharoni
77e62c99a5 Changed $( this ) into meaningful variables 2012-10-08 17:34:35 +02:00
Amir E. Aharoni
f14073a21a Rename the variable that to lcd 2012-10-08 17:22:01 +02:00
Amir E. Aharoni
2e22c5c550 Initial whitespace cleanup 2012-10-08 17:04:05 +02:00
Amir E. Aharoni
c40caf4a29 Update the remaining calls to deprecated functions 2012-10-08 08:27:50 +02:00
Amir E. Aharoni
5e16abf26d .autonym -> .getAutonym 2012-10-08 08:13:34 +02:00
Amir E. Aharoni
7d48ec230b .regions -> .getRegions 2012-10-08 08:13:34 +02:00
Santhosh Thottingal
61649c567b Merge pull request #4 from amire80/master
Starting RTL support (copied from Gerrit, except the tests)
2012-09-24 16:57:17 -07:00
amire80
7f16137efc Fix whitespace 2012-09-24 16:51:03 -07:00
amire80
f9e3e148e3 Add basic support for dir and lang attributes for autonyms
Added a util function for getting the language's direction.

Added lang and dir attributes for every language item in the list.
2012-09-24 16:34:06 -07:00
Santhosh Thottingal
9d988dbafe Scroll improvements
* Load the next region when scroll reached half of the current
  region
* Fix the scroll sync with region highlight in both up and down
  scrolls
* Address Bug 39923 - Make scroll to next region more fluent
2012-09-23 21:35:37 -07:00
Santhosh Thottingal
0781f022dd Internationalize ULS
* internationalize ULS when jquery.i18n is present. Otherwise use the
fallback English interface
* Example with and without i18n
* Message files for few languages
2012-09-21 22:24:06 -07:00
Santhosh Thottingal
0747e74365 User region names instead of region codes
* Till i18n is in place, use a workaround to show region names in
  English

Change-Id: I6e14ab67600ad32263f04eb0aa6b931177425e5a
2012-09-09 07:50:16 +00:00
Santhosh Thottingal
badd5c95ac Fix the broken region links in 'noresults' screen.
It was commented out in some previous commits.
Also correct the region code of America from NA to AM

Change-Id: I6cec2560393134de1190291e1f49bc0ac4280af0
2012-09-05 18:15:45 +05:30
Santhosh Thottingal
298c91a68f Misc jshint fixes
* Move the invocation into the parens that contain the function.
* unescaped regex
* Do not wrap function literals in parens unless they are to be
  immediately invoked.

Change-Id: Ib3360f88fb7674af0e857d8a84a91fdac1fd8487
2012-09-04 16:02:28 +05:30
Siebrand
98a64d7dbb Merge "Fix Bug 39921 - World wide languages need not be repeated in all regions." 2012-09-03 16:58:27 +00:00
Santhosh Thottingal
f837ed904a Fix Bug 39922 - The "No results found" view lacks suggested languages
noresultsview is part of uls.lcd now, moved the html template too.

Change-Id: I9aee0ab1b62e61c3ec0e2c89f7d07b7a4432ef33
2012-09-03 19:31:41 +05:30
Santhosh Thottingal
f37571a250 Fix Bug 39921 - World wide languages need not be repeated in all regions.
Change-Id: I4470a2a7976df17f6f0f8f97d15ce12163cc3c27
2012-09-03 18:10:31 +05:30