From 349589fc1f9867671adcc51c02b78c4da41caacb Mon Sep 17 00:00:00 2001 From: "Amir E. Aharoni" Date: Mon, 8 Mar 2021 14:25:27 +0200 Subject: [PATCH] Consistently use parentheses in Chinese-script autonyms (#148) Addresses #141. Co-authored-by: Kartik Mistry --- data/langdb.yaml | 4 ++-- data/language-data.json | 4 ++-- tests/js/index.js | 11 ++++++++++- 3 files changed, 14 insertions(+), 5 deletions(-) diff --git a/data/langdb.yaml b/data/langdb.yaml index 524f4c3..b5d3e99 100644 --- a/data/langdb.yaml +++ b/data/langdb.yaml @@ -104,7 +104,7 @@ languages: # FIXME cdo will be modified later to split to Latin and Chinese more cleanly cdo: [Latn, [AS], Mìng-dĕ̤ng-ngṳ̄] cdo-latn: [Latn, [AS], Mìng-dĕ̤ng-ngṳ̄ Bàng-uâ-cê] - cdo-hani: [Hani, [AS], 閩東語漢字] + cdo-hani: [Hani, [AS], 閩東語(漢字)] ce: [Cyrl, [EU], нохчийн] ceb: [Latn, [AS], Cebuano] ch: [Latn, [PA], Chamoru] @@ -121,7 +121,7 @@ languages: chy: [Latn, [AM], Tsetsêhestâhese] ciw: [Latn, [AM], Ojibwemowin] cjy: [cjy-hant] - cjy-hans: [Hans, [AS], 晋语(简化字)] + cjy-hans: [Hans, [AS], 晋语(简化字)] cjy-hant: [Hant, [AS], 晉語] ckb: [Arab, [ME], کوردی] ckt: [Cyrl, [AS], ԓыгъоравэтԓьэн] diff --git a/data/language-data.json b/data/language-data.json index 1a20a4a..d0c218c 100644 --- a/data/language-data.json +++ b/data/language-data.json @@ -652,7 +652,7 @@ [ "AS" ], - "閩東語漢字" + "閩東語(漢字)" ], "ce": [ "Cyrl", @@ -721,7 +721,7 @@ [ "AS" ], - "晋语(简化字)" + "晋语(简化字)" ], "cjy-hant": [ "Hant", diff --git a/tests/js/index.js b/tests/js/index.js index d95d1dd..d391133 100644 --- a/tests/js/index.js +++ b/tests/js/index.js @@ -110,7 +110,8 @@ describe( 'languagedata', function () { } ); it( 'autonyms', function () { - var autonyms; + var autonyms, chineseScriptLanguages, i, + languagesWithParentheses = []; // Add a language in run time. // This is done early to make sure that it doesn't break other functions. languageData.addLanguage( 'qqq', { @@ -130,6 +131,14 @@ describe( 'languagedata', function () { assert.deepEqual( [ 'de', 'fi', 'gn', 'hu' ].sort( languageData.sortByAutonym ), [ 'gn', 'de', 'hu', 'fi' ], 'Languages are correctly sorted by autonym' ); + + chineseScriptLanguages = languageData.getLanguagesInScripts( [ 'Hans', 'Hant', 'Hani' ] ); + for ( i = 0; i < chineseScriptLanguages.length; ++i ) { + if ( languageData.getAutonym( chineseScriptLanguages[i] ).match( /[()]/ ) ) { + languagesWithParentheses.push( chineseScriptLanguages[i] ); + } + } + assert.deepEqual( languagesWithParentheses, [], 'Chinese script languages\' autonyms don\'t have Western parentheses' ); } ); it( 'regions and groups', function () { var languagesAM;