From 022efbfa8a96902e8f01194e415b5065f05565ac Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=C5=BDeljko=20Filipin?= Date: Wed, 18 Nov 2015 12:02:38 +0100 Subject: [PATCH] Fixed Style/SpaceInsideParens RuboCop offense Bug: 117989 Change-Id: I3418ad3b0265903171e3ee7603eeea22569387b4 --- .rubocop_todo.yml | 8 -------- tests/browser/features/step_definitions/ime_steps.rb | 2 +- tests/browser/features/support/pages/ime_page.rb | 4 ++-- tests/browser/features/support/pages/panel_page.rb | 8 ++++---- 4 files changed, 7 insertions(+), 15 deletions(-) diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml index 4f84a8d9..3356981b 100644 --- a/.rubocop_todo.yml +++ b/.rubocop_todo.yml @@ -40,11 +40,3 @@ Style/HashSyntax: # Configuration parameters: EnforcedStyleForEmptyBraces, SupportedStyles. Style/SpaceInsideHashLiteralBraces: EnforcedStyle: no_space - -# Offense count: 10 -# Cop supports --auto-correct. -Style/SpaceInsideParens: - Exclude: - - 'tests/browser/features/step_definitions/ime_steps.rb' - - 'tests/browser/features/support/pages/ime_page.rb' - - 'tests/browser/features/support/pages/panel_page.rb' diff --git a/tests/browser/features/step_definitions/ime_steps.rb b/tests/browser/features/step_definitions/ime_steps.rb index c6cd97fe..98c9f4b0 100644 --- a/tests/browser/features/step_definitions/ime_steps.rb +++ b/tests/browser/features/step_definitions/ime_steps.rb @@ -3,7 +3,7 @@ Given(/^I am on a wiki in Kotava language$/) do step 'I am at the main page' # Fake a Kotava Wiki - browser.execute_script( "mw.config.set( 'wgContentLanguage', 'avk' )" ) + browser.execute_script("mw.config.set( 'wgContentLanguage', 'avk' )") end When(/^I click on an input box$/) do diff --git a/tests/browser/features/support/pages/ime_page.rb b/tests/browser/features/support/pages/ime_page.rb index 7f2cc817..c3ca7098 100644 --- a/tests/browser/features/support/pages/ime_page.rb +++ b/tests/browser/features/support/pages/ime_page.rb @@ -15,11 +15,11 @@ class IMEPage text_field(:search_input, id: 'searchInput') def ime_input_method_menu_onscreen? - browser.execute_script( " + browser.execute_script(" var $selectorMenu = $( '.imeselector-menu' ), menuLeft = $selectorMenu.offset().left, menuRight = menuLeft + $selectorMenu.width(); - return ( menuLeft >= 0 && menuRight <= $( window ).width() );" ) + return ( menuLeft >= 0 && menuRight <= $( window ).width() );") end end diff --git a/tests/browser/features/support/pages/panel_page.rb b/tests/browser/features/support/pages/panel_page.rb index 6835cce5..820b279d 100644 --- a/tests/browser/features/support/pages/panel_page.rb +++ b/tests/browser/features/support/pages/panel_page.rb @@ -59,22 +59,22 @@ class PanelPage end def uls_onscreen? - browser.execute_script( " + browser.execute_script(" var $menu = $( '.uls-menu' ), $window = $( window ), top = $menu.offset().top, viewportTop = $window.scrollTop(), viewportBottom = $window.scrollTop() + $window.height(); - return ( top < viewportBottom && top >= viewportTop )" ) + return ( top < viewportBottom && top >= viewportTop )") end def webfonts_library_loaded - browser.execute_script( "return ( $( 'body' ).data( 'webfonts' ) !== undefined )" ) + browser.execute_script("return ( $( 'body' ).data( 'webfonts' ) !== undefined )") end private def font(selector) - browser.execute_script( "return $( '#{selector}' ).css( 'font-family' );" ) + browser.execute_script("return $( '#{selector}' ).css( 'font-family' );") end end