Simplify code using .one

Change-Id: I84fb5e0ade474738ff6a05c2304de351a2476186

resources/js/ext.uls.interface.js

@@ -87,16 +87,16 @@
 		var $displaySettings = displaySettings();
 
 		uls.$menu.find( '#uls-settings-block' ).append( $displaySettings );
-		$displaySettings.on( 'click', function () {
+
-			var languagesettings = $displaySettings.data( 'languagesettings' ),
+		// Initialize the trigger
-				displaySettingsOptions = {
+		$displaySettings.one( 'click', function () {
+			var displaySettingsOptions = {
 					defaultModule: 'display'
 				},
 				ulsPosition = mw.config.get( 'wgULSPosition' ),
 				anonMode = ( mw.user.isAnon() &&
 					!mw.config.get( 'wgULSAnonCanChangeLanguage' ) );
 
-			if ( !languagesettings ) {
 			// If the ULS trigger is shown in the top personal menu,
 			// closing the display settings must show the main ULS
 			// languages list, unless we are in anon mode and thus
@@ -108,7 +108,10 @@
 			}
 			$.extend( displaySettingsOptions, uls.position() );
 			$displaySettings.languagesettings( displaySettingsOptions ).click();
-			}
+		} );
+
+		// On every click
+		$displaySettings.on( 'click', function () {
 			mw.hook( 'mw.uls.settings.open' ).fire( 'uls' );
 			uls.hide();
 		} );
@@ -123,11 +126,11 @@
 		var $inputSettings = inputSettings();
 
 		uls.$menu.find( '#uls-settings-block' ).append( $inputSettings );
-		$inputSettings.on( 'click', function () {
-			var position = uls.position(),
-				languagesettings = $inputSettings.data( 'languagesettings' );
 
-			if ( !languagesettings ) {
+		// Initialize the trigger
+		$inputSettings.one( 'click', function () {
+			var position = uls.position();
+
 			$inputSettings.languagesettings( {
 				defaultModule: 'input',
 				onClose: function () {
@@ -136,8 +139,10 @@
 				top: position.top,
 				left: position.left
 			} ).click();
-			}
+		} );
 
+		// On every click
+		$inputSettings.on( 'click', function () {
 			mw.hook( 'mw.uls.settings.open' ).fire( 'uls' );
 			uls.hide();
 		} );