bryce/mediawiki-extensions-UniversalLanguageSelector
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Simplify code using .one

Browse Source 
Change-Id: I84fb5e0ade474738ff6a05c2304de351a2476186
This commit is contained in:
Niklas Laxström
2016-05-30 17:19:21 +02:00
committed by Santhosh Thottingal
parent 791cefeec6
commit 0784540c40
1 changed files with 34 additions and 29 deletions
Download Patch File Download Diff File Expand all files Collapse all files

63
resources/js/ext.uls.interface.js
View File

@@ -87,28 +87,31 @@
var $displaySettings = displaySettings(); var $displaySettings = displaySettings();
uls.$menu.find( '#uls-settings-block' ).append( $displaySettings ); uls.$menu.find( '#uls-settings-block' ).append( $displaySettings );
$displaySettings.on( 'click', function () {
var languagesettings = $displaySettings.data( 'languagesettings' ), // Initialize the trigger
displaySettingsOptions = { $displaySettings.one( 'click', function () {
var displaySettingsOptions = {
defaultModule: 'display' defaultModule: 'display'
}, },
ulsPosition = mw.config.get( 'wgULSPosition' ), ulsPosition = mw.config.get( 'wgULSPosition' ),
anonMode = ( mw.user.isAnon() && anonMode = ( mw.user.isAnon() &&
!mw.config.get( 'wgULSAnonCanChangeLanguage' ) ); !mw.config.get( 'wgULSAnonCanChangeLanguage' ) );
if ( !languagesettings ) { // If the ULS trigger is shown in the top personal menu,
// If the ULS trigger is shown in the top personal menu, // closing the display settings must show the main ULS
// closing the display settings must show the main ULS // languages list, unless we are in anon mode and thus
// languages list, unless we are in anon mode and thus // cannot show the language list
// cannot show the language list if ( ulsPosition === 'personal' && !anonMode ) {
if ( ulsPosition === 'personal' && !anonMode ) { displaySettingsOptions.onClose = function () {
displaySettingsOptions.onClose = function () { uls.show();
uls.show(); };
};
}
$.extend( displaySettingsOptions, uls.position() );
$displaySettings.languagesettings( displaySettingsOptions ).click();
} }
$.extend( displaySettingsOptions, uls.position() );
$displaySettings.languagesettings( displaySettingsOptions ).click();
} );
// On every click
$displaySettings.on( 'click', function () {
mw.hook( 'mw.uls.settings.open' ).fire( 'uls' ); mw.hook( 'mw.uls.settings.open' ).fire( 'uls' );
uls.hide(); uls.hide();
} ); } );
@@ -123,21 +126,23 @@
var $inputSettings = inputSettings(); var $inputSettings = inputSettings();
uls.$menu.find( '#uls-settings-block' ).append( $inputSettings ); uls.$menu.find( '#uls-settings-block' ).append( $inputSettings );
// Initialize the trigger
$inputSettings.one( 'click', function () {
var position = uls.position();
$inputSettings.languagesettings( {
defaultModule: 'input',
onClose: function () {
uls.show();
},
top: position.top,
left: position.left
} ).click();
} );
// On every click
$inputSettings.on( 'click', function () { $inputSettings.on( 'click', function () {
var position = uls.position(),
languagesettings = $inputSettings.data( 'languagesettings' );
if ( !languagesettings ) {
$inputSettings.languagesettings( {
defaultModule: 'input',
onClose: function () {
uls.show();
},
top: position.top,
left: position.left
} ).click();
}
mw.hook( 'mw.uls.settings.open' ).fire( 'uls' ); mw.hook( 'mw.uls.settings.open' ).fire( 'uls' );
uls.hide(); uls.hide();
} ); } );