From 62939949b426580901c6e62a1ce199f2fca00f43 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Niklas=20Laxstr=C3=B6m?= Date: Sat, 8 Mar 2014 10:55:09 +0000 Subject: [PATCH] Use preventDefault instead of stopPropagation Change-Id: I9c2da14b94348cec39e6a9a1571b22de39e437f0 --- resources/js/ext.uls.interface.js | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/resources/js/ext.uls.interface.js b/resources/js/ext.uls.interface.js index f1e50d91..c1275479 100644 --- a/resources/js/ext.uls.interface.js +++ b/resources/js/ext.uls.interface.js @@ -397,6 +397,8 @@ $ulsTrigger.on( 'click', function ( e, eventParams ) { var languagesettings = $ulsTrigger.data( 'languagesettings' ); + e.preventDefault(); + if ( languagesettings ) { if ( !languagesettings.shown ) { mw.hook( 'mw.uls.settings.open' ).fire( eventParams && eventParams.source || 'personal' ); @@ -407,14 +409,14 @@ $ulsTrigger.trigger( 'click', eventParams ); } ); - - e.stopPropagation(); } } ); } else { $ulsTrigger.on( 'click', function ( e, eventParams ) { var uls = $ulsTrigger.data( 'uls' ); + e.preventDefault(); + if ( uls ) { if ( !uls.shown ) { mw.hook( 'mw.uls.settings.open' ).fire( eventParams && eventParams.source || 'personal' ); @@ -445,8 +447,6 @@ window.setTimeout( function () { $ulsTrigger.trigger( 'click', eventParams ); }, 0 ); - - e.stopPropagation(); } ); } } );