From 0c53c38304c5a9081a01b27a7e68f57c8348596c Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Niklas=20Laxstr=C3=B6m?= Date: Tue, 4 Jun 2013 09:19:11 +0000 Subject: [PATCH] Hide ULS trigger from unsupported browsers For position=sidebar, the dummy "in other languages" section is visible in the same manner as it is to browsers without JavaScript. Bug: 49028 Change-Id: I931a2e904b37c754f63bfe5feb2d98bfe6c2747b --- resources/css/ext.uls.nojs.css | 2 +- resources/js/ext.uls.init.js | 12 ++++++++---- 2 files changed, 9 insertions(+), 5 deletions(-) diff --git a/resources/css/ext.uls.nojs.css b/resources/css/ext.uls.nojs.css index d902d27d..99ec7e5d 100644 --- a/resources/css/ext.uls.nojs.css +++ b/resources/css/ext.uls.nojs.css @@ -1,4 +1,4 @@ /* Don't show it to users who disabled JS */ .client-nojs #pt-uls { - visibility: hidden; + display: none; } diff --git a/resources/js/ext.uls.init.js b/resources/js/ext.uls.init.js index 95c48384..ed861de6 100644 --- a/resources/js/ext.uls.init.js +++ b/resources/js/ext.uls.init.js @@ -112,10 +112,13 @@ * @return boolean */ mw.uls.isBrowserSupported = function () { - // boxModel is not supported in IE versions under 8. - // We are checking for boxModel here because without that features - // our grid system fails and it makes the ULS non-functional. - return $.support.boxModel; + // Blacklist Grade B browsers IE 6, 7 and IE60-IE79 + var ua = navigator.userAgent; + if ( /MSIE [67]/i.test( ua ) ) { + return false; + } + + return true; }; /** @@ -160,6 +163,7 @@ $( document ).ready( function () { if ( !mw.uls.isBrowserSupported() ) { + $( '#pt-uls' ).hide(); return; }