From 0f0732f86580d8f1a1a8f937107c24e45de09a0e Mon Sep 17 00:00:00 2001 From: Reedy Date: Sun, 19 Aug 2012 01:19:46 +0100 Subject: [PATCH] Fixup a few minor documentation issues Added some newlines Left a FIXME in LanguageNameIndexer.php Losslessly compressed display.png Change-Id: I884b423d3812ddb964a6a70f75a6331a73371165 --- UniversalLanguageSelector.hooks.php | 10 ++++++++-- data/LanguageNameIndexer.php | 2 +- data/LanguageNameSearch.php | 4 ++++ resources/images/display.png | Bin 1183 -> 1041 bytes 4 files changed, 13 insertions(+), 3 deletions(-) diff --git a/UniversalLanguageSelector.hooks.php b/UniversalLanguageSelector.hooks.php index ca530614..16487ca4 100644 --- a/UniversalLanguageSelector.hooks.php +++ b/UniversalLanguageSelector.hooks.php @@ -32,10 +32,11 @@ class UniversalLanguageSelectorHooks { $out->addModules( 'ext.uls.displaysettings' ); return true; } + /** * ResourceLoaderTestModules hook handler. - * @param $testModules: array of javascript testing modules. 'qunit' is fed using tests/qunit/QUnitTestResources.php. - * @param $resourceLoader object + * @param $testModules array of javascript testing modules. 'qunit' is fed using tests/qunit/QUnitTestResources.php. + * @param $resourceLoader ResourceLoader * @return bool */ public static function addTestModules( array &$testModules, ResourceLoader &$resourceLoader ) { @@ -47,6 +48,7 @@ class UniversalLanguageSelectorHooks { ); return true; } + /** * Add some tabs for navigation for users who do not use Ajax interface. * Hooks: SkinTemplateNavigation, SkinTemplateTabs @@ -93,6 +95,7 @@ class UniversalLanguageSelectorHooks { $code = RequestContext::sanitizeLangCode( $code ); return true; } + /** * Hook: ResourceLoaderGetConfigVars * @param $vars Array @@ -107,6 +110,9 @@ class UniversalLanguageSelectorHooks { /** * Add the template for the ULS to the body. * Hooks: SkinAfterContent + * @param $data string + * @param $skin Skin + * @return bool * TODO: move to JavaScript side * TODO: hardcoded English */ diff --git a/data/LanguageNameIndexer.php b/data/LanguageNameIndexer.php index a2530830..7ef08536 100644 --- a/data/LanguageNameIndexer.php +++ b/data/LanguageNameIndexer.php @@ -39,7 +39,7 @@ class LanguageNameIndexer extends Maintenance { foreach ( $languages as $code => $name ) { $all[$code][strtolower( $name )] = true; $langnames = LanguageNames::getNames( $code, 0, 2 ); - foreach ( $langnames as $code => $name ) { + foreach ( $langnames as $code => $name ) { // FIXME: Variable pollution $all[$code][] = strtolower( $name ); } } diff --git a/data/LanguageNameSearch.php b/data/LanguageNameSearch.php index 8d43f2bd..49196e7b 100644 --- a/data/LanguageNameSearch.php +++ b/data/LanguageNameSearch.php @@ -19,9 +19,11 @@ */ class LanguageNameSearch { static $languagenames; + public static function init() { self::$languagenames = unserialize( file_get_contents( __DIR__ . '/langnames.ser' ) ); } + public static function search( $searchKey, $typos = 0 ) { if ( self::$languagenames === null ) { self::init(); @@ -61,6 +63,7 @@ class LanguageNameSearch { /** * Get the code point of first letter of string * + * @param $str string * @return integer Code point of first letter of string */ static function getCodepoint( $str ) { @@ -84,6 +87,7 @@ class LanguageNameSearch { } } } + /** * Calculate the Levenshtein distance between two strings * @param $str1 diff --git a/resources/images/display.png b/resources/images/display.png index 6638099eb36f7665277d3881df73454509bd4cce..92c802892ad88336e4f132e738360cb9c0652829 100644 GIT binary patch literal 1041 zcmeAS@N?(olHy`uVBq!ia0vp^+91rq3?#2LH-2JZU|b&H6XN>+|9@v^XBQV2APHeW z*iKGP5D^Cl2OuLfG!#f08yf>t6y)zuZK z7bpcZ1fl@QaC38m8{+Qn4&egD;Z{KOLbL!$AaHbaglI=L3fT}K8|ZSlr4Yr)8i8zx z8lX`SHe3zRkq|cA#<6 zK8EOj?XkB?4yiIsyj}IjLFZe-Cn4Dt?-=sb4jepjwm;7A@cW+0ozGsnO_5wLk`ZCx z_&QVj($6!t66&RkAG>NwU8#%g+Ea6kVPWI--7+Cl-?F>U-pjmJl*5~$NMWAJ<~Q8V z9rrF*?YcQW1Cca%jG?p+sBYeqSqJqr`gw&AH8~X=!Ou zK+N|4#kmxsvmRyOo8%f41#&Q~!0n$OPk}TY@GJzq(N?Lwib;(nLeW~~cqtCznmW6qWiTpn)K;I~P0j`>L? z--y|VRZB}H%U(up(KvMcmiCXp^|#{n?kq4bT)pFa#~NJ)FYmkVO~)GBjkXFOW1Ay7 z|D)l&ikF+8PkX~1{~}d6Ilfac>fD#88t3~~IR|!sKi2T0G5Ma6yzTOtXY2Dzef}vG zY-VTiDNNNmuq4s`Y{t*t%-dLLb(L=GT{I)%P_k$IBYG3cUNQ223yvp00i_>zopr0508)jsO4v delta 1174 zcmV;H1Zn$`2%ia%8Gi-<007}#alilo00DDSM?wIu&K&6g000JJOGiWi{{a60|De66 zlK=n!32;bRa{vGmoB#k4oB^`d|8oEU00(qQO+^RX2L%l|5kNX*%>V!dA4x<(R9M69 znO$fcRTRg6=gwrJH`p%wpjc2V+6S?USVSv~5O)KuVvwTMhkrt1tQExvLHp=OK=e(j zLLb`r5XBZ^=tIzlm4s+E(Dp$PsZ?#LQcBv2tVzpeo5|cczDy;o`Eqw^6Uc#KhkN(V z{oQl_bM85es4A<)46Df2V6T-)u~>X$wZQtSdUQ<&Yp{*mIiLibT@A2%MP!?*zP{37 z|IFv}M^u%mseh@jfQu^`w!c!TL_nC!*l|@onIy@* zs`_wU-+$A-@8^>w`9Va!UoIo?2XHY-lAF^-PiGPhRP}&}(9+U!$vL;ZzJF$B#(17b zk|cd1vSpq}RDr|5AaUA--e}AD`t=`zy*0u%Ms;c(`Ex@3)cCc2f zy{oG4H04=U{oM1sE5NoWivE=gl*?tTwHRZ1q9~dGz684Fz&_!5-UU^C+gkgUs@Bi@ z4XUB2PN!$mjFh zMWh{gLsfSKL2yqT$LEU0;zv!xipY`6mwzt@xm<21aLY1JxlZTY-L+b6HmxL3)qdai z_nbL%MpgA&;6vZ{zlr1cAc4g`=4>;<1-mA{J z6Ai&;^|hv0EH1PtMn*