Fixing "Common language" functionality

If was broken in
Icda498f676d1d3ddaefad75fd9212150f6966666

Bug: 53035
Change-Id: Ida29364073b07b985050565cacc6634c134f8d6c
This commit is contained in:
Amir E. Aharoni
2013-08-19 16:27:54 +03:00
parent 7649b47f5c
commit 0f34b4d934

View File

@@ -400,16 +400,17 @@
} ); } );
} else { } else {
$ulsTrigger.on( 'click', function ( e, eventParams ) { $ulsTrigger.on( 'click', function ( e, eventParams ) {
var uls = $ulsTrigger.data( 'uls' ), var uls = $ulsTrigger.data( 'uls' );
ulsOptions;
if ( uls ) { if ( uls ) {
if ( !uls.shown ) { if ( !uls.shown ) {
mw.hook( 'mw.uls.settings.open' ).fire( eventParams && eventParams.source || 'personal' ); mw.hook( 'mw.uls.settings.open' ).fire( eventParams && eventParams.source || 'personal' );
} }
} else { } else {
// ULS options that are common to all modes of showing $ulsTrigger.uls( {
ulsOptions = { quickList: function () {
return mw.uls.getFrequentLanguageList();
},
onReady: function () { onReady: function () {
var uls = this; var uls = this;
mw.loader.using( mw.uls.languageSettingsModules, function () { mw.loader.using( mw.uls.languageSettingsModules, function () {
@@ -420,9 +421,7 @@
onSelect: function ( language ) { onSelect: function ( language ) {
mw.uls.changeLanguage( language ); mw.uls.changeLanguage( language );
} }
}; } ).trigger( 'click', eventParams );
$ulsTrigger.uls( ulsOptions ).trigger( 'click', eventParams );
e.stopPropagation(); e.stopPropagation();
} }