From 1ad0c9c8194b3db294ee45c8da41ce47b29514c8 Mon Sep 17 00:00:00 2001
From: Timo Tijhof <krinklemail@gmail.com>
Date: Wed, 10 Oct 2018 03:39:57 +0100
Subject: [PATCH] ext.uls.eventlogger: Remove use of removed setDefaults()
 method

Follows-up 2ac8a0a4b6, which removed this method. In checking
Codesearch, I somehow missed this one call among the false positive
results for Datepicker and TMH-related calls to a different method
also called "setDefaults".

Bug: T206588
Bug: T187207
Change-Id: I4f94ce6f8f1b85c192b69c5b50c3f090f7b4bfd2
---
 resources/js/ext.uls.eventlogger.js | 25 +++++++++++++------------
 1 file changed, 13 insertions(+), 12 deletions(-)

diff --git a/resources/js/ext.uls.eventlogger.js b/resources/js/ext.uls.eventlogger.js
index 24b9b574..1c94f60c 100644
--- a/resources/js/ext.uls.eventlogger.js
+++ b/resources/js/ext.uls.eventlogger.js
@@ -27,20 +27,17 @@
 	 * @since 2013.08
 	 */
 	function ULSEventLogger() {
-		this.init();
+		this.eventDefault = {
+			version: 1,
+			token: mw.user.id(),
+			contentLanguage: mw.config.get( 'wgContentLanguage' ),
+			interfaceLanguage: mw.config.get( 'wgUserLanguage' )
+		};
+		this.schemaDefault = 'UniversalLanguageSelector';
 		this.listen();
 	}
 
 	ULSEventLogger.prototype = {
-		init: function () {
-			mw.eventLog.setDefaults( 'UniversalLanguageSelector', {
-				version: 1,
-				token: mw.user.id(),
-				contentLanguage: mw.config.get( 'wgContentLanguage' ),
-				interfaceLanguage: mw.config.get( 'wgUserLanguage' )
-			} );
-		},
-
 		/**
 		 * Local wrapper for 'mw.eventLog.logEvent'
 		 *
@@ -49,13 +46,17 @@
 		 * @return {jQuery.Promise} jQuery Promise object for the logging call
 		 */
 		log: function ( event, schema ) {
-			// We need to create our own deferred for two reasons:
+			// FIXME: We need to create our own deferred for two reasons:
 			//  - logEvent might not be executed immediately
 			//  - we cannot reject a promise returned by it
 			// So we proxy the original promises status updates.
 			var deferred = $.Deferred();
 
-			schema = schema || 'UniversalLanguageSelector';
+			schema = schema || this.schemaDefault;
+
+			if ( schema === this.schemaDefault ) {
+				event = $.extend( {}, this.eventBase, event );
+			}
 
 			mw.eventLog.logEvent( schema, event )
 				.done( deferred.resolve )