From 7be6eeaa2ee6b21cf634a0a67b625237314c2c6d Mon Sep 17 00:00:00 2001 From: Siebrand Mazeland Date: Mon, 12 Nov 2012 07:45:12 +0100 Subject: [PATCH 1/2] Fix possible variable pollution Change-Id: I93b3329d4ff2d8affac379d10baec892c46481f0 --- data/LanguageNameIndexer.php | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/data/LanguageNameIndexer.php b/data/LanguageNameIndexer.php index 7ef08536..b8df9c53 100644 --- a/data/LanguageNameIndexer.php +++ b/data/LanguageNameIndexer.php @@ -39,8 +39,8 @@ class LanguageNameIndexer extends Maintenance { foreach ( $languages as $code => $name ) { $all[$code][strtolower( $name )] = true; $langnames = LanguageNames::getNames( $code, 0, 2 ); - foreach ( $langnames as $code => $name ) { // FIXME: Variable pollution - $all[$code][] = strtolower( $name ); + foreach ( $langnames as $langCode => $langName ) { + $all[$langCode][] = strtolower( $langName ); } } From 9ff4a4c34328c9cb23e7d2017f0360bb554fc151 Mon Sep 17 00:00:00 2001 From: Siebrand Mazeland Date: Mon, 12 Nov 2012 07:46:38 +0100 Subject: [PATCH 2/2] Remove empty @returns comment Change-Id: I83625c21a0de492004a1f20337a8288de0e49fd3 --- resources/js/ext.uls.preferences.js | 1 - 1 file changed, 1 deletion(-) diff --git a/resources/js/ext.uls.preferences.js b/resources/js/ext.uls.preferences.js index 36b59abd..e7f2f0ae 100644 --- a/resources/js/ext.uls.preferences.js +++ b/resources/js/ext.uls.preferences.js @@ -57,7 +57,6 @@ * Get a preference value for the given preference name * * @param key - * @returns */ get: function ( key ) { return this.preferences[key];