From 1c72077c899f1602ed40a7d47ce2b2afebc34180 Mon Sep 17 00:00:00 2001 From: Santhosh Thottingal Date: Mon, 29 Oct 2012 14:27:40 +0530 Subject: [PATCH] Cleanup whitepace, unwanted fixmes, wrong comments, jshint Change-Id: I571b2b3a7e9fbbe7c93262ee9783fbe334d9170e --- resources/js/ext.uls.displaysettings.js | 2 +- resources/js/ext.uls.ime.js | 6 +++--- resources/js/ext.uls.inputsettings.js | 6 ++---- 3 files changed, 6 insertions(+), 8 deletions(-) diff --git a/resources/js/ext.uls.displaysettings.js b/resources/js/ext.uls.displaysettings.js index 4a2bd0f0..1c4ca0ac 100644 --- a/resources/js/ext.uls.displaysettings.js +++ b/resources/js/ext.uls.displaysettings.js @@ -84,7 +84,7 @@ + '' + '' + '' - + ''; // FIXME i18n and too much hardcoding. + + ''; function DisplaySettings( $parent ) { this.name = $.i18n( 'ext-uls-display-settings-title-short' ); diff --git a/resources/js/ext.uls.ime.js b/resources/js/ext.uls.ime.js index b62510aa..9877337a 100644 --- a/resources/js/ext.uls.ime.js +++ b/resources/js/ext.uls.ime.js @@ -1,5 +1,5 @@ /** - * ULS-Webfonts integration + * ULS - jQuery IME integration * * Copyright (C) 2012 Alolita Sharma, Amir Aharoni, Arun Ganesh, Brandon Harris, * Niklas Laxström, Pau Giner, Santhosh Thottingal, Siebrand Mazeland and other @@ -40,7 +40,7 @@ return availableLanguages; }; - mw.ime.getIMELanguageList = function () { + mw.ime.getIMELanguageList = function () { var unique = [], imeLanguageList, previousIMELanguages; @@ -103,7 +103,7 @@ } } ); - $.ime.preferences.load(); + $.ime.preferences.load(); } ); diff --git a/resources/js/ext.uls.inputsettings.js b/resources/js/ext.uls.inputsettings.js index d4f9be4e..8ee6cee1 100644 --- a/resources/js/ext.uls.inputsettings.js +++ b/resources/js/ext.uls.inputsettings.js @@ -129,11 +129,9 @@ 'class': 'imelabel' } ); - // TODO Niklas: Was there some problems with IE needing the type=foo immediately? - $inputMethodItem = $( '' ).attr( { + $inputMethodItem = $( '' ).attr( { name: 'ime', id: imeId, - type: 'radio', value: imeId, checked: selected } ); @@ -322,7 +320,7 @@ that.close(); } ); - $imeListContainer.on( 'change', 'input:radio[name=ime]:checked', function () { + $imeListContainer.on( 'change', 'input:radio[name=ime]:checked', function () { var ime = $( this ).val(); $.ime.preferences.setLanguage( that.imeLanguage );