diff --git a/.eslintrc.json b/.eslintrc.json index f8d3c1bc..678fae13 100644 --- a/.eslintrc.json +++ b/.eslintrc.json @@ -1,8 +1,7 @@ { "extends": "wikimedia", "env": { - "browser": true, - "qunit": true + "browser": true }, "globals": { "$": false, @@ -10,6 +9,7 @@ "OO": false }, "rules": { - "dot-notation": [ "error", { "allowKeywords": true } ] + "dot-notation": [ "error", { "allowKeywords": true } ], + "max-len": 0 } } diff --git a/package.json b/package.json index 627811fe..cd34b01d 100644 --- a/package.json +++ b/package.json @@ -4,15 +4,16 @@ "test": "grunt test" }, "devDependencies": { - "eslint-config-wikimedia": "0.5.0", - "grunt": "1.0.1", + "eslint-config-wikimedia": "0.7.2", + "eslint-plugin-qunit": "3.3.1", + "grunt": "1.0.3", "grunt-banana-checker": "0.6.0", - "grunt-eslint": "20.1.0", + "grunt-eslint": "21.0.0", "grunt-jsonlint": "1.1.0", - "grunt-stylelint": "0.9.0", + "grunt-stylelint": "0.10.1", "grunt-svgmin": "5.0.0", - "stylelint": "8.2.0", - "stylelint-config-wikimedia": "0.4.2" + "stylelint": "9.2.0", + "stylelint-config-wikimedia": "0.4.3" }, "eslintIgnore": [ "lib/**", diff --git a/tests/qunit/.eslintrc.json b/tests/qunit/.eslintrc.json new file mode 100644 index 00000000..b5a19a1e --- /dev/null +++ b/tests/qunit/.eslintrc.json @@ -0,0 +1,9 @@ +{ + "extends": [ + "wikimedia/qunit", + "../../.eslintrc.json" + ], + "env": { + "qunit": true + } +} diff --git a/tests/qunit/ext.uls.tests.js b/tests/qunit/ext.uls.tests.js index caa9f657..4d7e428c 100644 --- a/tests/qunit/ext.uls.tests.js +++ b/tests/qunit/ext.uls.tests.js @@ -63,7 +63,9 @@ assert.ok( successSave, 'Options saving API did not produce an error.' ); // Delete old options prefs.set( prefName, undefined ); - prefs.save( done ); + prefs.save( function () { + done(); + } ); } ); } );