From 22c721dd1b0963a64e7564a4df5572edd7517eb5 Mon Sep 17 00:00:00 2001 From: Amire80 Date: Sun, 6 Nov 2016 12:22:51 +0200 Subject: [PATCH] Bidi-isolate input method name in the input method selector Without this isolation the input method name can be shown incorrectly when its direction is different from the direction of the "How to use" element. This only breaks on Firefox; Chrome somehow shows it correctly without isolation, but isolation makes sense in any case. Change-Id: I3c906f4fdd259b94f909b36bab91474cae2971af --- resources/css/ext.uls.inputsettings.less | 5 +++++ resources/js/ext.uls.inputsettings.js | 8 ++++++-- 2 files changed, 11 insertions(+), 2 deletions(-) diff --git a/resources/css/ext.uls.inputsettings.less b/resources/css/ext.uls.inputsettings.less index 09225e03..a6095bc8 100644 --- a/resources/css/ext.uls.inputsettings.less +++ b/resources/css/ext.uls.inputsettings.less @@ -98,6 +98,11 @@ margin: 12px 0; padding: 6px 10px; background: #f0f0f0; + + .uls-input-settings-name { + unicode-bidi: -moz-isolate; + unicode-bidi: isolate; + } } .uls-input-settings-inputmethods-list .mw-ui-radio { diff --git a/resources/js/ext.uls.inputsettings.js b/resources/js/ext.uls.inputsettings.js index dd3e8710..9154f461 100644 --- a/resources/js/ext.uls.inputsettings.js +++ b/resources/js/ext.uls.inputsettings.js @@ -203,8 +203,12 @@ } $imeLabel.append( - $( '' ).text( name ), - $( '' ).text( description ), + $( '' ) + .addClass( 'uls-input-settings-name' ) + .text( name ), + $( '' ) + .addClass( 'uls-input-settings-description' ) + .text( description ), $helplink );