Fixed Style/StringLiterals RuboCop offense

Bug: 117989
Change-Id: I82086ebd56ace9f85c521ef53b67e5e4bae9d607
This commit is contained in:
Željko Filipin
2015-11-18 12:00:36 +01:00
parent 81e918780a
commit 22e8762cec
20 changed files with 128 additions and 134 deletions

View File

@@ -1,3 +1,3 @@
After do
step "I have reset my preferences"
step 'I have reset my preferences'
end

View File

@@ -1,23 +1,23 @@
# encoding: utf-8
require "page-object"
require 'page-object'
module InterlanguagePageModule
include PageObject
a(:add_links, id: "wbc-linkToItem-link")
a(:back_to_display, text: "Back to display settings")
a(:back_to_input, text: "Back to input settings")
span(:cog, class: "uls-settings-trigger")
button(:ellipsis_button, class: "uls-more-languages button")
a(:english_link, text: "English")
a(:hindi_link, title: "Hindi")
div(:input_settings, id: "input-settings-block")
div(:language_list, class: "row uls-language-list lcd")
text_field(:language_search, id: "uls-languagefilter")
button(:non_default_language, class: "button uls-language-button", index: 1)
a(:talk, text: "Discussion")
span(:x, id: "languagesettings-close")
a(:how_to_use_ml_transliteration, href: "https://www.mediawiki.org/wiki/Special:MyLanguage/Help:Extension:UniversalLanguageSelector/Input_methods/ml-transliteration")
a(:edit_link, css: "#ca-edit a")
a(:interlang_link, css: "#p-lang li.interlanguage-link")
a(:add_links, id: 'wbc-linkToItem-link')
a(:back_to_display, text: 'Back to display settings')
a(:back_to_input, text: 'Back to input settings')
span(:cog, class: 'uls-settings-trigger')
button(:ellipsis_button, class: 'uls-more-languages button')
a(:english_link, text: 'English')
a(:hindi_link, title: 'Hindi')
div(:input_settings, id: 'input-settings-block')
div(:language_list, class: 'row uls-language-list lcd')
text_field(:language_search, id: 'uls-languagefilter')
button(:non_default_language, class: 'button uls-language-button', index: 1)
a(:talk, text: 'Discussion')
span(:x, id: 'languagesettings-close')
a(:how_to_use_ml_transliteration, href: 'https://www.mediawiki.org/wiki/Special:MyLanguage/Help:Extension:UniversalLanguageSelector/Input_methods/ml-transliteration')
a(:edit_link, css: '#ca-edit a')
a(:interlang_link, css: '#p-lang li.interlanguage-link')
end

View File

@@ -3,18 +3,18 @@ module LanguageModule
def language_to_code(language)
case language
when "German"
"de"
when "English"
"en"
when "Finnish"
"fi"
when "Hebrew"
"he"
when "Hindi"
"hi"
when "Malayalam"
"ml"
when 'German'
'de'
when 'English'
'en'
when 'Finnish'
'fi'
when 'Hebrew'
'he'
when 'Hindi'
'hi'
when 'Malayalam'
'ml'
else
p "Unknown language #{language}"
end

View File

@@ -1,5 +1,5 @@
class EditPage
include PageObject
textarea(:editarea, id: "wpTextbox1")
textarea(:editarea, id: 'wpTextbox1')
end

View File

@@ -2,17 +2,17 @@ class IMEPage
include PageObject
include LanguageModule
page_url "?<%=params[:extra]%>"
page_url '?<%=params[:extra]%>'
div(:input_method, class: "imeselector imeselector-toggle")
a(:input_method_enabled, class: "ime-name imeselector-toggle")
h3(:input_method_ime_list_title, class: "ime-list-title")
ul(:input_method_language_list, class: "ime-language-list")
div(:input_method_selector_menu, class: "imeselector-menu")
text_field(:language_filter, id: "uls-languagefilter")
li(:malayalam_inscript2, data_ime_inputmethod: "ml-inscript2")
a(:more_languages, class: "ime-selector-more-languages")
text_field(:search_input, id: "searchInput")
div(:input_method, class: 'imeselector imeselector-toggle')
a(:input_method_enabled, class: 'ime-name imeselector-toggle')
h3(:input_method_ime_list_title, class: 'ime-list-title')
ul(:input_method_language_list, class: 'ime-language-list')
div(:input_method_selector_menu, class: 'imeselector-menu')
text_field(:language_filter, id: 'uls-languagefilter')
li(:malayalam_inscript2, data_ime_inputmethod: 'ml-inscript2')
a(:more_languages, class: 'ime-selector-more-languages')
text_field(:search_input, id: 'searchInput')
def ime_input_method_menu_onscreen?
browser.execute_script( "

View File

@@ -2,5 +2,5 @@ class InterlanguagePage
include PageObject
include InterlanguagePageModule
page_url "Boleyn_family"
page_url 'Boleyn_family'
end

View File

@@ -1,24 +1,24 @@
class MainPage
include PageObject
page_url "Main_Page"
page_url 'Main_Page'
span(:cog, title: "Language settings")
a(:create_a_book, text: "Create a book")
a(:download_as_pdf, text: "Download as PDF")
a(:download_the_file, text: "Download the file")
li(:main_page, id: "n-mainpage-description")
div(:asia, id: "AS")
span(:cog, title: 'Language settings')
a(:create_a_book, text: 'Create a book')
a(:download_as_pdf, text: 'Download as PDF')
a(:download_the_file, text: 'Download the file')
li(:main_page, id: 'n-mainpage-description')
div(:asia, id: 'AS')
a(:malayalam) do |page|
page.asia_element.element.li(lang: "ml")
page.asia_element.element.li(lang: 'ml')
end
a(:print_export, text: "Print/export")
a(:printable_version, text: "Printable version")
button(:search_button, id: "searchButton")
a(:print_export, text: 'Print/export')
a(:printable_version, text: 'Printable version')
button(:search_button, id: 'searchButton')
def non_interlanguage_links_use_autonym_font?
browser.elements(css: "#p-lang li:not(.interlanguage-link)").collect do |element|
element.style("font-family")
browser.elements(css: '#p-lang li:not(.interlanguage-link)').collect do |element|
element.style('font-family')
end.to_s.match(/Autonym/) != nil
end
end

View File

@@ -1,7 +1,7 @@
class NoInterlanguagePage
include PageObject
page_url "Think_Like_a_Cat"
page_url 'Think_Like_a_Cat'
include InterlanguagePageModule
end

View File

@@ -2,60 +2,60 @@ class PanelPage
include PageObject
include LanguageModule
page_url "?<%=params[:extra]%>"
page_url '?<%=params[:extra]%>'
div(:uls, class: "uls-menu")
span(:uls_button_close, id: "uls-close")
div(:uls, class: 'uls-menu')
span(:uls_button_close, id: 'uls-close')
div(:language_settings_dialog, id: "language-settings-dialog")
div(:panel_display, id: "display-settings-block")
button(:panel_fonts, id: "uls-display-settings-fonts-tab")
button(:panel_language, id: "uls-display-settings-language-tab")
div(:language_settings_dialog, id: 'language-settings-dialog')
div(:panel_display, id: 'display-settings-block')
button(:panel_fonts, id: 'uls-display-settings-fonts-tab')
button(:panel_language, id: 'uls-display-settings-language-tab')
div(:panel_side_display, id: "display-panel-trigger")
div(:panel_side_input, id: "input-panel-trigger")
div(:panel_side_display, id: 'display-panel-trigger')
div(:panel_side_input, id: 'input-panel-trigger')
span(:panel_button_close, id: "languagesettings-close")
button(:panel_button_apply, class: "uls-settings-apply")
button(:panel_button_cancel, class: "uls-settings-cancel")
span(:panel_button_close, id: 'languagesettings-close')
button(:panel_button_apply, class: 'uls-settings-apply')
button(:panel_button_cancel, class: 'uls-settings-cancel')
button(:panel_disable_input_methods, class: "uls-input-toggle-button")
button(:panel_enable_input_methods, class: "uls-input-toggle-button")
button(:panel_disable_input_methods, class: 'uls-input-toggle-button')
button(:panel_enable_input_methods, class: 'uls-input-toggle-button')
checkbox(:webfonts_enable_checkbox, id: "webfonts-enable-checkbox")
checkbox(:webfonts_enable_checkbox, id: 'webfonts-enable-checkbox')
select_list(:panel_content_font_selector, id: "content-font-selector")
select_list(:panel_interface_font_selector, id: "ui-font-selector")
select_list(:panel_content_font_selector, id: 'content-font-selector')
select_list(:panel_interface_font_selector, id: 'ui-font-selector')
button(:other_language_button, class: "button uls-language-button", index: 1)
button(:default_language_button, css: ".uls-language-button.down")
button(:other_language_button, class: 'button uls-language-button', index: 1)
button(:default_language_button, css: '.uls-language-button.down')
# Triggers
span(:trigger_cog, class: "uls-settings-trigger")
a(:trigger_personal, class: "uls-trigger")
span(:trigger_cog, class: 'uls-settings-trigger')
a(:trigger_personal, class: 'uls-trigger')
select(:selected_content_font, id: "content-font-selector")
select(:selected_interface_font, id: "ui-font-selector")
select(:selected_content_font, id: 'content-font-selector')
select(:selected_interface_font, id: 'ui-font-selector')
select(:font_for_content, id: "content-font-selector")
select(:font_for_content, id: 'content-font-selector')
div(:uls_display_settings, class: "uls-display-settings")
div(:uls_display_settings, class: 'uls-display-settings')
radio_button(:ml_inscript2_radio, id: "ml-inscript2")
radio_button(:ml_inscript2_radio, id: 'ml-inscript2')
# Is there way to access the html element?
div(:interface, id: "footer")
div(:interface, id: 'footer')
def uls_language_name_item(language)
browser.element(css: ".uls-language-block li[lang=#{language}] a")
end
def content_font
font("#mw-content-text")
font('#mw-content-text')
end
def interface_font
font("body")
font('body')
end
def uls_onscreen?

View File

@@ -1,11 +1,11 @@
class PreferencesPage
include PageObject
page_url "Special:Preferences"
page_url 'Special:Preferences'
select(:set_interface_language, id: "mw-input-wplanguage")
button(:save, id: "prefcontrol")
select(:set_interface_language, id: 'mw-input-wplanguage')
button(:save, id: 'prefcontrol')
a(:editing_tab, id: "preftab-editing")
select(:editing_font, id: "mw-input-wpeditfont")
a(:editing_tab, id: 'preftab-editing')
select(:editing_font, id: 'mw-input-wpeditfont')
end