bryce/mediawiki-extensions-UniversalLanguageSelector
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Restore enableWebfonts pref and remove uls-enable

Browse Source 
This patch restores the enableWebfonts preference, stored inside
the uls-preferences blob. It existed as 'enable-webfonts' in
the past and was removed in
If735a733717596fae03042c5e277bd538bd8501f

Each wiki can be configured to load the fonts by default
using the new global variable $wgULSWebfontsEnabled.
Its default value is true (to load fonts).

This also removes the preference 'uls-enable', recently added in
I71b70d8ee7c3cad7f49b32e5dc494ef4fc1bdb2f

The initialization of ext.uls.webfonts.js is changed as well,
so that minimal webfonts JS library code is loaded,
and the rest is loaded only if a user requests it.

Bug: 60304
Change-Id: I49e812eae32266f165591c75fd67b86ca06b13f0
This commit is contained in:
Santhosh Thottingal
2014-02-10 17:40:24 +05:30
parent 7b376a80c8
commit 27771fdeaf
20 changed files with 409 additions and 106 deletions
Download Patch File Download Diff File Expand all files Collapse all files

78
tests/browser/features/font_selection_default_enabled.feature Normal file
View File

@@ -0,0 +1,78 @@
@commons.wikimedia.beta.wmflabs.org @login @needs-custom-setup
Feature: Font selection
In order to have better using experience,
As a reader and writer,
I want to change or disable the fonts for interface and content.
In addition the user is provided live preview feature: changes are applied
immediately when selection is made. Changes can either be applied or discarded
for easy testing.
This feature is similar to font_selection_default_disabled,
but it is targeted at wikis where automatic font downloading
is disabled by default ($wgULSWebfontsEnabled = true).
Background:
Given I am logged in
And I have reset my preferences
And I set "German" as the interface language
And I open ULS
And I open Display panel of language settings
When I open Fonts panel of language settings
Scenario: Font selector pane appears
Then a font selector for interface language appears
And a font selector for content language appears
And the checkbox to enable fonts downloading appears
And the checkbox to enable fonts downloading is checked
And webfonts are applied to body
Scenario: Discarding live preview of content font
When I select OpenDyslexic font for the content language for the live preview
And I close the panel to discard the changes
And I open Display panel of language settings
Then the selected content font must be system
And the active content font must be the same as font prior to the preview
Scenario: Discarding live preview of interface font
When I select OpenDyslexic font for the interface language for the live preview
And I close the panel to discard the changes
Then the active interface font must be the same as font prior to the preview
And the selected interface font must be Systemschriftart
Scenario: Applying the live preview of interface font
When I select OpenDyslexic font for the interface language for the live preview
And I apply the changes
Then the interface font is OpenDyslexic
Scenario: Disabling fonts if they are enabled by default
When I click the checkbox to enable fonts downloading
Then a font selector for interface language doesn't appear
And a font selector for content language doesn't appear
And the checkbox to enable fonts downloading is not checked
Scenario: Disabling fonts when they are enabled by default and going to another page
When I click the checkbox to disable fonts downloading
And I apply the changes
And I am on the main page
And I open ULS
And I open Display panel of language settings
Then a font selector for interface language doesn't appear
And a font selector for content language doesn't appear
And the checkbox to enable fonts downloading is not checked
And webfonts are not applied to body
Scenario: Disabling fonts, going to another page, and re-enabling fonts
When I click the checkbox to disable fonts downloading
And I apply the changes
And I am on the main page
And I open ULS
And I open Display panel of language settings
And I open Fonts panel of language settings
And I click the checkbox to enable fonts downloading
Then a font selector for interface language appears
And a font selector for content language appears
And the checkbox to enable fonts downloading appears
And the checkbox to enable fonts downloading is checked
And webfonts are applied to body