bryce/mediawiki-extensions-UniversalLanguageSelector
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Avoid (safe) exception by using empty options

Browse Source 
Using try-catch block to handle common case of empty options isn't nice.
Avoid it be replacing options to valid JSON

Change-Id: I5b64f7f9a76a94d9c07face8059beab59d4aef93
This commit is contained in:
eranroz
2015-07-16 13:13:57 +03:00
parent 71e8c91d3e
commit 301520f3fd
1 changed files with 3 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
resources/js/ext.uls.preferences.js
View File

@@ -101,7 +101,9 @@
this.preferences = preferenceStore().get( this.preferenceName ); this.preferences = preferenceStore().get( this.preferenceName );
} else { } else {
var options = mw.user.options.get( this.preferenceName ); var options = mw.user.options.get( this.preferenceName );
if ( !options ) {
options = '{}';
}
// Try to parse JSON // Try to parse JSON
try { try {
this.preferences = JSON.parse( options ); this.preferences = JSON.parse( options );