From 3524e733b9a740c8ec1f237bd1a135561d37abe8 Mon Sep 17 00:00:00 2001 From: Tim Starling Date: Fri, 20 May 2022 18:16:31 +1000 Subject: [PATCH] Suppress PhanParamSignatureRealMismatchParamType on classes affected by new RL namespace There is an alias, so there shouldn't be a problem in production. Phan raises a spurious warning when the target version is PHP 7.2. Bug: T308443 Change-Id: I75f1a1bd113a18c40236bd622b0eb76743432ceb --- includes/ResourceLoaderULSJsonMessageModule.php | 3 +++ includes/ResourceLoaderULSModule.php | 1 + 2 files changed, 4 insertions(+) diff --git a/includes/ResourceLoaderULSJsonMessageModule.php b/includes/ResourceLoaderULSJsonMessageModule.php index c5ecc172..a5941854 100644 --- a/includes/ResourceLoaderULSJsonMessageModule.php +++ b/includes/ResourceLoaderULSJsonMessageModule.php @@ -20,6 +20,7 @@ class ResourceLoaderULSJsonMessageModule extends ResourceLoaderModule { /** * Part of the ResourceLoader module interface. * Declares the core ext.uls.i18n module as a dependency. + * @suppress PhanParamSignatureRealMismatchParamType, UnusedSuppression -- T308443 * @param ResourceLoaderContext|null $context * @return string[] Module names. */ @@ -36,6 +37,7 @@ class ResourceLoaderULSJsonMessageModule extends ResourceLoaderModule { } /** + * @suppress PhanParamSignatureRealMismatchParamType, UnusedSuppression -- T308443 * @param ResourceLoaderContext $context * @return array */ @@ -56,6 +58,7 @@ class ResourceLoaderULSJsonMessageModule extends ResourceLoaderModule { /** * Get the message strings for the current UI language. Uses * mw.uls.loadLocalization to register them on the frontend. + * @suppress PhanParamSignatureRealMismatchParamType, UnusedSuppression -- T308443 * @param ResourceLoaderContext $context * @return string JavaScript code. */ diff --git a/includes/ResourceLoaderULSModule.php b/includes/ResourceLoaderULSModule.php index 901e3752..a1bfd97c 100644 --- a/includes/ResourceLoaderULSModule.php +++ b/includes/ResourceLoaderULSModule.php @@ -48,6 +48,7 @@ class ResourceLoaderULSModule extends ResourceLoaderModule { } /** + * @suppress PhanParamSignatureRealMismatchParamType, UnusedSuppression -- T308443 * @param ResourceLoaderContext $context * @return string JavaScript code */