From 3af22f60d499edd8d6b857627b312b5c4ea07a19 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Niklas=20Laxstr=C3=B6m?= Date: Wed, 24 Mar 2021 10:32:08 +0100 Subject: [PATCH] Fix ULS dialog positioning in some cases In development environment, ev.currentTarget is the button. In Beta Cluster, however, once ext.uls.mediawiki is loaded, it is now the document (the event has bubbled up). I do not know what causes the difference, but we can use the target. Bug: T276255 Change-Id: Ie4c425510293a6f2ce81e4bf4a353f2c8d86d412 --- resources/js/ext.uls.interface.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/resources/js/ext.uls.interface.js b/resources/js/ext.uls.interface.js index ac8ec0a6..7aa5c4cb 100644 --- a/resources/js/ext.uls.interface.js +++ b/resources/js/ext.uls.interface.js @@ -461,7 +461,7 @@ mw.loader.using( 'ext.uls.mediawiki' ).then( function () { var $target, parent, languageNodes, standalone, uls; - $target = $( ev.currentTarget ); + $target = $( ev.target ); parent = document.querySelectorAll( '.mw-portlet-lang, #p-lang' )[ 0 ]; languageNodes = parent ? parent.querySelectorAll( '.interlanguage-link-target' ) : []; standalone = isUsingStandaloneLanguageButton();