bryce/mediawiki-extensions-UniversalLanguageSelector
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge "Refactor two live preview scenarios"

Browse Source
This commit is contained in:
jenkins-bot
2013-12-11 09:22:13 +00:00
committed by Gerrit Code Review
parent 2e4fb7d028 cdb21c9c49
commit 3ed7cb54f1
4 changed files with 16 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
tests/browser/features/live_preview_of_display_language.feature
View File

@@ -14,18 +14,22 @@ Feature: Live preview of display language changes
And I click on the link to select Malayalam
Then I should see the text in the language panel in Malayalam
@commons.wikimedia.beta.wmflabs.org
Scenario: Live preview of display language changes can be reverted on cancel
Given I open "Language" panel of language settings
Given I open the Universal Language Selector
And I open Display panel of language settings
And I select a language different than English for display language
When I click Cancel
And I open "Language" panel of language settings
And I open Display panel of language settings
Then I should see the text in the language panel in English
@commons.wikimedia.beta.wmflabs.org
Scenario: Live preview of display language changes can be reverted on closing the dialog with the X button
Given I open "Language" panel of language settings
Given I open the Universal Language Selector
And I open Display panel of language settings
And I select a language different than English for display language
When I click X
And I open "Language" panel of language settings
And I open Display panel of language settings
Then I should see the text in the language panel in English
Scenario: Live preview of display language changes can be reverted on closing the dialog on cancel from a different section

8
tests/browser/features/step_definitions/cog_sidebar_user_steps.rb
View File

@@ -27,20 +27,12 @@ Given(/^I navigate to the Language Settings panel$/) do
step "I see the logged in language settings panel"
end
When(/^I click Cancel$/) do
on(PanelPage).panel_button_cancel_element.click
end
When(/^I click the cog icon by Languages in the sidebar$/) do
on(NoInterlanguagePage).cog_element.when_present.click
# Wait for the panel to open
on(PanelPage).panel_display_element.when_visible
end
When(/^I click X$/) do
on(InterlanguagePage).x_element.click
end
Then(/^I can navigate back to Input Settings$/) do
on(InterlanguagePage) do |page|
page.back_to_input

8
tests/browser/features/step_definitions/common_steps.rb
View File

@@ -33,3 +33,11 @@ end
When(/^in the language filter I type (.+)$/) do |language_abbreviation|
on(IMEPage).language_filter = language_abbreviation
end
When(/^I click Cancel$/) do
on(PanelPage).panel_button_cancel_element.click
end
When(/^I click X$/) do
on(InterlanguagePage).x_element.click
end

1
tests/browser/features/support/pages/panel_page.rb
View File

@@ -29,7 +29,6 @@ class PanelPage
select_list(:panel_content_font_selector, id: "content-font-selector")
select_list(:panel_interface_font_selector, id: "ui-font-selector")
# TODO: Rename to match convention
button(:other_language_button, class: "button uls-language-button", index: 1)
button(:default_language_button, css: ".uls-language-button.down")