Remove duplicate code and add todo

Found while looking at bug 47974

Change-Id: I7d4ef165e36e96cb6a61880a3413d8883c51c7fd
This commit is contained in:
Niklas Laxström
2014-02-06 11:16:18 +00:00
committed by Kartik Mistry
parent 516095e43b
commit 41d6ee2f44

View File

@@ -117,6 +117,8 @@
$moreSettingsLink = $( '<span>' ) $moreSettingsLink = $( '<span>' )
.addClass( 'uls-ime-more-settings-link' ); .addClass( 'uls-ime-more-settings-link' );
// Apparently we depend on some styles which are loaded with
// these modules. This needs refactoring.
mw.loader.using( mw.uls.languageSettingsModules, function () { mw.loader.using( mw.uls.languageSettingsModules, function () {
$moreSettingsLink.languagesettings( { $moreSettingsLink.languagesettings( {
defaultModule: 'input', defaultModule: 'input',
@@ -130,18 +132,7 @@
// Hide the menu. // Hide the menu.
$moreSettingsLink.on( 'click', function ( e ) { $moreSettingsLink.on( 'click', function ( e ) {
var languageSettings = $( this ).data( 'languagesettings' );
imeselector.hide(); imeselector.hide();
if ( !languageSettings ) {
$( this ).languagesettings( {
defaultModule: 'input',
onClose: function () {
// on close of input settings, keep focus in input area.
imeselector.$element.focus();
},
top: imeselector.$element.offset().top
} ).click();
}
e.stopPropagation(); e.stopPropagation();
} ); } );