From 49ed2a5ac42ea39a225e72d2eb46e6875f794d87 Mon Sep 17 00:00:00 2001 From: Timo Tijhof Date: Sat, 13 Apr 2019 18:06:35 +0100 Subject: [PATCH] ULSJsonMessageModule: Remove language code validation The ResourceLoaderContext class already performs a stricter version of this. Change-Id: I46b920cbc0f9024e5ed2027ff30c40400a73fef3 --- includes/ResourceLoaderULSJsonMessageModule.php | 7 ------- 1 file changed, 7 deletions(-) diff --git a/includes/ResourceLoaderULSJsonMessageModule.php b/includes/ResourceLoaderULSJsonMessageModule.php index 465a5785..c093f91b 100644 --- a/includes/ResourceLoaderULSJsonMessageModule.php +++ b/includes/ResourceLoaderULSJsonMessageModule.php @@ -35,9 +35,6 @@ class ResourceLoaderULSJsonMessageModule extends ResourceLoaderModule { */ public function getDefinitionSummary( ResourceLoaderContext $context ) { $code = $context->getLanguage(); - if ( !Language::isValidCode( $code ) ) { - $code = 'en'; - } $fileHashes = array_map( [ __CLASS__, 'safeFileHash' ], ULSJsonMessageLoader::getFilenames( $code ) @@ -58,10 +55,6 @@ class ResourceLoaderULSJsonMessageModule extends ResourceLoaderModule { */ public function getScript( ResourceLoaderContext $context ) { $code = $context->getLanguage(); - if ( !Language::isValidCode( $code ) ) { - $code = 'en'; - } - $params = [ $code, ULSJsonMessageLoader::getMessages( $code ) ]; return Xml::encodeJsCall( 'mw.uls.loadLocalization', $params );