From 58777c4e37d2fd8e4098fcf943c7e83b2a6fffd5 Mon Sep 17 00:00:00 2001 From: Fomafix Date: Sun, 6 Nov 2016 15:44:07 +0100 Subject: [PATCH] Use mw.msg() for parameter substitution mw.msg() has already a parameter substitution of $1. A separate .replace( '$1', ... ) is not necessary. Change-Id: Ie77bddc4dfb60df36211ce821c1a6f7223cde706 --- resources/js/ext.uls.ime.js | 2 +- resources/js/ext.uls.inputsettings.js | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/resources/js/ext.uls.ime.js b/resources/js/ext.uls.ime.js index 8871346b..5ebca05b 100644 --- a/resources/js/ext.uls.ime.js +++ b/resources/js/ext.uls.ime.js @@ -301,7 +301,7 @@ helpHandler: function ( ime ) { return $( '' ) .attr( { - href: mw.msg( 'uls-ime-helppage' ).replace( '$1', ime ), + href: mw.msg( 'uls-ime-helppage', ime ), target: '_blank', title: $.i18n( 'ext-uls-ime-help' ) } ) diff --git a/resources/js/ext.uls.inputsettings.js b/resources/js/ext.uls.inputsettings.js index dd3e8710..f9775309 100644 --- a/resources/js/ext.uls.inputsettings.js +++ b/resources/js/ext.uls.inputsettings.js @@ -189,7 +189,7 @@ $helplink = $( '' ) .addClass( 'uls-ime-help' ) .text( $.i18n( 'ext-uls-ime-help' ) ) - .attr( 'href', mw.msg( 'uls-ime-helppage' ).replace( '$1', imeId ) ) + .attr( 'href', mw.msg( 'uls-ime-helppage', imeId ) ) .attr( 'target', '_blank' ); if ( !inputmethod ) { // The input method definition(rules) not loaded.