Fix Bug 39686 - Cancel button in settings should go to the previous context

* Add an onClose option for language settings
* Add a close method to language settings and display settings
* some documentation and cleanup

Change-Id: I3040e0740bd8a9f9f7d3ad508a3003415a24e7a9
This commit is contained in:
Santhosh Thottingal
2012-09-07 15:29:08 +05:30
parent 997e0ac512
commit 5c07275300
3 changed files with 37 additions and 14 deletions

View File

@@ -139,12 +139,28 @@
this.$window.show();
},
/**
* Hide this window.
* Will be used when moving to a different context and
* need coming back.
*/
hide: function() {
this.shown = false;
this.$window.hide();
},
click: function ( e ) {
/**
* Close this language settings window, and
* call onClose if defined from the previous context.
*/
close: function() {
this.hide();
if ( this.options.onClose ) {
this.options.onClose();
}
},
click: function( e ) {
if ( !this.shown ) {
this.show();
}
@@ -168,12 +184,11 @@
$.fn.languagesettings.modules = {};
$.fn.languagesettings.defaults = {
settings: {},
template: windowTemplate,
modules: {},
defaultModule: false,
top: null,
left: null
onClose: null, // An onClose event handler.
top: null, // Top position of this window
left: null // Left position of this window
};
$.fn.languagesettings.Constructor = LanguageSettings;