bryce/mediawiki-extensions-UniversalLanguageSelector
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Reduce JS loaded on critical path

Browse Source 
As a precursor to incorporating a new language switcher in the new
version of Vector I'd like to improve the performance of loading
the switcher.

It seems most code can be deferred until the language selector
button is clicked.

This shaves around 30kb of resources off the critical path for
most users. There's potential here for a positive performance
impact so we should follow up the deployment by checking the
associated performance graphs to see if there's improvement.

Note, if the compact personal links feature is enabled
there is no performance saving for now. This will be addressed in follow
ups.

Bug: T153844
Bug: T153845
Bug: T237061
Change-Id: I740600d18859422b2f98a5ef92d0321f6e9615a2
This commit is contained in:
jdlrobson
2020-10-02 16:33:54 -07:00
committed by jenkins-bot
parent 8d5d63b996
commit 5cd10ce862
6 changed files with 53 additions and 28 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
resources/js/ext.uls.interface.js
View File

@@ -19,6 +19,7 @@
( function () {
'use strict';
var languageSettingsModules = [ 'ext.uls.displaysettings' ];
/**
* Construct the display settings link
@@ -195,7 +196,9 @@
event.preventDefault();
deferred.done( function () {
mw.uls.changeLanguage( event.target.lang );
mw.loader.using( [ 'ext.uls.common' ] ).then( function () {
mw.uls.changeLanguage( event.target.lang );
} );
} );
mw.hook( 'mw.uls.language.revert' ).fire( deferred );
@@ -312,7 +315,7 @@
}
};
mw.loader.using( mw.uls.languageSettingsModules, function () {
mw.loader.using( languageSettingsModules, function () {
$ulsTrigger.languagesettings( languageSettingsOptions ).trigger( 'click' );
} );
@@ -329,7 +332,7 @@
mw.hook( 'mw.uls.settings.open' ).fire( eventParams && eventParams.source || 'personal' );
}
} else {
mw.loader.using( mw.uls.languageSettingsModules, function () {
mw.loader.using( languageSettingsModules, function () {
$ulsTrigger.languagesettings();
$ulsTrigger.trigger( 'click', eventParams );
@@ -354,7 +357,7 @@
},
onReady: function () {
var uls = this;
mw.loader.using( mw.uls.languageSettingsModules, function () {
mw.loader.using( languageSettingsModules, function () {
addDisplaySettings( uls );
addInputSettings( uls );
} );
@@ -427,7 +430,9 @@
mw.storage.set( 'uls-previous-language-code', currentLanguage );
mw.storage.set( 'uls-previous-language-autonym', currentAutonym );
// Store this language in a list of frequently used languages
mw.uls.addPreviousLanguage( currentLanguage );
mw.loader.using( [ 'ext.uls.common' ] ).then( function () {
mw.uls.addPreviousLanguage( currentLanguage );
} );
}
}