From 5e6d44e940eb1b0672d9f87fc39c22d4142bf3ba Mon Sep 17 00:00:00 2001 From: Santhosh Thottingal Date: Wed, 21 Nov 2012 17:05:27 +0530 Subject: [PATCH] Close the language settings if clicked outside Make the behavior consistant with ULS language selector Change-Id: I9bfc29f908ebe48a1bb9cdcdede75a5d5aa3839d --- resources/js/ext.uls.languagesettings.js | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/resources/js/ext.uls.languagesettings.js b/resources/js/ext.uls.languagesettings.js index bad080d5..1592710d 100644 --- a/resources/js/ext.uls.languagesettings.js +++ b/resources/js/ext.uls.languagesettings.js @@ -63,11 +63,15 @@ }, listen: function () { - var that = this; + var langSettings = this; // Register all event listeners to the ULS language settings here. - that.$element.on( 'click', $.proxy( that.show, that ) ); - that.$window.find( '#languagesettings-close' ) - .on( 'click', $.proxy( that.hide, that ) ); + langSettings.$element.on( 'click', $.proxy( langSettings.show, langSettings ) ); + langSettings.$window.find( '#languagesettings-close' ) + .on( 'click', $.proxy( langSettings.hide, langSettings ) ); + + // hide this window if clicking elsewhere + $( document ).on( 'click', $.proxy( langSettings.hide, langSettings ) ); + }, render: function () {