LanguageSettings: Do not render modules twice on initialization
Change-Id: I25d939ffcabde394bb7a496ee8bc5df9a87c2573
This commit is contained in:
committed by
Nikerabbit
parent
fc30a5d542
commit
5e7e8fe48e
@@ -139,6 +139,10 @@
|
|||||||
$settingsText
|
$settingsText
|
||||||
);
|
);
|
||||||
|
|
||||||
|
if ( active ) {
|
||||||
|
$settingsLink.addClass( 'active' );
|
||||||
|
}
|
||||||
|
|
||||||
$settingsMenuItems.append( $settingsLink );
|
$settingsMenuItems.append( $settingsLink );
|
||||||
|
|
||||||
$settingsLink.on( 'click', function () {
|
$settingsLink.on( 'click', function () {
|
||||||
@@ -151,10 +155,6 @@
|
|||||||
$this.addClass( 'active' );
|
$this.addClass( 'active' );
|
||||||
} );
|
} );
|
||||||
|
|
||||||
if ( active ) {
|
|
||||||
module.render();
|
|
||||||
$settingsLink.addClass( 'active' );
|
|
||||||
}
|
|
||||||
this.modules[ moduleName ] = module;
|
this.modules[ moduleName ] = module;
|
||||||
|
|
||||||
// Register cancel and apply hooks
|
// Register cancel and apply hooks
|
||||||
|
|||||||
Reference in New Issue
Block a user