From 60b6e52ad29759eedd9bccabf1b0c47065ebe2a8 Mon Sep 17 00:00:00 2001 From: Ebrahim Byagowi Date: Thu, 27 Jun 2024 23:50:59 +0330 Subject: [PATCH] i18n: Make close icon direction aware Currently it always shows the icon for LTR no matter direction of the user's language and this fixes it. Bug: T315464 Change-Id: Ice6902a0823047380655b825aca9fbce14920d7d --- resources/css/ext.uls.actions.menu.less | 4 +++- .../images/{arrow-previous.svg => arrow-previous-ltr.svg} | 0 resources/images/arrow-previous-rtl.svg | 4 ++++ 3 files changed, 7 insertions(+), 1 deletion(-) rename resources/images/{arrow-previous.svg => arrow-previous-ltr.svg} (100%) create mode 100644 resources/images/arrow-previous-rtl.svg diff --git a/resources/css/ext.uls.actions.menu.less b/resources/css/ext.uls.actions.menu.less index 0cd4d0bf..9cfbb933 100644 --- a/resources/css/ext.uls.actions.menu.less +++ b/resources/css/ext.uls.actions.menu.less @@ -14,7 +14,9 @@ .uls-language-actions-close { min-width: unset; width: 44px; - background: transparent url( ../images/arrow-previous.svg ) no-repeat center; + // Note that CSSJanus is flipping the `ltr` in the URL to `rtl`. + // Therefore make sure that both icons are available and up-to-date. + background: transparent url( ../images/arrow-previous-ltr.svg ) no-repeat center; } } diff --git a/resources/images/arrow-previous.svg b/resources/images/arrow-previous-ltr.svg similarity index 100% rename from resources/images/arrow-previous.svg rename to resources/images/arrow-previous-ltr.svg diff --git a/resources/images/arrow-previous-rtl.svg b/resources/images/arrow-previous-rtl.svg new file mode 100644 index 00000000..fd427083 --- /dev/null +++ b/resources/images/arrow-previous-rtl.svg @@ -0,0 +1,4 @@ + + + +