From 61ebecff919626d014a3d22c587996a274e8c38f Mon Sep 17 00:00:00 2001 From: Fomafix Date: Mon, 16 Dec 2019 11:05:57 +0100 Subject: [PATCH] Use document.body instead of 'body' as jQuery selector Change-Id: Ia551b3050ed546de1f9db44dbd332a5b6c108a9f --- lib/jquery.ime/jquery.ime.js | 4 ++-- resources/js/ext.uls.displaysettings.js | 4 ++-- resources/js/ext.uls.eventlogger.js | 2 +- resources/js/ext.uls.ime.js | 2 +- resources/js/ext.uls.inputsettings.js | 4 ++-- resources/js/ext.uls.interface.js | 6 +++--- resources/js/ext.uls.languagesettings.js | 2 +- resources/js/ext.uls.preferences.js | 4 ++-- resources/js/ext.uls.webfonts.js | 4 ++-- resources/js/ext.uls.webfonts.mobile.js | 4 ++-- 10 files changed, 18 insertions(+), 18 deletions(-) diff --git a/lib/jquery.ime/jquery.ime.js b/lib/jquery.ime/jquery.ime.js index 1b9a35a9..e47fbc4d 100644 --- a/lib/jquery.ime/jquery.ime.js +++ b/lib/jquery.ime/jquery.ime.js @@ -343,7 +343,7 @@ * Destroy the binding of ime to the editable element */ destroy: function () { - $( 'body' ).off( '.ime' ); + $( document.body ).off( '.ime' ); this.$element.off( '.ime' ).removeData( 'ime' ).removeData( 'imeselector' ); }, @@ -972,7 +972,7 @@ } this.$imeSetting.append( this.$menu ); - $( 'body' ).append( this.$imeSetting ); + $( document.body ).append( this.$imeSetting ); }, stopTimer: function () { diff --git a/resources/js/ext.uls.displaysettings.js b/resources/js/ext.uls.displaysettings.js index 5b365907..63c9a06c 100644 --- a/resources/js/ext.uls.displaysettings.js +++ b/resources/js/ext.uls.displaysettings.js @@ -121,7 +121,7 @@ */ render: function () { this.$parent.$settingsPanel.empty(); - this.$webfonts = $( 'body' ).data( 'webfonts' ); + this.$webfonts = $( document.body ).data( 'webfonts' ); this.$parent.$settingsPanel.append( this.$template ); this.prepareLanguages(); this.prepareUIFonts(); @@ -551,7 +551,7 @@ // Allow the webfonts library to finish loading setTimeout( function () { - displaySettings.$webfonts = $( 'body' ).data( 'webfonts' ); + displaySettings.$webfonts = $( document.body ).data( 'webfonts' ); mw.webfonts.preferences.enable(); diff --git a/resources/js/ext.uls.eventlogger.js b/resources/js/ext.uls.eventlogger.js index e35f33ce..a5f4a0be 100644 --- a/resources/js/ext.uls.eventlogger.js +++ b/resources/js/ext.uls.eventlogger.js @@ -217,7 +217,7 @@ mw.hook( 'mw.uls.webfonts.enable' ).add( enableWebfonts ); mw.hook( 'mw.uls.webfonts.disable' ).add( disableWebfonts ); - $( 'body' ).on( + $( document.body ).on( 'noresults.uls', '.uls-menu .uls-languagefilter', noSearchResults diff --git a/resources/js/ext.uls.ime.js b/resources/js/ext.uls.ime.js index 653bcf1a..08e9e24f 100644 --- a/resources/js/ext.uls.ime.js +++ b/resources/js/ext.uls.ime.js @@ -226,7 +226,7 @@ var imeSelectors = mw.config.get( 'wgULSImeSelectors' ).join( ', ' ); mw.ime.init(); - $( 'body' ).on( 'focus.ime', imeSelectors, function () { + $( document.body ).on( 'focus.ime', imeSelectors, function () { mw.ime.handleFocus( $( this ) ); } ); }; diff --git a/resources/js/ext.uls.inputsettings.js b/resources/js/ext.uls.inputsettings.js index 8c845f7c..f87ab72c 100644 --- a/resources/js/ext.uls.inputsettings.js +++ b/resources/js/ext.uls.inputsettings.js @@ -80,11 +80,11 @@ */ render: function () { var $enabledOnly, - webfonts = $( 'body' ).data( 'webfonts' ); + webfonts = $( document.body ).data( 'webfonts' ); this.dirty = false; this.$parent.$settingsPanel.empty(); - this.$imes = $( 'body' ).data( 'ime' ); + this.$imes = $( document.body ).data( 'ime' ); this.$parent.$settingsPanel.append( this.$template ); $enabledOnly = this.$template.find( '.enabled-only' ); if ( $.ime.preferences.isEnabled() ) { diff --git a/resources/js/ext.uls.interface.js b/resources/js/ext.uls.interface.js index 1df93afc..fe56f4c9 100644 --- a/resources/js/ext.uls.interface.js +++ b/resources/js/ext.uls.interface.js @@ -218,7 +218,7 @@ }() ) } ); - ulsPopup.$element.appendTo( 'body' ); + ulsPopup.$element.appendTo( document.body ); // The interlanguage position needs some time to settle down setTimeout( function () { @@ -435,9 +435,9 @@ function initIme() { var imeSelector = mw.config.get( 'wgULSImeSelectors' ).join( ', ' ); - $( 'body' ).on( 'focus.imeinit', imeSelector, function () { + $( document.body ).on( 'focus.imeinit', imeSelector, function () { var $input = $( this ); - $( 'body' ).off( '.imeinit' ); + $( document.body ).off( '.imeinit' ); mw.loader.using( 'ext.uls.ime', function () { mw.ime.setup(); mw.ime.handleFocus( $input ); diff --git a/resources/js/ext.uls.languagesettings.js b/resources/js/ext.uls.languagesettings.js index 151c1632..cd01a3a8 100644 --- a/resources/js/ext.uls.languagesettings.js +++ b/resources/js/ext.uls.languagesettings.js @@ -68,7 +68,7 @@ constructor: LanguageSettings, init: function () { - $( 'body' ).append( this.$window ); + $( document.body ).append( this.$window ); this.hide(); }, diff --git a/resources/js/ext.uls.preferences.js b/resources/js/ext.uls.preferences.js index 8dd2236f..09123994 100644 --- a/resources/js/ext.uls.preferences.js +++ b/resources/js/ext.uls.preferences.js @@ -147,10 +147,10 @@ mw.uls = mw.uls || {}; mw.uls.preferences = function () { - var data = $( 'body' ).data( 'preferences' ); + var data = $( document.body ).data( 'preferences' ); if ( !data ) { - $( 'body' ).data( 'preferences', ( data = new ULSPreferences() ) ); + $( document.body ).data( 'preferences', ( data = new ULSPreferences() ) ); } return data; }; diff --git a/resources/js/ext.uls.webfonts.js b/resources/js/ext.uls.webfonts.js index 1a303568..cf942772 100644 --- a/resources/js/ext.uls.webfonts.js +++ b/resources/js/ext.uls.webfonts.js @@ -72,7 +72,7 @@ // MediaWiki specific overrides for jquery.webfonts $.extend( $.fn.webfonts.defaults, { repository: mediawikiFontRepository, - fontStack: $( 'body' ).css( 'font-family' ).split( /, /g ), + fontStack: $( document.body ).css( 'font-family' ).split( /, /g ), /** * Returns a suitable font from font repository based * on the given language and html classes and user preference. @@ -127,7 +127,7 @@ // This is important because webfonts behavior depends on the font-family // property values set by stylesheets. setTimeout( function () { - $( 'body' ).webfonts(); + $( document.body ).webfonts(); }, 0 ); }; diff --git a/resources/js/ext.uls.webfonts.mobile.js b/resources/js/ext.uls.webfonts.mobile.js index bf3bb800..aeb3e838 100644 --- a/resources/js/ext.uls.webfonts.mobile.js +++ b/resources/js/ext.uls.webfonts.mobile.js @@ -32,7 +32,7 @@ // MediaWiki specific overrides for jquery.webfonts $.extend( $.fn.webfonts.defaults, { repository: mediawikiFontRepository, - fontStack: $( 'body' ).css( 'font-family' ).split( /, /g ), + fontStack: $( document.body ).css( 'font-family' ).split( /, /g ), fontSelector: function ( repository, language ) { var font = repository.defaultFont( language ); @@ -45,7 +45,7 @@ } } ); - $( 'body' ).webfonts(); + $( document.body ).webfonts(); } ); }() );