Use preventDefault instead of stopPropagation

Change-Id: I9c2da14b94348cec39e6a9a1571b22de39e437f0
This commit is contained in:
Niklas Laxström
2014-03-08 10:55:09 +00:00
parent 34b5b1ff7a
commit 62939949b4

View File

@@ -397,6 +397,8 @@
$ulsTrigger.on( 'click', function ( e, eventParams ) {
var languagesettings = $ulsTrigger.data( 'languagesettings' );
e.preventDefault();
if ( languagesettings ) {
if ( !languagesettings.shown ) {
mw.hook( 'mw.uls.settings.open' ).fire( eventParams && eventParams.source || 'personal' );
@@ -407,14 +409,14 @@
$ulsTrigger.trigger( 'click', eventParams );
} );
e.stopPropagation();
}
} );
} else {
$ulsTrigger.on( 'click', function ( e, eventParams ) {
var uls = $ulsTrigger.data( 'uls' );
e.preventDefault();
if ( uls ) {
if ( !uls.shown ) {
mw.hook( 'mw.uls.settings.open' ).fire( eventParams && eventParams.source || 'personal' );
@@ -445,8 +447,6 @@
window.setTimeout( function () {
$ulsTrigger.trigger( 'click', eventParams );
}, 0 );
e.stopPropagation();
} );
}
} );