bryce/mediawiki-extensions-UniversalLanguageSelector
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Remove browser checks and use MediaWiki browser policy

Browse Source 
We had a browser check to blacklist all browsers older than IE 8
IE <= 7

But that is no longer required since JS support is not there for such
browsers as per https://www.mediawiki.org/wiki/Compatibility#Modern
We can support all modern browsers listed there and we don't need
additional blacklisting now. From 1.27 onwards, there is no JS loaded
for IE 8 too. So we can just use MW browser support policy.

In this commit, the code to do brower checks removed and simplified
the initialization code. Still I am not happy with the interface module,
that need further refactoring.

Change-Id: I655826c55fb2c7c5c88f16368110142d64a96eec
This commit is contained in:
Santhosh Thottingal
2016-04-12 10:39:28 +05:30
parent d964a10c83
commit 64eab95b94
4 changed files with 170 additions and 203 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
resources/js/ext.uls.webfonts.js
View File

@@ -87,7 +87,9 @@
length = Math.min( 4, text.length ),
detected = false;
if ( $.client.test( { msie: false } ) ) {
if ( $.client.test( {
msie: false
} ) ) {
// IE shows a different tofu for unassigned code points!
text = tofuSalt + text;
}
@@ -222,12 +224,10 @@
};
$( document ).ready( function () {
mw.uls.init( function () {
mw.webfonts.preferences.load();
mw.webfonts.preferences.load();
if ( mw.webfonts.preferences.isEnabled() ) {
mw.loader.using( 'ext.uls.webfonts.fonts', mw.webfonts.setup );
}
} );
if ( mw.webfonts.preferences.isEnabled() ) {
mw.loader.using( 'ext.uls.webfonts.fonts', mw.webfonts.setup );
}
} );
}( jQuery, mediaWiki ) );