bryce/mediawiki-extensions-UniversalLanguageSelector
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Remove wgULSCompactLinks configuration variable

Browse Source 
This was used to expose Compact language links as beta feature.
Now a days, we want it as beta feature unconditionally and this
configuration does not make sense. So removing.

Bug: T134145
Change-Id: I40d5c07064b5f407ec37837b0835e0698f3a5256
This commit is contained in:
Santhosh Thottingal
2016-04-28 11:01:21 +05:30
committed by Santhosh
parent babaee831f
commit 695ea37918
2 changed files with 5 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
UniversalLanguageSelector.hooks.php
View File

@@ -50,7 +50,7 @@ class UniversalLanguageSelectorHooks {
* Hook: BeforePageDisplay * Hook: BeforePageDisplay
*/ */
public static function addModules( $out, $skin ) { public static function addModules( $out, $skin ) {
global $wgULSCompactLinks, $wgULSPosition, $wgULSGeoService, $wgULSEventLogging, global $wgULSPosition, $wgULSGeoService, $wgULSEventLogging,
$wgInterwikiMagic, $wgHideInterlanguageLinks; $wgInterwikiMagic, $wgHideInterlanguageLinks;
// Load the style for users without JS, to hide the useless links // Load the style for users without JS, to hide the useless links
@@ -70,8 +70,7 @@ class UniversalLanguageSelectorHooks {
// If compact ULS beta feature is enabled and is actually functional // If compact ULS beta feature is enabled and is actually functional
// (see onGetBetaFeaturePreferences) // (see onGetBetaFeaturePreferences)
if ( $wgULSCompactLinks && if ( $wgInterwikiMagic === true &&
$wgInterwikiMagic === true &&
$wgHideInterlanguageLinks === false && $wgHideInterlanguageLinks === false &&
class_exists( 'BetaFeatures' ) && class_exists( 'BetaFeatures' ) &&
BetaFeatures::isFeatureEnabled( $out->getUser(), 'uls-compact-links' ) BetaFeatures::isFeatureEnabled( $out->getUser(), 'uls-compact-links' )
@@ -328,11 +327,10 @@ class UniversalLanguageSelectorHooks {
} }
public static function onGetBetaFeaturePreferences( $user, &$prefs ) { public static function onGetBetaFeaturePreferences( $user, &$prefs ) {
global $wgExtensionAssetsPath, $wgULSCompactLinks, global $wgExtensionAssetsPath,
$wgHideInterlanguageLinks, $wgInterwikiMagic; $wgHideInterlanguageLinks, $wgInterwikiMagic;
if ( $wgULSCompactLinks && if ( $wgInterwikiMagic === true &&
$wgInterwikiMagic === true &&
$wgHideInterlanguageLinks === false $wgHideInterlanguageLinks === false
) { ) {
$imagesDir = "$wgExtensionAssetsPath/UniversalLanguageSelector/resources/images"; $imagesDir = "$wgExtensionAssetsPath/UniversalLanguageSelector/resources/images";

4
extension.json
View File

@@ -88,9 +88,7 @@
"#p-lang li.interlanguage-link > a" "#p-lang li.interlanguage-link > a"
], ],
"@ULSFontRepositoryBasePath": "Base path of ULS font repository. If not set, will be set to 'UniversalLanguageSelector/data/fontrepo/fonts/', relative to $wgExtensionAssetsPath. @since 2013.10", "@ULSFontRepositoryBasePath": "Base path of ULS font repository. If not set, will be set to 'UniversalLanguageSelector/data/fontrepo/fonts/', relative to $wgExtensionAssetsPath. @since 2013.10",
"ULSFontRepositoryBasePath": false, "ULSFontRepositoryBasePath": false
"@ULSCompactLinks": "Whether the \"Compact language links\" Beta Feature is exposed. Requires $wgULSPosition to be \"interlanguage\". Defaults to false. @since 2014.03",
"ULSCompactLinks": false
}, },
"callback": "UniversalLanguageSelectorHooks::setVersionConstant", "callback": "UniversalLanguageSelectorHooks::setVersionConstant",
"ResourceModules": { "ResourceModules": {