From 6ac12b6584299b4db40438f4be1ed5e15a6d0edd Mon Sep 17 00:00:00 2001 From: Santhosh Thottingal Date: Fri, 19 Jul 2013 11:31:09 +0530 Subject: [PATCH] Better blacklisting of browsers using $.client Change-Id: Ibc4d15008671700374fdc1e33d2e85f9899f9b35 --- Resources.php | 1 + resources/js/ext.uls.init.js | 9 ++++++--- 2 files changed, 7 insertions(+), 3 deletions(-) diff --git a/Resources.php b/Resources.php index ecc6036a..5e80ac5d 100644 --- a/Resources.php +++ b/Resources.php @@ -56,6 +56,7 @@ $wgResourceModules['ext.uls.init'] = array( 'ext.uls.languagenames', 'mediawiki.Uri', 'mediawiki.util', + 'jquery.client', 'jquery.json', 'jquery.uls', 'ext.uls.i18n', diff --git a/resources/js/ext.uls.init.js b/resources/js/ext.uls.init.js index 1fc9649b..90e72858 100644 --- a/resources/js/ext.uls.init.js +++ b/resources/js/ext.uls.init.js @@ -141,12 +141,15 @@ /** * Checks whether the browser is supported. - * Browse support policy: http://www.mediawiki.org/wiki/Browser_support#Grade_A + * Browser support policy: http://www.mediawiki.org/wiki/Browser_support#Grade_A * @return boolean */ function isBrowserSupported() { - // Blacklist Grade B browsers IE 6, 7 and IE60-IE79 - return !/MSIE [67]/i.test( navigator.userAgent ); + var blacklist = { + 'msie': [['<=', 7]] + }; + + return !$.client.test( blacklist, null, true ); } /**