From 760674d965fcc5856e447ab35ad57244165c244a Mon Sep 17 00:00:00 2001
From: Fomafix <fomafix@googlemail.com>
Date: Thu, 2 May 2019 06:24:44 +0200
Subject: [PATCH] Add type hints to used objects and arrays in hooks

Also mark only local used functions as private function.

Change-Id: I5fa27d0be492a4a936e6b30b2a16655ed3746fdd
---
 includes/UniversalLanguageSelectorHooks.php | 16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)

diff --git a/includes/UniversalLanguageSelectorHooks.php b/includes/UniversalLanguageSelectorHooks.php
index bfbe86da..385bc722 100644
--- a/includes/UniversalLanguageSelectorHooks.php
+++ b/includes/UniversalLanguageSelectorHooks.php
@@ -33,7 +33,7 @@ class UniversalLanguageSelectorHooks {
 	 * @param User $user
 	 * @return bool
 	 */
-	public static function isToolbarEnabled( $user ) {
+	private static function isToolbarEnabled( User $user ) {
 		global $wgULSEnable, $wgULSEnableAnon;
 
 		if ( !$wgULSEnable ) {
@@ -52,7 +52,7 @@ class UniversalLanguageSelectorHooks {
 	 * @param User $user
 	 * @return bool
 	 */
-	public static function isCompactLinksEnabled( $user ) {
+	private static function isCompactLinksEnabled( User $user ) {
 		global $wgULSEnable, $wgInterwikiMagic,
 			$wgULSCompactLinksEnableAnon,
 			$wgHideInterlanguageLinks, $wgULSCompactLanguageLinksBetaFeature;
@@ -106,7 +106,7 @@ class UniversalLanguageSelectorHooks {
 	 * @param Skin $skin
 	 * Hook: BeforePageDisplay
 	 */
-	public static function addModules( $out, $skin ) {
+	public static function addModules( OutputPage $out, $skin ) {
 		global $wgULSPosition, $wgULSGeoService;
 
 		// Soft dependency to Wikibase client. Don't enable CLL if links are managed manually.
@@ -296,7 +296,7 @@ class UniversalLanguageSelectorHooks {
 	 * Hook: ResourceLoaderGetConfigVars
 	 * @param array &$vars
 	 */
-	public static function addConfig( &$vars ) {
+	public static function addConfig( array &$vars ) {
 		global $wgULSGeoService,
 			$wgULSIMEEnabled, $wgULSWebfontsEnabled,
 			$wgULSPosition, $wgULSNoWebfontsSelectors,
@@ -340,7 +340,7 @@ class UniversalLanguageSelectorHooks {
 	 * @param array &$vars
 	 * @param OutputPage $out
 	 */
-	public static function addVariables( &$vars, OutputPage $out ) {
+	public static function addVariables( array &$vars, OutputPage $out ) {
 		global $wgULSAnonCanChangeLanguage;
 
 		// Place request context dependent stuff here
@@ -369,7 +369,7 @@ class UniversalLanguageSelectorHooks {
 		$vars['wgULSCurrentAutonym'] = Language::fetchLanguageName( $langCode );
 	}
 
-	public static function onGetPreferences( $user, &$preferences ) {
+	public static function onGetPreferences( $user, array &$preferences ) {
 		global $wgULSCompactLanguageLinksBetaFeature;
 
 		$preferences['uls-preferences'] = [
@@ -399,7 +399,7 @@ class UniversalLanguageSelectorHooks {
 		}
 	}
 
-	public static function onGetBetaFeaturePreferences( $user, &$prefs ) {
+	public static function onGetBetaFeaturePreferences( $user, array &$prefs ) {
 		global $wgExtensionAssetsPath, $wgULSCompactLanguageLinksBetaFeature,
 			$wgHideInterlanguageLinks, $wgInterwikiMagic;
 
@@ -453,7 +453,7 @@ class UniversalLanguageSelectorHooks {
 	 * Hook: EnterMobileMode
 	 * @param MobileContext $context
 	 */
-	public static function onEnterMobileMode( $context ) {
+	public static function onEnterMobileMode( MobileContext $context ) {
 		global $wgULSEnable, $wgULSMobileWebfontsEnabled;
 
 		// Currently only supported in mobile Beta mode