bryce/mediawiki-extensions-UniversalLanguageSelector
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Followup I59dfcfb25c, language change work with out event logging

Browse Source 
In I59dfcfb25c, for logging events when page is navigating away, we
used callbacks with mw.hook. That is wrong approach. If event logging
is disabled those callbacks will never called: it broke language change
and all use cases which navigates away from current page.

Event logging should not interfere with any ULS functionality. If ULS
functionality depends on callbacks from event logging, it is wrong.

In this patch, we give a small time window to make sure event logging is
fired, but we won't wait for its success or failure.

If eventlogging is disabled, this time window does not exist.

Change-Id: I0b7d9d8b9d1d01b99422010596ebfa80b2589d04
This commit is contained in:
Santhosh Thottingal
2013-08-17 11:15:33 +05:30
committed by Nikerabbit
parent 1f66cb22bc
commit 7649b47f5c
4 changed files with 50 additions and 36 deletions
Download Patch File Download Diff File Expand all files Collapse all files

42
resources/js/ext.uls.eventlogger.js
View File

@@ -48,21 +48,16 @@
},
/**
* Local wrapper for 'mw.eventLog.logEvent' which handles default params
* and ensures the correct schema is loaded.
* Local wrapper for 'mw.eventLog.logEvent'
*
* @param {Object} event Event action and optional fields
* @param {int} [timeout] Fail the request if it is not completed within
* the specified timeout. Can be use for example to log actions that
* cause the browser to navigate to other pages.
* @return {jQuery.Promise} jQuery Promise object for the logging call
*/
log: function ( event, timeout ) {
log: function ( event ) {
// We need to create our own deferred for two reasons:
// - logEvent might not be executed immediately
// - we cannot reject a promise returned by it
// So we proxy the original promises status updates
// and register our timeout if requested (for links).
// So we proxy the original promises status updates.
var deferred = $.Deferred();
this.logEventQueue.add( function () {
@@ -71,10 +66,6 @@
.fail( deferred.reject );
} );
if ( timeout !== undefined ) {
window.setTimeout( deferred.reject, timeout );
}
return deferred.promise();
},
@@ -110,11 +101,10 @@
/**
* Log language revert
*
* @param {Function} callback
* @param {jQuery.Deferred} deferred
*/
ulsLanguageRevert: function ( callback ) {
this.log( { action: 'ui-lang-revert' }, 500 ).always( callback );
ulsLanguageRevert: function ( deferred ) {
this.log( { action: 'ui-lang-revert' } ).always( deferred.resolve() );
},
/**
@@ -132,17 +122,11 @@
},
/**
* Log login link click in display settings. Since this will navigate
* away from the current page, provide a callback option.
*
* If page is navigating away, event logging will fail because it is not
* yet completed. With the callback, the navigation can be executed in
* callback. The waiting for callback is not indefinite, but with a timeout.
*
* @param {Function} callback
* Log login link click in display settings.
* @param {jQuery.Deferred} deferred
*/
loginClick: function ( callback ) {
this.log( { action: 'login-click' }, 500 ).always( callback );
loginClick: function ( deferred ) {
this.log( { action: 'login-click' } ).always( deferred.resolve );
},
/**
@@ -159,14 +143,14 @@
* Log interface language change
*
* @param {string} language language code
* @param {Function} callback
* @param {jQuery.Deferred} deferred
*/
interfaceLanguageChange: function ( language, callback ) {
interfaceLanguageChange: function ( language, deferred ) {
this.log( {
action: 'language-change',
context: 'interface',
interfaceLanguage: language
}, 500 ).always( callback );
} ).always( deferred.resolve );
},
/**